Uh oh!
There was an error while loading. Please reload this page.
crypto: enable SM4-GCM, SM4-CCM, and SM4-XTS ciphers - #65480
Closed
panva wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
nodejs-github-bot
commented
Aug 22, 2026
Collaborator
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #65480 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.01%
==========================================
Files 751 751 Lines 252473 252473 Branches 47489 47504 +15 ==========================================
- Hits 227561 227548 -13 - Misses 16207 16250 +43 + Partials 8705 8675 -30 🚀 New features to boost your workflow:
|
nodejs-github-bot
commented
Aug 22, 2026
Collaborator
panva
commented
Aug 22, 2026
MemberAuthor
I'll do a broader refactor of this and the cipher discovery. |
panva
commented
Aug 24, 2026
MemberAuthor
Superseded by #65484 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SM4 was already available through the Cipher/Decipher APIs, but provider-only GCM, CCM, and XTS modes were not exposed.
Alternative to #65399
Fixes: #64866