Skip to content

crypto: enable SM4-GCM, SM4-CCM, and SM4-XTS ciphers - #65480

Closed
panva wants to merge 2 commits into
nodejs:mainfrom
panva:crypto-sm4-ciphers
Closed

crypto: enable SM4-GCM, SM4-CCM, and SM4-XTS ciphers#65480
panva wants to merge 2 commits into
nodejs:mainfrom
panva:crypto-sm4-ciphers

Conversation

@panva

@panvapanva commented Aug 22, 2026

Copy link
Copy Markdown
Member

SM4 was already available through the Cipher/Decipher APIs, but provider-only GCM, CCM, and XTS modes were not exposed.

Alternative to #65399

Fixes: #64866

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Aug 22, 2026
@panvapanva added the crypto Issues and PRs related to the crypto subsystem. label Aug 22, 2026
@panva
panva requested review from jasnell and tniessenAugust 22, 2026 10:42
@codecov

codecovBot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (e573bd6) to head (e439b3d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65480 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.01% 
==========================================
Files 751 751 Lines 252473 252473 Branches 47489 47504 +15 ==========================================
- Hits 227561 227548 -13 - Misses 16207 16250 +43 + Partials 8705 8675 -30 

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva

Copy link
Copy Markdown
MemberAuthor

I'll do a broader refactor of this and the cipher discovery.

@panvapanva closed this Aug 22, 2026
@panva
panva deleted the crypto-sm4-ciphers branch August 24, 2026 08:47
@panva

Copy link
Copy Markdown
MemberAuthor

Superseded by #65484

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cryptoIssues and PRs related to the crypto subsystem.dependenciesPRs that add, update, or configure Node.js dependencies.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crypto: SM4-GCM and SM4-CCM not available despite OpenSSL 3.5 bundling the implementation

2 participants

@panva@nodejs-github-bot