[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs - #65483

Closed
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom
panva:backport-65423-26.x
Closed

[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs#65483
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom
panva:backport-65423-26.x

Conversation

@panva

@panvapanva commented Aug 22, 2026

Copy link
Copy Markdown
Member

Backports #65423 to v26.x, this is a clean backport with one caveat, it overrides the boringssl version used by test-shared.yml to match that on main at the time #65423 landed.

@panva
panva requested a review from aduh95August 22, 2026 11:53
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch. labels Aug 22, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov

codecovBot commented Aug 22, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (ca26282) to head (bc52379).
⚠️ Report is 1 commits behind head on v26.x-staging.

Additional details and impacted files
@@ Coverage Diff @@## v26.x-staging #65483 +/- ##
=================================================
- Coverage 90.24% 90.22% -0.02% 
=================================================
Files 729 729 Lines 242760 242760 Branches 46044 46050 +6 =================================================
- Hits 219073 219041 -32 - Misses 15133 15144 +11 - Partials 8554 8575 +21
Files with missing linesCoverage Δ
src/crypto/crypto_dh.cc65.66% <ø> (ø)
src/crypto/crypto_rsa.cc64.21% <ø> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva
tools: update BoringSSL pin on v26.x
abb03e6
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
crypto: remove obsolete BoringSSL shims
6c87d4f
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
crypto: use available BoringSSL APIs
bc52379
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
panvaforce-pushed the backport-65423-26.x branch from b7ceb4e to bc52379CompareAugust 23, 2026 15:09
@github-actions

github-actionsBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux459 -> 459 => no changes3 / 459 = 0.6%
aarch64-linux460 -> 460 => no changes3 / 460 = 0.6%
x86_64-darwin397 -> 397 => no changes3 / 397 = 0.7%
aarch64-darwin399 -> 399 => no changes3 / 399 = 0.7%
Total1715 -> 1715 => no changes12 / 1715 = 0.6%
Changelog
@@ -87,12 +87,12 @@-/nix/store/1k5vfgzqyn72h74v6ha9fihh7qbjrik0-boringssl-0.20260413.0 (aarch64-darwin)-/nix/store/k7hvxfz5mi1jcnzvfgmadpj61vcc2w0k-boringssl-0.20260413.0 (aarch64-linux)-/nix/store/pxmk721zyiw3n872vqiiz5cb05skmb34-boringssl-0.20260413.0 (x86_64-darwin)-/nix/store/n9g5v0naw03kxri26nm4zj0q85ypa3f6-boringssl-0.20260413.0 (x86_64-linux)-/nix/store/khfg0xszkmhb10fk7ghkx23b76nb1n8i-boringssl-0.20260413.0-bin (aarch64-darwin)-/nix/store/f6qciy5r9706hxd78wajsn92k27wnrq4-boringssl-0.20260413.0-bin (aarch64-linux)-/nix/store/jiz39z5bafzhy9qzq5d6gndi320p6gli-boringssl-0.20260413.0-bin (x86_64-darwin)-/nix/store/rs4yhnrd1v39wjnll2ahdpx9cda3nakn-boringssl-0.20260413.0-bin (x86_64-linux)-/nix/store/sfm292hxsmcbb49r35ww86wnhdp8x6vm-boringssl-0.20260413.0-dev (aarch64-darwin)-/nix/store/i6ccv7jpy8gb35nnhaj0cdv8blkg1w4r-boringssl-0.20260413.0-dev (aarch64-linux)-/nix/store/bzacx7cjjp1is1xh770bjid1ap15h66p-boringssl-0.20260413.0-dev (x86_64-darwin)-/nix/store/2b288h3ihsdmm24lmz5wbjx89ib8jd6v-boringssl-0.20260413.0-dev (x86_64-linux)+/nix/store/h0nnbhvw042c05840krknzp2gfnyan3n-boringssl-0.20260803.0 (aarch64-darwin)+/nix/store/22rfr95xasl2rqqr0aiimqkd074nrgvp-boringssl-0.20260803.0 (aarch64-linux)+/nix/store/lyjrr5k51c80cj8dgdhr6zgkbp4nmd7i-boringssl-0.20260803.0 (x86_64-darwin)+/nix/store/zpda1sh11x0l9zf2jqyj6j33gk650wdy-boringssl-0.20260803.0 (x86_64-linux)+/nix/store/kjvgsigj0lh1zc7lnyh93hqlv433z8pg-boringssl-0.20260803.0-bin (aarch64-darwin)+/nix/store/f105al617fdlhhjm02919xj22dgyn552-boringssl-0.20260803.0-bin (aarch64-linux)+/nix/store/s0zf1zkbjqgfpkfin8f1j3b0l6xrii90-boringssl-0.20260803.0-bin (x86_64-darwin)+/nix/store/x3b5va756lzjpgkxvfkvfx23066hnmk2-boringssl-0.20260803.0-bin (x86_64-linux)+/nix/store/i78kyxhs512a5d96si4lx5zvm76gq363-boringssl-0.20260803.0-dev (aarch64-darwin)+/nix/store/6zz04nbxwxlz2m04lb1vk1xa79i1rz70-boringssl-0.20260803.0-dev (aarch64-linux)+/nix/store/nqb5r8axdf6cnpldyv8ncd57ydm4mz18-boringssl-0.20260803.0-dev (x86_64-darwin)+/nix/store/ilzac8c0icc8v48fzmmsjqam4rwsh7gp-boringssl-0.20260803.0-dev (x86_64-linux)

@aduh95aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 24, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76435/

aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
15dac8c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
9e92114
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95

aduh95 commented Aug 25, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Landed in ffe1e7c...137ff67

aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
62d3602
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95aduh95 closed this Aug 25, 2026
@panva
panva deleted the backport-65423-26.x branch August 25, 2026 22:19
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
17d2b06
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
0e87576
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
137ff67
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
@codebyterecodebytere mentioned this pull request Aug 26, 2026
Closed
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
a9bd780
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
8029383
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@aduh95@pimterry
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs - #65483
Closed
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Closed
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs#65483
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Conversation
@panva
@panvapanva
commented
Aug 22, 2026

Copy link


Copy Markdown

Member
Backports #65423 to v26.x, this is a clean backport with one caveat, it overrides the boringssl version used by test-shared.yml to match that on main at the time #65423 landed.
@panva
panva
requested a review
from aduh95August 22, 2026 11:53
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
v26.x
Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.
labels
Aug 22, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 22, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.22%. Comparing base (ca26282) to head (bc52379).
⚠️ Report is 1 commits behind head on v26.x-staging.
Additional details and impacted files
@@ Coverage Diff @@## v26.x-staging #65483 +/- ##
=================================================
- Coverage 90.24% 90.22% -0.02% 
=================================================
Files 729 729 Lines 242760 242760 Branches 46044 46050 +6 =================================================
- Hits 219073 219041 -32 - Misses 15133 15144 +11 - Partials 8554 8575 +21 
Files with missing linesCoverage Δ
src/crypto/crypto_dh.cc65.66% <ø> (ø)
src/crypto/crypto_rsa.cc64.21% <ø> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
tools: update BoringSSL pin on v26.x
abb03e6
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
crypto: remove obsolete BoringSSL shims
6c87d4f
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
crypto: use available BoringSSL APIs
bc52379
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
panvaforce-pushed
the
backport-65423-26.x
branch
from
b7ceb4e to
bc52379CompareAugust 23, 2026 15:09
@github-actions
github-actionsBot
commented
Aug 23, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux459 -> 459 => no changes3 / 459 = 0.6%
aarch64-linux460 -> 460 => no changes3 / 460 = 0.6%
x86_64-darwin397 -> 397 => no changes3 / 397 = 0.7%
aarch64-darwin399 -> 399 => no changes3 / 399 = 0.7%
Total1715 -> 1715 => no changes12 / 1715 = 0.6%
Changelog
@@ -87,12 +87,12 @@-/nix/store/1k5vfgzqyn72h74v6ha9fihh7qbjrik0-boringssl-0.20260413.0 (aarch64-darwin)-/nix/store/k7hvxfz5mi1jcnzvfgmadpj61vcc2w0k-boringssl-0.20260413.0 (aarch64-linux)-/nix/store/pxmk721zyiw3n872vqiiz5cb05skmb34-boringssl-0.20260413.0 (x86_64-darwin)-/nix/store/n9g5v0naw03kxri26nm4zj0q85ypa3f6-boringssl-0.20260413.0 (x86_64-linux)-/nix/store/khfg0xszkmhb10fk7ghkx23b76nb1n8i-boringssl-0.20260413.0-bin (aarch64-darwin)-/nix/store/f6qciy5r9706hxd78wajsn92k27wnrq4-boringssl-0.20260413.0-bin (aarch64-linux)-/nix/store/jiz39z5bafzhy9qzq5d6gndi320p6gli-boringssl-0.20260413.0-bin (x86_64-darwin)-/nix/store/rs4yhnrd1v39wjnll2ahdpx9cda3nakn-boringssl-0.20260413.0-bin (x86_64-linux)-/nix/store/sfm292hxsmcbb49r35ww86wnhdp8x6vm-boringssl-0.20260413.0-dev (aarch64-darwin)-/nix/store/i6ccv7jpy8gb35nnhaj0cdv8blkg1w4r-boringssl-0.20260413.0-dev (aarch64-linux)-/nix/store/bzacx7cjjp1is1xh770bjid1ap15h66p-boringssl-0.20260413.0-dev (x86_64-darwin)-/nix/store/2b288h3ihsdmm24lmz5wbjx89ib8jd6v-boringssl-0.20260413.0-dev (x86_64-linux)+/nix/store/h0nnbhvw042c05840krknzp2gfnyan3n-boringssl-0.20260803.0 (aarch64-darwin)+/nix/store/22rfr95xasl2rqqr0aiimqkd074nrgvp-boringssl-0.20260803.0 (aarch64-linux)+/nix/store/lyjrr5k51c80cj8dgdhr6zgkbp4nmd7i-boringssl-0.20260803.0 (x86_64-darwin)+/nix/store/zpda1sh11x0l9zf2jqyj6j33gk650wdy-boringssl-0.20260803.0 (x86_64-linux)+/nix/store/kjvgsigj0lh1zc7lnyh93hqlv433z8pg-boringssl-0.20260803.0-bin (aarch64-darwin)+/nix/store/f105al617fdlhhjm02919xj22dgyn552-boringssl-0.20260803.0-bin (aarch64-linux)+/nix/store/s0zf1zkbjqgfpkfin8f1j3b0l6xrii90-boringssl-0.20260803.0-bin (x86_64-darwin)+/nix/store/x3b5va756lzjpgkxvfkvfx23066hnmk2-boringssl-0.20260803.0-bin (x86_64-linux)+/nix/store/i78kyxhs512a5d96si4lx5zvm76gq363-boringssl-0.20260803.0-dev (aarch64-darwin)+/nix/store/6zz04nbxwxlz2m04lb1vk1xa79i1rz70-boringssl-0.20260803.0-dev (aarch64-linux)+/nix/store/nqb5r8axdf6cnpldyv8ncd57ydm4mz18-boringssl-0.20260803.0-dev (x86_64-darwin)+/nix/store/ilzac8c0icc8v48fzmmsjqam4rwsh7gp-boringssl-0.20260803.0-dev (x86_64-linux)
@aduh95aduh95
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 24, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 24, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76435/
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
15dac8c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
9e92114
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95
aduh95
commented
Aug 25, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Landed in ffe1e7c...137ff67
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
62d3602
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95aduh95
closed this
Aug 25, 2026
@panva
panva
deleted the

backport-65423-26.x

branch
August 25, 2026 22:19
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
17d2b06
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
0e87576
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
137ff67
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@codebyterecodebytere
mentioned this pull request
Aug 26, 2026

Closed

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
a9bd780
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
8029383
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@aduh95@pimterry

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs - #65483
Closed
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Closed
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs#65483
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Conversation
@panva
@panvapanva
commented
Aug 22, 2026

Copy link


Copy Markdown

Member
Backports #65423 to v26.x, this is a clean backport with one caveat, it overrides the boringssl version used by test-shared.yml to match that on main at the time #65423 landed.
@panva
panva
requested a review
from aduh95August 22, 2026 11:53
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
v26.x
Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.
labels
Aug 22, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 22, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.22%. Comparing base (ca26282) to head (bc52379).
⚠️ Report is 1 commits behind head on v26.x-staging.
Additional details and impacted files
@@ Coverage Diff @@## v26.x-staging #65483 +/- ##
=================================================
- Coverage 90.24% 90.22% -0.02% 
=================================================
Files 729 729 Lines 242760 242760 Branches 46044 46050 +6 =================================================
- Hits 219073 219041 -32 - Misses 15133 15144 +11 - Partials 8554 8575 +21 
Files with missing linesCoverage Δ
src/crypto/crypto_dh.cc65.66% <ø> (ø)
src/crypto/crypto_rsa.cc64.21% <ø> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
tools: update BoringSSL pin on v26.x
abb03e6
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
crypto: remove obsolete BoringSSL shims
6c87d4f
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
crypto: use available BoringSSL APIs
bc52379
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
panvaforce-pushed
the
backport-65423-26.x
branch
from
b7ceb4e to
bc52379CompareAugust 23, 2026 15:09
@github-actions
github-actionsBot
commented
Aug 23, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux459 -> 459 => no changes3 / 459 = 0.6%
aarch64-linux460 -> 460 => no changes3 / 460 = 0.6%
x86_64-darwin397 -> 397 => no changes3 / 397 = 0.7%
aarch64-darwin399 -> 399 => no changes3 / 399 = 0.7%
Total1715 -> 1715 => no changes12 / 1715 = 0.6%
Changelog
@@ -87,12 +87,12 @@-/nix/store/1k5vfgzqyn72h74v6ha9fihh7qbjrik0-boringssl-0.20260413.0 (aarch64-darwin)-/nix/store/k7hvxfz5mi1jcnzvfgmadpj61vcc2w0k-boringssl-0.20260413.0 (aarch64-linux)-/nix/store/pxmk721zyiw3n872vqiiz5cb05skmb34-boringssl-0.20260413.0 (x86_64-darwin)-/nix/store/n9g5v0naw03kxri26nm4zj0q85ypa3f6-boringssl-0.20260413.0 (x86_64-linux)-/nix/store/khfg0xszkmhb10fk7ghkx23b76nb1n8i-boringssl-0.20260413.0-bin (aarch64-darwin)-/nix/store/f6qciy5r9706hxd78wajsn92k27wnrq4-boringssl-0.20260413.0-bin (aarch64-linux)-/nix/store/jiz39z5bafzhy9qzq5d6gndi320p6gli-boringssl-0.20260413.0-bin (x86_64-darwin)-/nix/store/rs4yhnrd1v39wjnll2ahdpx9cda3nakn-boringssl-0.20260413.0-bin (x86_64-linux)-/nix/store/sfm292hxsmcbb49r35ww86wnhdp8x6vm-boringssl-0.20260413.0-dev (aarch64-darwin)-/nix/store/i6ccv7jpy8gb35nnhaj0cdv8blkg1w4r-boringssl-0.20260413.0-dev (aarch64-linux)-/nix/store/bzacx7cjjp1is1xh770bjid1ap15h66p-boringssl-0.20260413.0-dev (x86_64-darwin)-/nix/store/2b288h3ihsdmm24lmz5wbjx89ib8jd6v-boringssl-0.20260413.0-dev (x86_64-linux)+/nix/store/h0nnbhvw042c05840krknzp2gfnyan3n-boringssl-0.20260803.0 (aarch64-darwin)+/nix/store/22rfr95xasl2rqqr0aiimqkd074nrgvp-boringssl-0.20260803.0 (aarch64-linux)+/nix/store/lyjrr5k51c80cj8dgdhr6zgkbp4nmd7i-boringssl-0.20260803.0 (x86_64-darwin)+/nix/store/zpda1sh11x0l9zf2jqyj6j33gk650wdy-boringssl-0.20260803.0 (x86_64-linux)+/nix/store/kjvgsigj0lh1zc7lnyh93hqlv433z8pg-boringssl-0.20260803.0-bin (aarch64-darwin)+/nix/store/f105al617fdlhhjm02919xj22dgyn552-boringssl-0.20260803.0-bin (aarch64-linux)+/nix/store/s0zf1zkbjqgfpkfin8f1j3b0l6xrii90-boringssl-0.20260803.0-bin (x86_64-darwin)+/nix/store/x3b5va756lzjpgkxvfkvfx23066hnmk2-boringssl-0.20260803.0-bin (x86_64-linux)+/nix/store/i78kyxhs512a5d96si4lx5zvm76gq363-boringssl-0.20260803.0-dev (aarch64-darwin)+/nix/store/6zz04nbxwxlz2m04lb1vk1xa79i1rz70-boringssl-0.20260803.0-dev (aarch64-linux)+/nix/store/nqb5r8axdf6cnpldyv8ncd57ydm4mz18-boringssl-0.20260803.0-dev (x86_64-darwin)+/nix/store/ilzac8c0icc8v48fzmmsjqam4rwsh7gp-boringssl-0.20260803.0-dev (x86_64-linux)
@aduh95aduh95
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 24, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 24, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76435/
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
15dac8c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
9e92114
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95
aduh95
commented
Aug 25, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Landed in ffe1e7c...137ff67
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
62d3602
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95aduh95
closed this
Aug 25, 2026
@panva
panva
deleted the

backport-65423-26.x

branch
August 25, 2026 22:19
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
17d2b06
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
0e87576
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
137ff67
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@codebyterecodebytere
mentioned this pull request
Aug 26, 2026

Closed

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
a9bd780
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
8029383
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@aduh95@pimterry

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs - #65483
Closed
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Closed
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs#65483
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Conversation
@panva
@panvapanva
commented
Aug 22, 2026

Copy link


Copy Markdown

Member
Backports #65423 to v26.x, this is a clean backport with one caveat, it overrides the boringssl version used by test-shared.yml to match that on main at the time #65423 landed.
@panva
panva
requested a review
from aduh95August 22, 2026 11:53
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
v26.x
Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.
labels
Aug 22, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 22, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.22%. Comparing base (ca26282) to head (bc52379).
⚠️ Report is 1 commits behind head on v26.x-staging.
Additional details and impacted files
@@ Coverage Diff @@## v26.x-staging #65483 +/- ##
=================================================
- Coverage 90.24% 90.22% -0.02% 
=================================================
Files 729 729 Lines 242760 242760 Branches 46044 46050 +6 =================================================
- Hits 219073 219041 -32 - Misses 15133 15144 +11 - Partials 8554 8575 +21 
Files with missing linesCoverage Δ
src/crypto/crypto_dh.cc65.66% <ø> (ø)
src/crypto/crypto_rsa.cc64.21% <ø> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
tools: update BoringSSL pin on v26.x
abb03e6
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
crypto: remove obsolete BoringSSL shims
6c87d4f
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
crypto: use available BoringSSL APIs
bc52379
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
panvaforce-pushed
the
backport-65423-26.x
branch
from
b7ceb4e to
bc52379CompareAugust 23, 2026 15:09
@github-actions
github-actionsBot
commented
Aug 23, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux459 -> 459 => no changes3 / 459 = 0.6%
aarch64-linux460 -> 460 => no changes3 / 460 = 0.6%
x86_64-darwin397 -> 397 => no changes3 / 397 = 0.7%
aarch64-darwin399 -> 399 => no changes3 / 399 = 0.7%
Total1715 -> 1715 => no changes12 / 1715 = 0.6%
Changelog
@@ -87,12 +87,12 @@-/nix/store/1k5vfgzqyn72h74v6ha9fihh7qbjrik0-boringssl-0.20260413.0 (aarch64-darwin)-/nix/store/k7hvxfz5mi1jcnzvfgmadpj61vcc2w0k-boringssl-0.20260413.0 (aarch64-linux)-/nix/store/pxmk721zyiw3n872vqiiz5cb05skmb34-boringssl-0.20260413.0 (x86_64-darwin)-/nix/store/n9g5v0naw03kxri26nm4zj0q85ypa3f6-boringssl-0.20260413.0 (x86_64-linux)-/nix/store/khfg0xszkmhb10fk7ghkx23b76nb1n8i-boringssl-0.20260413.0-bin (aarch64-darwin)-/nix/store/f6qciy5r9706hxd78wajsn92k27wnrq4-boringssl-0.20260413.0-bin (aarch64-linux)-/nix/store/jiz39z5bafzhy9qzq5d6gndi320p6gli-boringssl-0.20260413.0-bin (x86_64-darwin)-/nix/store/rs4yhnrd1v39wjnll2ahdpx9cda3nakn-boringssl-0.20260413.0-bin (x86_64-linux)-/nix/store/sfm292hxsmcbb49r35ww86wnhdp8x6vm-boringssl-0.20260413.0-dev (aarch64-darwin)-/nix/store/i6ccv7jpy8gb35nnhaj0cdv8blkg1w4r-boringssl-0.20260413.0-dev (aarch64-linux)-/nix/store/bzacx7cjjp1is1xh770bjid1ap15h66p-boringssl-0.20260413.0-dev (x86_64-darwin)-/nix/store/2b288h3ihsdmm24lmz5wbjx89ib8jd6v-boringssl-0.20260413.0-dev (x86_64-linux)+/nix/store/h0nnbhvw042c05840krknzp2gfnyan3n-boringssl-0.20260803.0 (aarch64-darwin)+/nix/store/22rfr95xasl2rqqr0aiimqkd074nrgvp-boringssl-0.20260803.0 (aarch64-linux)+/nix/store/lyjrr5k51c80cj8dgdhr6zgkbp4nmd7i-boringssl-0.20260803.0 (x86_64-darwin)+/nix/store/zpda1sh11x0l9zf2jqyj6j33gk650wdy-boringssl-0.20260803.0 (x86_64-linux)+/nix/store/kjvgsigj0lh1zc7lnyh93hqlv433z8pg-boringssl-0.20260803.0-bin (aarch64-darwin)+/nix/store/f105al617fdlhhjm02919xj22dgyn552-boringssl-0.20260803.0-bin (aarch64-linux)+/nix/store/s0zf1zkbjqgfpkfin8f1j3b0l6xrii90-boringssl-0.20260803.0-bin (x86_64-darwin)+/nix/store/x3b5va756lzjpgkxvfkvfx23066hnmk2-boringssl-0.20260803.0-bin (x86_64-linux)+/nix/store/i78kyxhs512a5d96si4lx5zvm76gq363-boringssl-0.20260803.0-dev (aarch64-darwin)+/nix/store/6zz04nbxwxlz2m04lb1vk1xa79i1rz70-boringssl-0.20260803.0-dev (aarch64-linux)+/nix/store/nqb5r8axdf6cnpldyv8ncd57ydm4mz18-boringssl-0.20260803.0-dev (x86_64-darwin)+/nix/store/ilzac8c0icc8v48fzmmsjqam4rwsh7gp-boringssl-0.20260803.0-dev (x86_64-linux)
@aduh95aduh95
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 24, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 24, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76435/
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
15dac8c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
9e92114
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95
aduh95
commented
Aug 25, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Landed in ffe1e7c...137ff67
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
62d3602
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95aduh95
closed this
Aug 25, 2026
@panva
panva
deleted the

backport-65423-26.x

branch
August 25, 2026 22:19
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
17d2b06
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
0e87576
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
137ff67
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@codebyterecodebytere
mentioned this pull request
Aug 26, 2026

Closed

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
a9bd780
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
8029383
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@aduh95@pimterry

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs - #65483
Closed
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Closed
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs#65483
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Conversation
@panva
@panvapanva
commented
Aug 22, 2026

Copy link


Copy Markdown

Member
Backports #65423 to v26.x, this is a clean backport with one caveat, it overrides the boringssl version used by test-shared.yml to match that on main at the time #65423 landed.
@panva
panva
requested a review
from aduh95August 22, 2026 11:53
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
v26.x
Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.
labels
Aug 22, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 22, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.22%. Comparing base (ca26282) to head (bc52379).
⚠️ Report is 1 commits behind head on v26.x-staging.
Additional details and impacted files
@@ Coverage Diff @@## v26.x-staging #65483 +/- ##
=================================================
- Coverage 90.24% 90.22% -0.02% 
=================================================
Files 729 729 Lines 242760 242760 Branches 46044 46050 +6 =================================================
- Hits 219073 219041 -32 - Misses 15133 15144 +11 - Partials 8554 8575 +21 
Files with missing linesCoverage Δ
src/crypto/crypto_dh.cc65.66% <ø> (ø)
src/crypto/crypto_rsa.cc64.21% <ø> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
tools: update BoringSSL pin on v26.x
abb03e6
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
crypto: remove obsolete BoringSSL shims
6c87d4f
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
crypto: use available BoringSSL APIs
bc52379
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
panvaforce-pushed
the
backport-65423-26.x
branch
from
b7ceb4e to
bc52379CompareAugust 23, 2026 15:09
@github-actions
github-actionsBot
commented
Aug 23, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux459 -> 459 => no changes3 / 459 = 0.6%
aarch64-linux460 -> 460 => no changes3 / 460 = 0.6%
x86_64-darwin397 -> 397 => no changes3 / 397 = 0.7%
aarch64-darwin399 -> 399 => no changes3 / 399 = 0.7%
Total1715 -> 1715 => no changes12 / 1715 = 0.6%
Changelog
@@ -87,12 +87,12 @@-/nix/store/1k5vfgzqyn72h74v6ha9fihh7qbjrik0-boringssl-0.20260413.0 (aarch64-darwin)-/nix/store/k7hvxfz5mi1jcnzvfgmadpj61vcc2w0k-boringssl-0.20260413.0 (aarch64-linux)-/nix/store/pxmk721zyiw3n872vqiiz5cb05skmb34-boringssl-0.20260413.0 (x86_64-darwin)-/nix/store/n9g5v0naw03kxri26nm4zj0q85ypa3f6-boringssl-0.20260413.0 (x86_64-linux)-/nix/store/khfg0xszkmhb10fk7ghkx23b76nb1n8i-boringssl-0.20260413.0-bin (aarch64-darwin)-/nix/store/f6qciy5r9706hxd78wajsn92k27wnrq4-boringssl-0.20260413.0-bin (aarch64-linux)-/nix/store/jiz39z5bafzhy9qzq5d6gndi320p6gli-boringssl-0.20260413.0-bin (x86_64-darwin)-/nix/store/rs4yhnrd1v39wjnll2ahdpx9cda3nakn-boringssl-0.20260413.0-bin (x86_64-linux)-/nix/store/sfm292hxsmcbb49r35ww86wnhdp8x6vm-boringssl-0.20260413.0-dev (aarch64-darwin)-/nix/store/i6ccv7jpy8gb35nnhaj0cdv8blkg1w4r-boringssl-0.20260413.0-dev (aarch64-linux)-/nix/store/bzacx7cjjp1is1xh770bjid1ap15h66p-boringssl-0.20260413.0-dev (x86_64-darwin)-/nix/store/2b288h3ihsdmm24lmz5wbjx89ib8jd6v-boringssl-0.20260413.0-dev (x86_64-linux)+/nix/store/h0nnbhvw042c05840krknzp2gfnyan3n-boringssl-0.20260803.0 (aarch64-darwin)+/nix/store/22rfr95xasl2rqqr0aiimqkd074nrgvp-boringssl-0.20260803.0 (aarch64-linux)+/nix/store/lyjrr5k51c80cj8dgdhr6zgkbp4nmd7i-boringssl-0.20260803.0 (x86_64-darwin)+/nix/store/zpda1sh11x0l9zf2jqyj6j33gk650wdy-boringssl-0.20260803.0 (x86_64-linux)+/nix/store/kjvgsigj0lh1zc7lnyh93hqlv433z8pg-boringssl-0.20260803.0-bin (aarch64-darwin)+/nix/store/f105al617fdlhhjm02919xj22dgyn552-boringssl-0.20260803.0-bin (aarch64-linux)+/nix/store/s0zf1zkbjqgfpkfin8f1j3b0l6xrii90-boringssl-0.20260803.0-bin (x86_64-darwin)+/nix/store/x3b5va756lzjpgkxvfkvfx23066hnmk2-boringssl-0.20260803.0-bin (x86_64-linux)+/nix/store/i78kyxhs512a5d96si4lx5zvm76gq363-boringssl-0.20260803.0-dev (aarch64-darwin)+/nix/store/6zz04nbxwxlz2m04lb1vk1xa79i1rz70-boringssl-0.20260803.0-dev (aarch64-linux)+/nix/store/nqb5r8axdf6cnpldyv8ncd57ydm4mz18-boringssl-0.20260803.0-dev (x86_64-darwin)+/nix/store/ilzac8c0icc8v48fzmmsjqam4rwsh7gp-boringssl-0.20260803.0-dev (x86_64-linux)
@aduh95aduh95
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 24, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 24, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76435/
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
15dac8c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
9e92114
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95
aduh95
commented
Aug 25, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Landed in ffe1e7c...137ff67
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
62d3602
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95aduh95
closed this
Aug 25, 2026
@panva
panva
deleted the

backport-65423-26.x

branch
August 25, 2026 22:19
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
17d2b06
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
0e87576
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
137ff67
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@codebyterecodebytere
mentioned this pull request
Aug 26, 2026

Closed

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
a9bd780
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
8029383
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@aduh95@pimterry

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs - #65483
Closed
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Closed
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs#65483
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Conversation
@panva
@panvapanva
commented
Aug 22, 2026

Copy link


Copy Markdown

Member
Backports #65423 to v26.x, this is a clean backport with one caveat, it overrides the boringssl version used by test-shared.yml to match that on main at the time #65423 landed.
@panva
panva
requested a review
from aduh95August 22, 2026 11:53
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
v26.x
Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.
labels
Aug 22, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 22, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.22%. Comparing base (ca26282) to head (bc52379).
⚠️ Report is 1 commits behind head on v26.x-staging.
Additional details and impacted files
@@ Coverage Diff @@## v26.x-staging #65483 +/- ##
=================================================
- Coverage 90.24% 90.22% -0.02% 
=================================================
Files 729 729 Lines 242760 242760 Branches 46044 46050 +6 =================================================
- Hits 219073 219041 -32 - Misses 15133 15144 +11 - Partials 8554 8575 +21 
Files with missing linesCoverage Δ
src/crypto/crypto_dh.cc65.66% <ø> (ø)
src/crypto/crypto_rsa.cc64.21% <ø> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
tools: update BoringSSL pin on v26.x
abb03e6
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
crypto: remove obsolete BoringSSL shims
6c87d4f
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
crypto: use available BoringSSL APIs
bc52379
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
panvaforce-pushed
the
backport-65423-26.x
branch
from
b7ceb4e to
bc52379CompareAugust 23, 2026 15:09
@github-actions
github-actionsBot
commented
Aug 23, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux459 -> 459 => no changes3 / 459 = 0.6%
aarch64-linux460 -> 460 => no changes3 / 460 = 0.6%
x86_64-darwin397 -> 397 => no changes3 / 397 = 0.7%
aarch64-darwin399 -> 399 => no changes3 / 399 = 0.7%
Total1715 -> 1715 => no changes12 / 1715 = 0.6%
Changelog
@@ -87,12 +87,12 @@-/nix/store/1k5vfgzqyn72h74v6ha9fihh7qbjrik0-boringssl-0.20260413.0 (aarch64-darwin)-/nix/store/k7hvxfz5mi1jcnzvfgmadpj61vcc2w0k-boringssl-0.20260413.0 (aarch64-linux)-/nix/store/pxmk721zyiw3n872vqiiz5cb05skmb34-boringssl-0.20260413.0 (x86_64-darwin)-/nix/store/n9g5v0naw03kxri26nm4zj0q85ypa3f6-boringssl-0.20260413.0 (x86_64-linux)-/nix/store/khfg0xszkmhb10fk7ghkx23b76nb1n8i-boringssl-0.20260413.0-bin (aarch64-darwin)-/nix/store/f6qciy5r9706hxd78wajsn92k27wnrq4-boringssl-0.20260413.0-bin (aarch64-linux)-/nix/store/jiz39z5bafzhy9qzq5d6gndi320p6gli-boringssl-0.20260413.0-bin (x86_64-darwin)-/nix/store/rs4yhnrd1v39wjnll2ahdpx9cda3nakn-boringssl-0.20260413.0-bin (x86_64-linux)-/nix/store/sfm292hxsmcbb49r35ww86wnhdp8x6vm-boringssl-0.20260413.0-dev (aarch64-darwin)-/nix/store/i6ccv7jpy8gb35nnhaj0cdv8blkg1w4r-boringssl-0.20260413.0-dev (aarch64-linux)-/nix/store/bzacx7cjjp1is1xh770bjid1ap15h66p-boringssl-0.20260413.0-dev (x86_64-darwin)-/nix/store/2b288h3ihsdmm24lmz5wbjx89ib8jd6v-boringssl-0.20260413.0-dev (x86_64-linux)+/nix/store/h0nnbhvw042c05840krknzp2gfnyan3n-boringssl-0.20260803.0 (aarch64-darwin)+/nix/store/22rfr95xasl2rqqr0aiimqkd074nrgvp-boringssl-0.20260803.0 (aarch64-linux)+/nix/store/lyjrr5k51c80cj8dgdhr6zgkbp4nmd7i-boringssl-0.20260803.0 (x86_64-darwin)+/nix/store/zpda1sh11x0l9zf2jqyj6j33gk650wdy-boringssl-0.20260803.0 (x86_64-linux)+/nix/store/kjvgsigj0lh1zc7lnyh93hqlv433z8pg-boringssl-0.20260803.0-bin (aarch64-darwin)+/nix/store/f105al617fdlhhjm02919xj22dgyn552-boringssl-0.20260803.0-bin (aarch64-linux)+/nix/store/s0zf1zkbjqgfpkfin8f1j3b0l6xrii90-boringssl-0.20260803.0-bin (x86_64-darwin)+/nix/store/x3b5va756lzjpgkxvfkvfx23066hnmk2-boringssl-0.20260803.0-bin (x86_64-linux)+/nix/store/i78kyxhs512a5d96si4lx5zvm76gq363-boringssl-0.20260803.0-dev (aarch64-darwin)+/nix/store/6zz04nbxwxlz2m04lb1vk1xa79i1rz70-boringssl-0.20260803.0-dev (aarch64-linux)+/nix/store/nqb5r8axdf6cnpldyv8ncd57ydm4mz18-boringssl-0.20260803.0-dev (x86_64-darwin)+/nix/store/ilzac8c0icc8v48fzmmsjqam4rwsh7gp-boringssl-0.20260803.0-dev (x86_64-linux)
@aduh95aduh95
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 24, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 24, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76435/
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
15dac8c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
9e92114
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95
aduh95
commented
Aug 25, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Landed in ffe1e7c...137ff67
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
62d3602
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95aduh95
closed this
Aug 25, 2026
@panva
panva
deleted the

backport-65423-26.x

branch
August 25, 2026 22:19
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
17d2b06
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
0e87576
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
137ff67
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@codebyterecodebytere
mentioned this pull request
Aug 26, 2026

Closed

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
a9bd780
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
8029383
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@aduh95@pimterry

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs - #65483
Closed
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Closed
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs#65483
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Conversation
@panva
@panvapanva
commented
Aug 22, 2026

Copy link


Copy Markdown

Member
Backports #65423 to v26.x, this is a clean backport with one caveat, it overrides the boringssl version used by test-shared.yml to match that on main at the time #65423 landed.
@panva
panva
requested a review
from aduh95August 22, 2026 11:53
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
v26.x
Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.
labels
Aug 22, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 22, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.22%. Comparing base (ca26282) to head (bc52379).
⚠️ Report is 1 commits behind head on v26.x-staging.
Additional details and impacted files
@@ Coverage Diff @@## v26.x-staging #65483 +/- ##
=================================================
- Coverage 90.24% 90.22% -0.02% 
=================================================
Files 729 729 Lines 242760 242760 Branches 46044 46050 +6 =================================================
- Hits 219073 219041 -32 - Misses 15133 15144 +11 - Partials 8554 8575 +21 
Files with missing linesCoverage Δ
src/crypto/crypto_dh.cc65.66% <ø> (ø)
src/crypto/crypto_rsa.cc64.21% <ø> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
tools: update BoringSSL pin on v26.x
abb03e6
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
crypto: remove obsolete BoringSSL shims
6c87d4f
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
crypto: use available BoringSSL APIs
bc52379
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
panvaforce-pushed
the
backport-65423-26.x
branch
from
b7ceb4e to
bc52379CompareAugust 23, 2026 15:09
@github-actions
github-actionsBot
commented
Aug 23, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux459 -> 459 => no changes3 / 459 = 0.6%
aarch64-linux460 -> 460 => no changes3 / 460 = 0.6%
x86_64-darwin397 -> 397 => no changes3 / 397 = 0.7%
aarch64-darwin399 -> 399 => no changes3 / 399 = 0.7%
Total1715 -> 1715 => no changes12 / 1715 = 0.6%
Changelog
@@ -87,12 +87,12 @@-/nix/store/1k5vfgzqyn72h74v6ha9fihh7qbjrik0-boringssl-0.20260413.0 (aarch64-darwin)-/nix/store/k7hvxfz5mi1jcnzvfgmadpj61vcc2w0k-boringssl-0.20260413.0 (aarch64-linux)-/nix/store/pxmk721zyiw3n872vqiiz5cb05skmb34-boringssl-0.20260413.0 (x86_64-darwin)-/nix/store/n9g5v0naw03kxri26nm4zj0q85ypa3f6-boringssl-0.20260413.0 (x86_64-linux)-/nix/store/khfg0xszkmhb10fk7ghkx23b76nb1n8i-boringssl-0.20260413.0-bin (aarch64-darwin)-/nix/store/f6qciy5r9706hxd78wajsn92k27wnrq4-boringssl-0.20260413.0-bin (aarch64-linux)-/nix/store/jiz39z5bafzhy9qzq5d6gndi320p6gli-boringssl-0.20260413.0-bin (x86_64-darwin)-/nix/store/rs4yhnrd1v39wjnll2ahdpx9cda3nakn-boringssl-0.20260413.0-bin (x86_64-linux)-/nix/store/sfm292hxsmcbb49r35ww86wnhdp8x6vm-boringssl-0.20260413.0-dev (aarch64-darwin)-/nix/store/i6ccv7jpy8gb35nnhaj0cdv8blkg1w4r-boringssl-0.20260413.0-dev (aarch64-linux)-/nix/store/bzacx7cjjp1is1xh770bjid1ap15h66p-boringssl-0.20260413.0-dev (x86_64-darwin)-/nix/store/2b288h3ihsdmm24lmz5wbjx89ib8jd6v-boringssl-0.20260413.0-dev (x86_64-linux)+/nix/store/h0nnbhvw042c05840krknzp2gfnyan3n-boringssl-0.20260803.0 (aarch64-darwin)+/nix/store/22rfr95xasl2rqqr0aiimqkd074nrgvp-boringssl-0.20260803.0 (aarch64-linux)+/nix/store/lyjrr5k51c80cj8dgdhr6zgkbp4nmd7i-boringssl-0.20260803.0 (x86_64-darwin)+/nix/store/zpda1sh11x0l9zf2jqyj6j33gk650wdy-boringssl-0.20260803.0 (x86_64-linux)+/nix/store/kjvgsigj0lh1zc7lnyh93hqlv433z8pg-boringssl-0.20260803.0-bin (aarch64-darwin)+/nix/store/f105al617fdlhhjm02919xj22dgyn552-boringssl-0.20260803.0-bin (aarch64-linux)+/nix/store/s0zf1zkbjqgfpkfin8f1j3b0l6xrii90-boringssl-0.20260803.0-bin (x86_64-darwin)+/nix/store/x3b5va756lzjpgkxvfkvfx23066hnmk2-boringssl-0.20260803.0-bin (x86_64-linux)+/nix/store/i78kyxhs512a5d96si4lx5zvm76gq363-boringssl-0.20260803.0-dev (aarch64-darwin)+/nix/store/6zz04nbxwxlz2m04lb1vk1xa79i1rz70-boringssl-0.20260803.0-dev (aarch64-linux)+/nix/store/nqb5r8axdf6cnpldyv8ncd57ydm4mz18-boringssl-0.20260803.0-dev (x86_64-darwin)+/nix/store/ilzac8c0icc8v48fzmmsjqam4rwsh7gp-boringssl-0.20260803.0-dev (x86_64-linux)
@aduh95aduh95
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 24, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 24, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76435/
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
15dac8c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
9e92114
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95
aduh95
commented
Aug 25, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Landed in ffe1e7c...137ff67
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
62d3602
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95aduh95
closed this
Aug 25, 2026
@panva
panva
deleted the

backport-65423-26.x

branch
August 25, 2026 22:19
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
17d2b06
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
0e87576
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
137ff67
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@codebyterecodebytere
mentioned this pull request
Aug 26, 2026

Closed

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
a9bd780
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
8029383
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@aduh95@pimterry

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs - #65483
Closed
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Closed
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs#65483
panva wants to merge 3 commits into
nodejs:v26.x-stagingfrom 
panva:backport-65423-26.x
Conversation
@panva
@panvapanva
commented
Aug 22, 2026

Copy link


Copy Markdown

Member
Backports #65423 to v26.x, this is a clean backport with one caveat, it overrides the boringssl version used by test-shared.yml to match that on main at the time #65423 landed.
@panva
panva
requested a review
from aduh95August 22, 2026 11:53
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
v26.x
Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.
labels
Aug 22, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 22, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.22%. Comparing base (ca26282) to head (bc52379).
⚠️ Report is 1 commits behind head on v26.x-staging.
Additional details and impacted files
@@ Coverage Diff @@## v26.x-staging #65483 +/- ##
=================================================
- Coverage 90.24% 90.22% -0.02% 
=================================================
Files 729 729 Lines 242760 242760 Branches 46044 46050 +6 =================================================
- Hits 219073 219041 -32 - Misses 15133 15144 +11 - Partials 8554 8575 +21 
Files with missing linesCoverage Δ
src/crypto/crypto_dh.cc65.66% <ø> (ø)
src/crypto/crypto_rsa.cc64.21% <ø> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
tools: update BoringSSL pin on v26.x
abb03e6
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
crypto: remove obsolete BoringSSL shims
6c87d4f
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
crypto: use available BoringSSL APIs
bc52379
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65423
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
panvaforce-pushed
the
backport-65423-26.x
branch
from
b7ceb4e to
bc52379CompareAugust 23, 2026 15:09
@github-actions
github-actionsBot
commented
Aug 23, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux459 -> 459 => no changes3 / 459 = 0.6%
aarch64-linux460 -> 460 => no changes3 / 460 = 0.6%
x86_64-darwin397 -> 397 => no changes3 / 397 = 0.7%
aarch64-darwin399 -> 399 => no changes3 / 399 = 0.7%
Total1715 -> 1715 => no changes12 / 1715 = 0.6%
Changelog
@@ -87,12 +87,12 @@-/nix/store/1k5vfgzqyn72h74v6ha9fihh7qbjrik0-boringssl-0.20260413.0 (aarch64-darwin)-/nix/store/k7hvxfz5mi1jcnzvfgmadpj61vcc2w0k-boringssl-0.20260413.0 (aarch64-linux)-/nix/store/pxmk721zyiw3n872vqiiz5cb05skmb34-boringssl-0.20260413.0 (x86_64-darwin)-/nix/store/n9g5v0naw03kxri26nm4zj0q85ypa3f6-boringssl-0.20260413.0 (x86_64-linux)-/nix/store/khfg0xszkmhb10fk7ghkx23b76nb1n8i-boringssl-0.20260413.0-bin (aarch64-darwin)-/nix/store/f6qciy5r9706hxd78wajsn92k27wnrq4-boringssl-0.20260413.0-bin (aarch64-linux)-/nix/store/jiz39z5bafzhy9qzq5d6gndi320p6gli-boringssl-0.20260413.0-bin (x86_64-darwin)-/nix/store/rs4yhnrd1v39wjnll2ahdpx9cda3nakn-boringssl-0.20260413.0-bin (x86_64-linux)-/nix/store/sfm292hxsmcbb49r35ww86wnhdp8x6vm-boringssl-0.20260413.0-dev (aarch64-darwin)-/nix/store/i6ccv7jpy8gb35nnhaj0cdv8blkg1w4r-boringssl-0.20260413.0-dev (aarch64-linux)-/nix/store/bzacx7cjjp1is1xh770bjid1ap15h66p-boringssl-0.20260413.0-dev (x86_64-darwin)-/nix/store/2b288h3ihsdmm24lmz5wbjx89ib8jd6v-boringssl-0.20260413.0-dev (x86_64-linux)+/nix/store/h0nnbhvw042c05840krknzp2gfnyan3n-boringssl-0.20260803.0 (aarch64-darwin)+/nix/store/22rfr95xasl2rqqr0aiimqkd074nrgvp-boringssl-0.20260803.0 (aarch64-linux)+/nix/store/lyjrr5k51c80cj8dgdhr6zgkbp4nmd7i-boringssl-0.20260803.0 (x86_64-darwin)+/nix/store/zpda1sh11x0l9zf2jqyj6j33gk650wdy-boringssl-0.20260803.0 (x86_64-linux)+/nix/store/kjvgsigj0lh1zc7lnyh93hqlv433z8pg-boringssl-0.20260803.0-bin (aarch64-darwin)+/nix/store/f105al617fdlhhjm02919xj22dgyn552-boringssl-0.20260803.0-bin (aarch64-linux)+/nix/store/s0zf1zkbjqgfpkfin8f1j3b0l6xrii90-boringssl-0.20260803.0-bin (x86_64-darwin)+/nix/store/x3b5va756lzjpgkxvfkvfx23066hnmk2-boringssl-0.20260803.0-bin (x86_64-linux)+/nix/store/i78kyxhs512a5d96si4lx5zvm76gq363-boringssl-0.20260803.0-dev (aarch64-darwin)+/nix/store/6zz04nbxwxlz2m04lb1vk1xa79i1rz70-boringssl-0.20260803.0-dev (aarch64-linux)+/nix/store/nqb5r8axdf6cnpldyv8ncd57ydm4mz18-boringssl-0.20260803.0-dev (x86_64-darwin)+/nix/store/ilzac8c0icc8v48fzmmsjqam4rwsh7gp-boringssl-0.20260803.0-dev (x86_64-linux)
@aduh95aduh95
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 24, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 24, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 25, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76435/
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
15dac8c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
9e92114
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95
aduh95
commented
Aug 25, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Landed in ffe1e7c...137ff67
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
62d3602
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95aduh95
closed this
Aug 25, 2026
@panva
panva
deleted the

backport-65423-26.x

branch
August 25, 2026 22:19
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: update BoringSSL pin on v26.x
17d2b06
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
0e87576
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
137ff67
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@codebyterecodebytere
mentioned this pull request
Aug 26, 2026

Closed

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: remove obsolete BoringSSL shims
a9bd780
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.
Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@panva@aduh95
crypto: use available BoringSSL APIs
8029383
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.
Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65423
Backport-PR-URL: #65483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@aduh95@pimterry