meta: add a root-level AGENTS.md - #65493

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md
Closed

meta: add a root-level AGENTS.md#65493
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md

Conversation

@jasnell

Copy link
Copy Markdown
Member

We're seeing a number of repeated mistakes in AI-generated contributions, including agents using Signed-off-by, creating what appear to be unsupervised PRs, appearing to respond to comments without human oversight, etc. Having an AGENTS.md file with specific instructions to the agent on what to avoid should help.

@jasnell
jasnell requested a review from a teamAugust 22, 2026 23:03
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. labels Aug 22, 2026
Comment threadAGENTS.md Outdated
@jasnelljasnell added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 22, 2026
@jasnelljasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2026
@legendecas

Copy link
Copy Markdown
Member

There is an ealier PR for AGENTS.md: #65463

Comment threadAGENTS.md Outdated
MikeMcC399

This comment was marked as resolved.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md
Comment threadAGENTS.md Outdated
@joyeecheung

joyeecheung commented Aug 23, 2026

Copy link
Copy Markdown
Member

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Comment threadAGENTS.md Outdated
@jasnell
jasnell requested a review from mcollinaAugust 23, 2026 20:35
@jasnell

Copy link
Copy Markdown
MemberAuthor

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Agents are perfectly capable of correctly interpretting it as written.

image

@aduh95

This comment was marked as resolved.

@jasnell

Copy link
Copy Markdown
MemberAuthor

Applied formatting.

We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

@mcollina are you satisfied with the updates enough to clear your "request changes"?

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
jasnelland others added 2 commits August 24, 2026 07:10
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs

Copy link
Copy Markdown
Member

It might be worth adding some instructions relating to scanning for vulnerabilities and drafting security reports too, but that could be a follow-up so not to derail this landing.

@codecov

codecovBot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (46a7dbd) to head (30617f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65493 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05% 
==========================================
Files 751 751 Lines 253550 253550 Branches 47813 47764 -49 ==========================================
- Hits 228733 228615 -118 - Misses 16076 16194 +118 
Partials 8741 8741 

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnelljasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queuePRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65493
✔ Done loading data for nodejs/node/pull/65493
----------------------------------- PR info ------------------------------------
Title meta: add a root-level AGENTS.md (#65493)
Author James M Snell <jasnell@gmail.com> (@jasnell)
Branch jasnell:jasnell/agents-md -> nodejs:main
Labels doc, meta, author ready, commit-queue, commit-queue-squash
Commits 3
- meta: add a root-level AGENTS.md
- Update AGENTS.md
- Update AGENTS.md
Committers 2
- James M Snell <jasnell@gmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 22 Aug 2026 23:03:55 GMT
✔ Approvals: 11
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001236054
✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001242994
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001243926
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001264045
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001498760
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001953590
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002129158
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002473048
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5014119398
✔ - Mike McCready (@MikeMcC399): https://github.com/nodejs/node/pull/65493#pullrequestreview-5008407743
✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/65493#pullrequestreview-5009576874
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

jasnell added a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 0c31886

@jasnelljasnell closed this Aug 25, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

18 participants

@jasnell@legendecas@joyeecheung@aduh95@BethGriggs@nodejs-github-bot@mcollina@panva@bmuenzenmeyer@benjamingr@anonrig@ronag@daeyeon@MoLow@trivikr@avivkeller@MikeMcC399@atlowChemi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

meta: add a root-level AGENTS.md - #65493

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md
Closed

meta: add a root-level AGENTS.md#65493
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md

Conversation

@jasnell

Copy link
Copy Markdown
Member

We're seeing a number of repeated mistakes in AI-generated contributions, including agents using Signed-off-by, creating what appear to be unsupervised PRs, appearing to respond to comments without human oversight, etc. Having an AGENTS.md file with specific instructions to the agent on what to avoid should help.

@jasnell
jasnell requested a review from a teamAugust 22, 2026 23:03
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. labels Aug 22, 2026
Comment threadAGENTS.md Outdated
@jasnelljasnell added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 22, 2026
@jasnelljasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2026
@legendecas

Copy link
Copy Markdown
Member

There is an ealier PR for AGENTS.md: #65463

Comment threadAGENTS.md Outdated
MikeMcC399

This comment was marked as resolved.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md
Comment threadAGENTS.md Outdated
@joyeecheung

joyeecheung commented Aug 23, 2026

Copy link
Copy Markdown
Member

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Comment threadAGENTS.md Outdated
@jasnell
jasnell requested a review from mcollinaAugust 23, 2026 20:35
@jasnell

Copy link
Copy Markdown
MemberAuthor

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Agents are perfectly capable of correctly interpretting it as written.

image

@aduh95

This comment was marked as resolved.

@jasnell

Copy link
Copy Markdown
MemberAuthor

Applied formatting.

We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

@mcollina are you satisfied with the updates enough to clear your "request changes"?

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
jasnelland others added 2 commits August 24, 2026 07:10
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs

Copy link
Copy Markdown
Member

It might be worth adding some instructions relating to scanning for vulnerabilities and drafting security reports too, but that could be a follow-up so not to derail this landing.

@codecov

codecovBot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (46a7dbd) to head (30617f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65493 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05% 
==========================================
Files 751 751 Lines 253550 253550 Branches 47813 47764 -49 ==========================================
- Hits 228733 228615 -118 - Misses 16076 16194 +118 
Partials 8741 8741 

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnelljasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queuePRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65493
✔ Done loading data for nodejs/node/pull/65493
----------------------------------- PR info ------------------------------------
Title meta: add a root-level AGENTS.md (#65493)
Author James M Snell <jasnell@gmail.com> (@jasnell)
Branch jasnell:jasnell/agents-md -> nodejs:main
Labels doc, meta, author ready, commit-queue, commit-queue-squash
Commits 3
- meta: add a root-level AGENTS.md
- Update AGENTS.md
- Update AGENTS.md
Committers 2
- James M Snell <jasnell@gmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 22 Aug 2026 23:03:55 GMT
✔ Approvals: 11
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001236054
✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001242994
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001243926
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001264045
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001498760
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001953590
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002129158
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002473048
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5014119398
✔ - Mike McCready (@MikeMcC399): https://github.com/nodejs/node/pull/65493#pullrequestreview-5008407743
✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/65493#pullrequestreview-5009576874
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

jasnell added a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 0c31886

@jasnelljasnell closed this Aug 25, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

18 participants

@jasnell@legendecas@joyeecheung@aduh95@BethGriggs@nodejs-github-bot@mcollina@panva@bmuenzenmeyer@benjamingr@anonrig@ronag@daeyeon@MoLow@trivikr@avivkeller@MikeMcC399@atlowChemi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

meta: add a root-level AGENTS.md - #65493

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md
Closed

meta: add a root-level AGENTS.md#65493
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md

Conversation

@jasnell

Copy link
Copy Markdown
Member

We're seeing a number of repeated mistakes in AI-generated contributions, including agents using Signed-off-by, creating what appear to be unsupervised PRs, appearing to respond to comments without human oversight, etc. Having an AGENTS.md file with specific instructions to the agent on what to avoid should help.

@jasnell
jasnell requested a review from a teamAugust 22, 2026 23:03
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. labels Aug 22, 2026
Comment threadAGENTS.md Outdated
@jasnelljasnell added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 22, 2026
@jasnelljasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2026
@legendecas

Copy link
Copy Markdown
Member

There is an ealier PR for AGENTS.md: #65463

Comment threadAGENTS.md Outdated
MikeMcC399

This comment was marked as resolved.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md
Comment threadAGENTS.md Outdated
@joyeecheung

joyeecheung commented Aug 23, 2026

Copy link
Copy Markdown
Member

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Comment threadAGENTS.md Outdated
@jasnell
jasnell requested a review from mcollinaAugust 23, 2026 20:35
@jasnell

Copy link
Copy Markdown
MemberAuthor

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Agents are perfectly capable of correctly interpretting it as written.

image

@aduh95

This comment was marked as resolved.

@jasnell

Copy link
Copy Markdown
MemberAuthor

Applied formatting.

We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

@mcollina are you satisfied with the updates enough to clear your "request changes"?

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
jasnelland others added 2 commits August 24, 2026 07:10
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs

Copy link
Copy Markdown
Member

It might be worth adding some instructions relating to scanning for vulnerabilities and drafting security reports too, but that could be a follow-up so not to derail this landing.

@codecov

codecovBot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (46a7dbd) to head (30617f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65493 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05% 
==========================================
Files 751 751 Lines 253550 253550 Branches 47813 47764 -49 ==========================================
- Hits 228733 228615 -118 - Misses 16076 16194 +118 
Partials 8741 8741 

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnelljasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queuePRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65493
✔ Done loading data for nodejs/node/pull/65493
----------------------------------- PR info ------------------------------------
Title meta: add a root-level AGENTS.md (#65493)
Author James M Snell <jasnell@gmail.com> (@jasnell)
Branch jasnell:jasnell/agents-md -> nodejs:main
Labels doc, meta, author ready, commit-queue, commit-queue-squash
Commits 3
- meta: add a root-level AGENTS.md
- Update AGENTS.md
- Update AGENTS.md
Committers 2
- James M Snell <jasnell@gmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 22 Aug 2026 23:03:55 GMT
✔ Approvals: 11
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001236054
✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001242994
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001243926
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001264045
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001498760
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001953590
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002129158
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002473048
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5014119398
✔ - Mike McCready (@MikeMcC399): https://github.com/nodejs/node/pull/65493#pullrequestreview-5008407743
✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/65493#pullrequestreview-5009576874
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

jasnell added a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 0c31886

@jasnelljasnell closed this Aug 25, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

18 participants

@jasnell@legendecas@joyeecheung@aduh95@BethGriggs@nodejs-github-bot@mcollina@panva@bmuenzenmeyer@benjamingr@anonrig@ronag@daeyeon@MoLow@trivikr@avivkeller@MikeMcC399@atlowChemi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

meta: add a root-level AGENTS.md - #65493

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md
Closed

meta: add a root-level AGENTS.md#65493
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md

Conversation

@jasnell

Copy link
Copy Markdown
Member

We're seeing a number of repeated mistakes in AI-generated contributions, including agents using Signed-off-by, creating what appear to be unsupervised PRs, appearing to respond to comments without human oversight, etc. Having an AGENTS.md file with specific instructions to the agent on what to avoid should help.

@jasnell
jasnell requested a review from a teamAugust 22, 2026 23:03
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. labels Aug 22, 2026
Comment threadAGENTS.md Outdated
@jasnelljasnell added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 22, 2026
@jasnelljasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2026
@legendecas

Copy link
Copy Markdown
Member

There is an ealier PR for AGENTS.md: #65463

Comment threadAGENTS.md Outdated
MikeMcC399

This comment was marked as resolved.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md
Comment threadAGENTS.md Outdated
@joyeecheung

joyeecheung commented Aug 23, 2026

Copy link
Copy Markdown
Member

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Comment threadAGENTS.md Outdated
@jasnell
jasnell requested a review from mcollinaAugust 23, 2026 20:35
@jasnell

Copy link
Copy Markdown
MemberAuthor

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Agents are perfectly capable of correctly interpretting it as written.

image

@aduh95

This comment was marked as resolved.

@jasnell

Copy link
Copy Markdown
MemberAuthor

Applied formatting.

We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

@mcollina are you satisfied with the updates enough to clear your "request changes"?

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
jasnelland others added 2 commits August 24, 2026 07:10
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs

Copy link
Copy Markdown
Member

It might be worth adding some instructions relating to scanning for vulnerabilities and drafting security reports too, but that could be a follow-up so not to derail this landing.

@codecov

codecovBot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (46a7dbd) to head (30617f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65493 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05% 
==========================================
Files 751 751 Lines 253550 253550 Branches 47813 47764 -49 ==========================================
- Hits 228733 228615 -118 - Misses 16076 16194 +118 
Partials 8741 8741 

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnelljasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queuePRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65493
✔ Done loading data for nodejs/node/pull/65493
----------------------------------- PR info ------------------------------------
Title meta: add a root-level AGENTS.md (#65493)
Author James M Snell <jasnell@gmail.com> (@jasnell)
Branch jasnell:jasnell/agents-md -> nodejs:main
Labels doc, meta, author ready, commit-queue, commit-queue-squash
Commits 3
- meta: add a root-level AGENTS.md
- Update AGENTS.md
- Update AGENTS.md
Committers 2
- James M Snell <jasnell@gmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 22 Aug 2026 23:03:55 GMT
✔ Approvals: 11
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001236054
✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001242994
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001243926
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001264045
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001498760
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001953590
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002129158
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002473048
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5014119398
✔ - Mike McCready (@MikeMcC399): https://github.com/nodejs/node/pull/65493#pullrequestreview-5008407743
✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/65493#pullrequestreview-5009576874
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

jasnell added a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 0c31886

@jasnelljasnell closed this Aug 25, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

18 participants

@jasnell@legendecas@joyeecheung@aduh95@BethGriggs@nodejs-github-bot@mcollina@panva@bmuenzenmeyer@benjamingr@anonrig@ronag@daeyeon@MoLow@trivikr@avivkeller@MikeMcC399@atlowChemi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

meta: add a root-level AGENTS.md - #65493

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md
Closed

meta: add a root-level AGENTS.md#65493
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md

Conversation

@jasnell

Copy link
Copy Markdown
Member

We're seeing a number of repeated mistakes in AI-generated contributions, including agents using Signed-off-by, creating what appear to be unsupervised PRs, appearing to respond to comments without human oversight, etc. Having an AGENTS.md file with specific instructions to the agent on what to avoid should help.

@jasnell
jasnell requested a review from a teamAugust 22, 2026 23:03
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. labels Aug 22, 2026
Comment threadAGENTS.md Outdated
@jasnelljasnell added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 22, 2026
@jasnelljasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2026
@legendecas

Copy link
Copy Markdown
Member

There is an ealier PR for AGENTS.md: #65463

Comment threadAGENTS.md Outdated
MikeMcC399

This comment was marked as resolved.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md
Comment threadAGENTS.md Outdated
@joyeecheung

joyeecheung commented Aug 23, 2026

Copy link
Copy Markdown
Member

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Comment threadAGENTS.md Outdated
@jasnell
jasnell requested a review from mcollinaAugust 23, 2026 20:35
@jasnell

Copy link
Copy Markdown
MemberAuthor

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Agents are perfectly capable of correctly interpretting it as written.

image

@aduh95

This comment was marked as resolved.

@jasnell

Copy link
Copy Markdown
MemberAuthor

Applied formatting.

We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

@mcollina are you satisfied with the updates enough to clear your "request changes"?

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
jasnelland others added 2 commits August 24, 2026 07:10
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs

Copy link
Copy Markdown
Member

It might be worth adding some instructions relating to scanning for vulnerabilities and drafting security reports too, but that could be a follow-up so not to derail this landing.

@codecov

codecovBot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (46a7dbd) to head (30617f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65493 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05% 
==========================================
Files 751 751 Lines 253550 253550 Branches 47813 47764 -49 ==========================================
- Hits 228733 228615 -118 - Misses 16076 16194 +118 
Partials 8741 8741 

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnelljasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queuePRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65493
✔ Done loading data for nodejs/node/pull/65493
----------------------------------- PR info ------------------------------------
Title meta: add a root-level AGENTS.md (#65493)
Author James M Snell <jasnell@gmail.com> (@jasnell)
Branch jasnell:jasnell/agents-md -> nodejs:main
Labels doc, meta, author ready, commit-queue, commit-queue-squash
Commits 3
- meta: add a root-level AGENTS.md
- Update AGENTS.md
- Update AGENTS.md
Committers 2
- James M Snell <jasnell@gmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 22 Aug 2026 23:03:55 GMT
✔ Approvals: 11
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001236054
✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001242994
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001243926
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001264045
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001498760
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001953590
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002129158
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002473048
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5014119398
✔ - Mike McCready (@MikeMcC399): https://github.com/nodejs/node/pull/65493#pullrequestreview-5008407743
✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/65493#pullrequestreview-5009576874
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

jasnell added a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 0c31886

@jasnelljasnell closed this Aug 25, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

18 participants

@jasnell@legendecas@joyeecheung@aduh95@BethGriggs@nodejs-github-bot@mcollina@panva@bmuenzenmeyer@benjamingr@anonrig@ronag@daeyeon@MoLow@trivikr@avivkeller@MikeMcC399@atlowChemi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

meta: add a root-level AGENTS.md - #65493

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md
Closed

meta: add a root-level AGENTS.md#65493
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md

Conversation

@jasnell

Copy link
Copy Markdown
Member

We're seeing a number of repeated mistakes in AI-generated contributions, including agents using Signed-off-by, creating what appear to be unsupervised PRs, appearing to respond to comments without human oversight, etc. Having an AGENTS.md file with specific instructions to the agent on what to avoid should help.

@jasnell
jasnell requested a review from a teamAugust 22, 2026 23:03
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. labels Aug 22, 2026
Comment threadAGENTS.md Outdated
@jasnelljasnell added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 22, 2026
@jasnelljasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2026
@legendecas

Copy link
Copy Markdown
Member

There is an ealier PR for AGENTS.md: #65463

Comment threadAGENTS.md Outdated
MikeMcC399

This comment was marked as resolved.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md
Comment threadAGENTS.md Outdated
@joyeecheung

joyeecheung commented Aug 23, 2026

Copy link
Copy Markdown
Member

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Comment threadAGENTS.md Outdated
@jasnell
jasnell requested a review from mcollinaAugust 23, 2026 20:35
@jasnell

Copy link
Copy Markdown
MemberAuthor

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Agents are perfectly capable of correctly interpretting it as written.

image

@aduh95

This comment was marked as resolved.

@jasnell

Copy link
Copy Markdown
MemberAuthor

Applied formatting.

We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

@mcollina are you satisfied with the updates enough to clear your "request changes"?

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
jasnelland others added 2 commits August 24, 2026 07:10
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs

Copy link
Copy Markdown
Member

It might be worth adding some instructions relating to scanning for vulnerabilities and drafting security reports too, but that could be a follow-up so not to derail this landing.

@codecov

codecovBot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (46a7dbd) to head (30617f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65493 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05% 
==========================================
Files 751 751 Lines 253550 253550 Branches 47813 47764 -49 ==========================================
- Hits 228733 228615 -118 - Misses 16076 16194 +118 
Partials 8741 8741 

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnelljasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queuePRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65493
✔ Done loading data for nodejs/node/pull/65493
----------------------------------- PR info ------------------------------------
Title meta: add a root-level AGENTS.md (#65493)
Author James M Snell <jasnell@gmail.com> (@jasnell)
Branch jasnell:jasnell/agents-md -> nodejs:main
Labels doc, meta, author ready, commit-queue, commit-queue-squash
Commits 3
- meta: add a root-level AGENTS.md
- Update AGENTS.md
- Update AGENTS.md
Committers 2
- James M Snell <jasnell@gmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 22 Aug 2026 23:03:55 GMT
✔ Approvals: 11
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001236054
✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001242994
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001243926
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001264045
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001498760
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001953590
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002129158
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002473048
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5014119398
✔ - Mike McCready (@MikeMcC399): https://github.com/nodejs/node/pull/65493#pullrequestreview-5008407743
✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/65493#pullrequestreview-5009576874
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

jasnell added a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 0c31886

@jasnelljasnell closed this Aug 25, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

18 participants

@jasnell@legendecas@joyeecheung@aduh95@BethGriggs@nodejs-github-bot@mcollina@panva@bmuenzenmeyer@benjamingr@anonrig@ronag@daeyeon@MoLow@trivikr@avivkeller@MikeMcC399@atlowChemi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

meta: add a root-level AGENTS.md - #65493

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md
Closed

meta: add a root-level AGENTS.md#65493
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md

Conversation

@jasnell

Copy link
Copy Markdown
Member

We're seeing a number of repeated mistakes in AI-generated contributions, including agents using Signed-off-by, creating what appear to be unsupervised PRs, appearing to respond to comments without human oversight, etc. Having an AGENTS.md file with specific instructions to the agent on what to avoid should help.

@jasnell
jasnell requested a review from a teamAugust 22, 2026 23:03
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. labels Aug 22, 2026
Comment threadAGENTS.md Outdated
@jasnelljasnell added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 22, 2026
@jasnelljasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2026
@legendecas

Copy link
Copy Markdown
Member

There is an ealier PR for AGENTS.md: #65463

Comment threadAGENTS.md Outdated
MikeMcC399

This comment was marked as resolved.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md
Comment threadAGENTS.md Outdated
@joyeecheung

joyeecheung commented Aug 23, 2026

Copy link
Copy Markdown
Member

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Comment threadAGENTS.md Outdated
@jasnell
jasnell requested a review from mcollinaAugust 23, 2026 20:35
@jasnell

Copy link
Copy Markdown
MemberAuthor

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Agents are perfectly capable of correctly interpretting it as written.

image

@aduh95

This comment was marked as resolved.

@jasnell

Copy link
Copy Markdown
MemberAuthor

Applied formatting.

We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

@mcollina are you satisfied with the updates enough to clear your "request changes"?

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
jasnelland others added 2 commits August 24, 2026 07:10
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs

Copy link
Copy Markdown
Member

It might be worth adding some instructions relating to scanning for vulnerabilities and drafting security reports too, but that could be a follow-up so not to derail this landing.

@codecov

codecovBot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (46a7dbd) to head (30617f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65493 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05% 
==========================================
Files 751 751 Lines 253550 253550 Branches 47813 47764 -49 ==========================================
- Hits 228733 228615 -118 - Misses 16076 16194 +118 
Partials 8741 8741 

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnelljasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queuePRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65493
✔ Done loading data for nodejs/node/pull/65493
----------------------------------- PR info ------------------------------------
Title meta: add a root-level AGENTS.md (#65493)
Author James M Snell <jasnell@gmail.com> (@jasnell)
Branch jasnell:jasnell/agents-md -> nodejs:main
Labels doc, meta, author ready, commit-queue, commit-queue-squash
Commits 3
- meta: add a root-level AGENTS.md
- Update AGENTS.md
- Update AGENTS.md
Committers 2
- James M Snell <jasnell@gmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 22 Aug 2026 23:03:55 GMT
✔ Approvals: 11
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001236054
✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001242994
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001243926
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001264045
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001498760
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001953590
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002129158
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002473048
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5014119398
✔ - Mike McCready (@MikeMcC399): https://github.com/nodejs/node/pull/65493#pullrequestreview-5008407743
✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/65493#pullrequestreview-5009576874
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

jasnell added a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 0c31886

@jasnelljasnell closed this Aug 25, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

18 participants

@jasnell@legendecas@joyeecheung@aduh95@BethGriggs@nodejs-github-bot@mcollina@panva@bmuenzenmeyer@benjamingr@anonrig@ronag@daeyeon@MoLow@trivikr@avivkeller@MikeMcC399@atlowChemi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

meta: add a root-level AGENTS.md - #65493

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md
Closed

meta: add a root-level AGENTS.md#65493
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/agents-md

Conversation

@jasnell

Copy link
Copy Markdown
Member

We're seeing a number of repeated mistakes in AI-generated contributions, including agents using Signed-off-by, creating what appear to be unsupervised PRs, appearing to respond to comments without human oversight, etc. Having an AGENTS.md file with specific instructions to the agent on what to avoid should help.

@jasnell
jasnell requested a review from a teamAugust 22, 2026 23:03
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. labels Aug 22, 2026
Comment threadAGENTS.md Outdated
@jasnelljasnell added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 22, 2026
@jasnelljasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2026
@legendecas

Copy link
Copy Markdown
Member

There is an ealier PR for AGENTS.md: #65463

Comment threadAGENTS.md Outdated
MikeMcC399

This comment was marked as resolved.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md
Comment threadAGENTS.md Outdated
@joyeecheung

joyeecheung commented Aug 23, 2026

Copy link
Copy Markdown
Member

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Comment threadAGENTS.md Outdated
@jasnell
jasnell requested a review from mcollinaAugust 23, 2026 20:35
@jasnell

Copy link
Copy Markdown
MemberAuthor

The document uses a tone as if it's speaking to a human, even though it is not supposed to be read by human? e.g. the distinction of collaborators or non-collaborators is pointless to an agent unless you give it permisssions where the distinction makes a difference, but then the document goes on saying the agent shouldn't use any of these permissions, which means the agent is not supposed to make use of that distinction in the first place.

Agents are perfectly capable of correctly interpretting it as written.

image

@aduh95

This comment was marked as resolved.

@jasnell

Copy link
Copy Markdown
MemberAuthor

Applied formatting.

We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

@mcollina are you satisfied with the updates enough to clear your "request changes"?

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
jasnelland others added 2 commits August 24, 2026 07:10
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs

Copy link
Copy Markdown
Member

It might be worth adding some instructions relating to scanning for vulnerabilities and drafting security reports too, but that could be a follow-up so not to derail this landing.

@codecov

codecovBot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (46a7dbd) to head (30617f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65493 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05% 
==========================================
Files 751 751 Lines 253550 253550 Branches 47813 47764 -49 ==========================================
- Hits 228733 228615 -118 - Misses 16076 16194 +118 
Partials 8741 8741 

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnelljasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queuePRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65493
✔ Done loading data for nodejs/node/pull/65493
----------------------------------- PR info ------------------------------------
Title meta: add a root-level AGENTS.md (#65493)
Author James M Snell <jasnell@gmail.com> (@jasnell)
Branch jasnell:jasnell/agents-md -> nodejs:main
Labels doc, meta, author ready, commit-queue, commit-queue-squash
Commits 3
- meta: add a root-level AGENTS.md
- Update AGENTS.md
- Update AGENTS.md
Committers 2
- James M Snell <jasnell@gmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 22 Aug 2026 23:03:55 GMT
✔ Approvals: 11
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001236054
✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001242994
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001243926
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001264045
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001498760
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/65493#pullrequestreview-5001953590
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002129158
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65493#pullrequestreview-5002473048
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65493#pullrequestreview-5014119398
✔ - Mike McCready (@MikeMcC399): https://github.com/nodejs/node/pull/65493#pullrequestreview-5008407743
✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/65493#pullrequestreview-5009576874
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

jasnell added a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 0c31886

@jasnelljasnell closed this Aug 25, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
We're seeing a number of repeated mistakes in AI-generated
contributions, including agents using `Signed-off-by`, creating
what appear to be unsupervised PRs, appearing to respond to
comments without human oversight, etc. Having an AGENTS.md
file with specific instructions to the agent on what to avoid
should help.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65493
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.docIssues and PRs related to Node.js documentation.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

18 participants

@jasnell@legendecas@joyeecheung@aduh95@BethGriggs@nodejs-github-bot@mcollina@panva@bmuenzenmeyer@benjamingr@anonrig@ronag@daeyeon@MoLow@trivikr@avivkeller@MikeMcC399@atlowChemi