stream: reject primitive values in ReadableStream.from by standard-Chan · Pull Request #65676 · nodejs/node

standard-Chan · 2026-08-31T09:12:02Z

This updates ReadableStream.from() to reject primitive values before looking up iterator methods.

WHATWG Streams changed ReadableStream.from() to use the Web IDL async_sequence<T> type (added in whatwg#1372)

That makes string inputs invalid because Web IDL sequence conversion requires non-object values to throw a TypeError:
spec es-sequence

If V is not an Object, throw a TypeError.

WPT added coverage for this behavior here: web-platform-tests/wpt#59594

This change aligns Node.js with that WPT expectation and removes the corresponding expected failure for test (ReadableStream.from throws on invalid iterables; specifically a string)

Tests:

$ node test/wpt/test-streams.js readable-streams/from.any.js
Files: 2/2 ran, 2 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes
Subtests: 100 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes

$ tools/test.py wpt/test-streams
[00:05|% 100|+ 1|- 0]: Done
All tests passed.

nodejs-github-bot · 2026-08-31T09:12:08Z

Review requested:

@nodejs/web-standards

Reject non-object inputs before looking up iterator methods in ReadableStream.from(). This matches the Web IDL async sequence conversion and prevents primitive strings from being accepted through property-access boxing. This fixes the WPT test: "ReadableStream.from throws on invalid iterables; specifically a string" Refs: https://webidl.spec.whatwg.org/#es-sequence Signed-off-by: Jeong SeokChan <starp321@naver.com>

MattiasBuelens · 2026-08-31T09:26:52Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

standard-Chan · 2026-08-31T09:31:12Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥
This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

Thanks for letting me know. I missed them.

I'll close this PR. Thanks for reviewing it!

codecov · 2026-08-31T11:03:29Z

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (4605cf5) to head (d41a8e0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65676 +/- ##
==========================================
+ Coverage 90.06% 90.11% +0.05% 
==========================================
Files 754 754 Lines 255759 256313 +554 Branches 48327 48515 +188 ==========================================
+ Hits 230350 230988 +638 + Misses 16534 16450 -84 
Partials 8875 8875

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	`90.58% <40.00%> (+3.25%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

standard-Chan · 2026-08-31T09:12:02Z

This updates ReadableStream.from() to reject primitive values before looking up iterator methods.

WHATWG Streams changed ReadableStream.from() to use the Web IDL async_sequence<T> type (added in whatwg#1372)

That makes string inputs invalid because Web IDL sequence conversion requires non-object values to throw a TypeError:
spec es-sequence

If V is not an Object, throw a TypeError.

WPT added coverage for this behavior here: web-platform-tests/wpt#59594

This change aligns Node.js with that WPT expectation and removes the corresponding expected failure for test (ReadableStream.from throws on invalid iterables; specifically a string)

Tests:

$ node test/wpt/test-streams.js readable-streams/from.any.js
Files: 2/2 ran, 2 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes
Subtests: 100 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes

$ tools/test.py wpt/test-streams
[00:05|% 100|+ 1|- 0]: Done
All tests passed.

nodejs-github-bot · 2026-08-31T09:12:08Z

Review requested:

@nodejs/web-standards

Reject non-object inputs before looking up iterator methods in ReadableStream.from(). This matches the Web IDL async sequence conversion and prevents primitive strings from being accepted through property-access boxing. This fixes the WPT test: "ReadableStream.from throws on invalid iterables; specifically a string" Refs: https://webidl.spec.whatwg.org/#es-sequence Signed-off-by: Jeong SeokChan <starp321@naver.com>

MattiasBuelens · 2026-08-31T09:26:52Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

standard-Chan · 2026-08-31T09:31:12Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥
This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

Thanks for letting me know. I missed them.

I'll close this PR. Thanks for reviewing it!

codecov · 2026-08-31T11:03:29Z

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (4605cf5) to head (d41a8e0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65676 +/- ##
==========================================
+ Coverage 90.06% 90.11% +0.05% 
==========================================
Files 754 754 Lines 255759 256313 +554 Branches 48327 48515 +188 ==========================================
+ Hits 230350 230988 +638 + Misses 16534 16450 -84 
Partials 8875 8875

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	`90.58% <40.00%> (+3.25%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

standard-Chan · 2026-08-31T09:12:02Z

This updates ReadableStream.from() to reject primitive values before looking up iterator methods.

WHATWG Streams changed ReadableStream.from() to use the Web IDL async_sequence<T> type (added in whatwg#1372)

That makes string inputs invalid because Web IDL sequence conversion requires non-object values to throw a TypeError:
spec es-sequence

If V is not an Object, throw a TypeError.

WPT added coverage for this behavior here: web-platform-tests/wpt#59594

This change aligns Node.js with that WPT expectation and removes the corresponding expected failure for test (ReadableStream.from throws on invalid iterables; specifically a string)

Tests:

$ node test/wpt/test-streams.js readable-streams/from.any.js
Files: 2/2 ran, 2 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes
Subtests: 100 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes

$ tools/test.py wpt/test-streams
[00:05|% 100|+ 1|- 0]: Done
All tests passed.

nodejs-github-bot · 2026-08-31T09:12:08Z

Review requested:

@nodejs/web-standards

Reject non-object inputs before looking up iterator methods in ReadableStream.from(). This matches the Web IDL async sequence conversion and prevents primitive strings from being accepted through property-access boxing. This fixes the WPT test: "ReadableStream.from throws on invalid iterables; specifically a string" Refs: https://webidl.spec.whatwg.org/#es-sequence Signed-off-by: Jeong SeokChan <starp321@naver.com>

MattiasBuelens · 2026-08-31T09:26:52Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

standard-Chan · 2026-08-31T09:31:12Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥
This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

Thanks for letting me know. I missed them.

I'll close this PR. Thanks for reviewing it!

codecov · 2026-08-31T11:03:29Z

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (4605cf5) to head (d41a8e0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65676 +/- ##
==========================================
+ Coverage 90.06% 90.11% +0.05% 
==========================================
Files 754 754 Lines 255759 256313 +554 Branches 48327 48515 +188 ==========================================
+ Hits 230350 230988 +638 + Misses 16534 16450 -84 
Partials 8875 8875

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	`90.58% <40.00%> (+3.25%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

standard-Chan · 2026-08-31T09:12:02Z

This updates ReadableStream.from() to reject primitive values before looking up iterator methods.

WHATWG Streams changed ReadableStream.from() to use the Web IDL async_sequence<T> type (added in whatwg#1372)

That makes string inputs invalid because Web IDL sequence conversion requires non-object values to throw a TypeError:
spec es-sequence

If V is not an Object, throw a TypeError.

WPT added coverage for this behavior here: web-platform-tests/wpt#59594

This change aligns Node.js with that WPT expectation and removes the corresponding expected failure for test (ReadableStream.from throws on invalid iterables; specifically a string)

Tests:

$ node test/wpt/test-streams.js readable-streams/from.any.js
Files: 2/2 ran, 2 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes
Subtests: 100 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes

$ tools/test.py wpt/test-streams
[00:05|% 100|+ 1|- 0]: Done
All tests passed.

nodejs-github-bot · 2026-08-31T09:12:08Z

Review requested:

@nodejs/web-standards

Reject non-object inputs before looking up iterator methods in ReadableStream.from(). This matches the Web IDL async sequence conversion and prevents primitive strings from being accepted through property-access boxing. This fixes the WPT test: "ReadableStream.from throws on invalid iterables; specifically a string" Refs: https://webidl.spec.whatwg.org/#es-sequence Signed-off-by: Jeong SeokChan <starp321@naver.com>

MattiasBuelens · 2026-08-31T09:26:52Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

standard-Chan · 2026-08-31T09:31:12Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥
This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

Thanks for letting me know. I missed them.

I'll close this PR. Thanks for reviewing it!

codecov · 2026-08-31T11:03:29Z

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (4605cf5) to head (d41a8e0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65676 +/- ##
==========================================
+ Coverage 90.06% 90.11% +0.05% 
==========================================
Files 754 754 Lines 255759 256313 +554 Branches 48327 48515 +188 ==========================================
+ Hits 230350 230988 +638 + Misses 16534 16450 -84 
Partials 8875 8875

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	`90.58% <40.00%> (+3.25%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

standard-Chan · 2026-08-31T09:12:02Z

This updates ReadableStream.from() to reject primitive values before looking up iterator methods.

WHATWG Streams changed ReadableStream.from() to use the Web IDL async_sequence<T> type (added in whatwg#1372)

That makes string inputs invalid because Web IDL sequence conversion requires non-object values to throw a TypeError:
spec es-sequence

If V is not an Object, throw a TypeError.

WPT added coverage for this behavior here: web-platform-tests/wpt#59594

This change aligns Node.js with that WPT expectation and removes the corresponding expected failure for test (ReadableStream.from throws on invalid iterables; specifically a string)

Tests:

$ node test/wpt/test-streams.js readable-streams/from.any.js
Files: 2/2 ran, 2 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes
Subtests: 100 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes

$ tools/test.py wpt/test-streams
[00:05|% 100|+ 1|- 0]: Done
All tests passed.

nodejs-github-bot · 2026-08-31T09:12:08Z

Review requested:

@nodejs/web-standards

Reject non-object inputs before looking up iterator methods in ReadableStream.from(). This matches the Web IDL async sequence conversion and prevents primitive strings from being accepted through property-access boxing. This fixes the WPT test: "ReadableStream.from throws on invalid iterables; specifically a string" Refs: https://webidl.spec.whatwg.org/#es-sequence Signed-off-by: Jeong SeokChan <starp321@naver.com>

MattiasBuelens · 2026-08-31T09:26:52Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

standard-Chan · 2026-08-31T09:31:12Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥
This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

Thanks for letting me know. I missed them.

I'll close this PR. Thanks for reviewing it!

codecov · 2026-08-31T11:03:29Z

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (4605cf5) to head (d41a8e0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65676 +/- ##
==========================================
+ Coverage 90.06% 90.11% +0.05% 
==========================================
Files 754 754 Lines 255759 256313 +554 Branches 48327 48515 +188 ==========================================
+ Hits 230350 230988 +638 + Misses 16534 16450 -84 
Partials 8875 8875

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	`90.58% <40.00%> (+3.25%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

standard-Chan · 2026-08-31T09:12:02Z

This updates ReadableStream.from() to reject primitive values before looking up iterator methods.

WHATWG Streams changed ReadableStream.from() to use the Web IDL async_sequence<T> type (added in whatwg#1372)

That makes string inputs invalid because Web IDL sequence conversion requires non-object values to throw a TypeError:
spec es-sequence

If V is not an Object, throw a TypeError.

WPT added coverage for this behavior here: web-platform-tests/wpt#59594

This change aligns Node.js with that WPT expectation and removes the corresponding expected failure for test (ReadableStream.from throws on invalid iterables; specifically a string)

Tests:

$ node test/wpt/test-streams.js readable-streams/from.any.js
Files: 2/2 ran, 2 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes
Subtests: 100 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes

$ tools/test.py wpt/test-streams
[00:05|% 100|+ 1|- 0]: Done
All tests passed.

nodejs-github-bot · 2026-08-31T09:12:08Z

Review requested:

@nodejs/web-standards

Reject non-object inputs before looking up iterator methods in ReadableStream.from(). This matches the Web IDL async sequence conversion and prevents primitive strings from being accepted through property-access boxing. This fixes the WPT test: "ReadableStream.from throws on invalid iterables; specifically a string" Refs: https://webidl.spec.whatwg.org/#es-sequence Signed-off-by: Jeong SeokChan <starp321@naver.com>

MattiasBuelens · 2026-08-31T09:26:52Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

standard-Chan · 2026-08-31T09:31:12Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥
This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

Thanks for letting me know. I missed them.

I'll close this PR. Thanks for reviewing it!

codecov · 2026-08-31T11:03:29Z

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (4605cf5) to head (d41a8e0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65676 +/- ##
==========================================
+ Coverage 90.06% 90.11% +0.05% 
==========================================
Files 754 754 Lines 255759 256313 +554 Branches 48327 48515 +188 ==========================================
+ Hits 230350 230988 +638 + Misses 16534 16450 -84 
Partials 8875 8875

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	`90.58% <40.00%> (+3.25%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

standard-Chan · 2026-08-31T09:12:02Z

This updates ReadableStream.from() to reject primitive values before looking up iterator methods.

WHATWG Streams changed ReadableStream.from() to use the Web IDL async_sequence<T> type (added in whatwg#1372)

That makes string inputs invalid because Web IDL sequence conversion requires non-object values to throw a TypeError:
spec es-sequence

If V is not an Object, throw a TypeError.

WPT added coverage for this behavior here: web-platform-tests/wpt#59594

This change aligns Node.js with that WPT expectation and removes the corresponding expected failure for test (ReadableStream.from throws on invalid iterables; specifically a string)

Tests:

$ node test/wpt/test-streams.js readable-streams/from.any.js
Files: 2/2 ran, 2 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes
Subtests: 100 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes

$ tools/test.py wpt/test-streams
[00:05|% 100|+ 1|- 0]: Done
All tests passed.

nodejs-github-bot · 2026-08-31T09:12:08Z

Review requested:

@nodejs/web-standards

Reject non-object inputs before looking up iterator methods in ReadableStream.from(). This matches the Web IDL async sequence conversion and prevents primitive strings from being accepted through property-access boxing. This fixes the WPT test: "ReadableStream.from throws on invalid iterables; specifically a string" Refs: https://webidl.spec.whatwg.org/#es-sequence Signed-off-by: Jeong SeokChan <starp321@naver.com>

MattiasBuelens · 2026-08-31T09:26:52Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

standard-Chan · 2026-08-31T09:31:12Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥
This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

Thanks for letting me know. I missed them.

I'll close this PR. Thanks for reviewing it!

codecov · 2026-08-31T11:03:29Z

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (4605cf5) to head (d41a8e0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65676 +/- ##
==========================================
+ Coverage 90.06% 90.11% +0.05% 
==========================================
Files 754 754 Lines 255759 256313 +554 Branches 48327 48515 +188 ==========================================
+ Hits 230350 230988 +638 + Misses 16534 16450 -84 
Partials 8875 8875

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	`90.58% <40.00%> (+3.25%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

standard-Chan · 2026-08-31T09:12:02Z

This updates ReadableStream.from() to reject primitive values before looking up iterator methods.

WHATWG Streams changed ReadableStream.from() to use the Web IDL async_sequence<T> type (added in whatwg#1372)

That makes string inputs invalid because Web IDL sequence conversion requires non-object values to throw a TypeError:
spec es-sequence

If V is not an Object, throw a TypeError.

WPT added coverage for this behavior here: web-platform-tests/wpt#59594

This change aligns Node.js with that WPT expectation and removes the corresponding expected failure for test (ReadableStream.from throws on invalid iterables; specifically a string)

Tests:

$ node test/wpt/test-streams.js readable-streams/from.any.js
Files: 2/2 ran, 2 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes
Subtests: 100 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes

$ tools/test.py wpt/test-streams
[00:05|% 100|+ 1|- 0]: Done
All tests passed.

nodejs-github-bot · 2026-08-31T09:12:08Z

Review requested:

@nodejs/web-standards

Reject non-object inputs before looking up iterator methods in ReadableStream.from(). This matches the Web IDL async sequence conversion and prevents primitive strings from being accepted through property-access boxing. This fixes the WPT test: "ReadableStream.from throws on invalid iterables; specifically a string" Refs: https://webidl.spec.whatwg.org/#es-sequence Signed-off-by: Jeong SeokChan <starp321@naver.com>

MattiasBuelens · 2026-08-31T09:26:52Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

standard-Chan · 2026-08-31T09:31:12Z

Thanks for your contribution, but I'm afraid this is a duplicate... 😥
This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

Thanks for letting me know. I missed them.

I'll close this PR. Thanks for reviewing it!

codecov · 2026-08-31T11:03:29Z

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (4605cf5) to head (d41a8e0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65676 +/- ##
==========================================
+ Coverage 90.06% 90.11% +0.05% 
==========================================
Files 754 754 Lines 255759 256313 +554 Branches 48327 48515 +188 ==========================================
+ Hits 230350 230988 +638 + Misses 16534 16450 -84 
Partials 8875 8875

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	`90.58% <40.00%> (+3.25%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Aug 31, 2026

standard-Chan force-pushed the fix-readable-stream-wpt branch from 095cd5f to d41a8e0Compare August 31, 2026 09:17

standard-Chan closed this Aug 31, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Aug 31, 2026

standard-Chan force-pushed the fix-readable-stream-wpt branch from 095cd5f to d41a8e0Compare August 31, 2026 09:17

standard-Chan closed this Aug 31, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Aug 31, 2026

standard-Chan force-pushed the fix-readable-stream-wpt branch from 095cd5f to d41a8e0Compare August 31, 2026 09:17

standard-Chan closed this Aug 31, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Aug 31, 2026

standard-Chan force-pushed the fix-readable-stream-wpt branch from 095cd5f to d41a8e0Compare August 31, 2026 09:17

standard-Chan closed this Aug 31, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Aug 31, 2026

standard-Chan force-pushed the fix-readable-stream-wpt branch from 095cd5f to d41a8e0Compare August 31, 2026 09:17

standard-Chan closed this Aug 31, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Aug 31, 2026

standard-Chan force-pushed the fix-readable-stream-wpt branch from 095cd5f to d41a8e0Compare August 31, 2026 09:17

standard-Chan closed this Aug 31, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Aug 31, 2026

standard-Chan force-pushed the fix-readable-stream-wpt branch from 095cd5f to d41a8e0Compare August 31, 2026 09:17

standard-Chan closed this Aug 31, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Aug 31, 2026

standard-Chan force-pushed the fix-readable-stream-wpt branch from 095cd5f to d41a8e0Compare August 31, 2026 09:17

standard-Chan closed this Aug 31, 2026

Uh oh!

Uh oh!

Conversation

standard-Chan commented Aug 31, 2026

Tests:

Uh oh!

nodejs-github-bot commented Aug 31, 2026

Uh oh!

MattiasBuelens commented Aug 31, 2026

Uh oh!

standard-Chan commented Aug 31, 2026

Uh oh!

codecovBot commented Aug 31, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

standard-Chan commented Aug 31, 2026

Tests:

Uh oh!

nodejs-github-bot commented Aug 31, 2026

Uh oh!

MattiasBuelens commented Aug 31, 2026

Uh oh!

standard-Chan commented Aug 31, 2026

Uh oh!

codecovBot commented Aug 31, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

standard-Chan commented Aug 31, 2026

Tests:

Uh oh!

nodejs-github-bot commented Aug 31, 2026

Uh oh!

MattiasBuelens commented Aug 31, 2026

Uh oh!

standard-Chan commented Aug 31, 2026

Uh oh!

codecovBot commented Aug 31, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

standard-Chan commented Aug 31, 2026

Tests:

Uh oh!

nodejs-github-bot commented Aug 31, 2026

Uh oh!

MattiasBuelens commented Aug 31, 2026

Uh oh!

standard-Chan commented Aug 31, 2026