sqlite: bind undefined to NULL

[TrevorBurnham]

Fixes#61824

This PR re-implements #62008 by @mike-git374. The one-line behavior change is theirs; this PR adds the documentation and the remaining test coverage.

Omitting a named parameter binds NULL, but passing undefined for that same parameter threw ERR_INVALID_ARG_TYPE:

s.run({k: 1});// v binds to NULLs.run({k: 2,v: undefined});// throws ERR_INVALID_ARG_TYPE

Binding undefined to NULL makes those agree. It also matches JSValueToSQLiteResult, which already maps a user-defined function's undefined return value to NULL, and SQLite's own WASM oo1 API.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (f9ab994) to head (47bbca8).

Additional details and impacted files

@@ Coverage Diff @@## main #65709 +/- ##
==========================================
- Coverage 90.07% 90.04% -0.03% 
==========================================
Files 754 754 Lines 256395 256395 Branches 48494 48499 +5 ==========================================
- Hits 230947 230875 -72 - Misses 16563 16639 +76 + Partials 8885 8881 -4 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	82.05% <100.00%> (+0.06%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TrevorBurnham]

Fixes#61824

This PR re-implements #62008 by @mike-git374. The one-line behavior change is theirs; this PR adds the documentation and the remaining test coverage.

Omitting a named parameter binds NULL, but passing undefined for that same parameter threw ERR_INVALID_ARG_TYPE:

s.run({k: 1});// v binds to NULLs.run({k: 2,v: undefined});// throws ERR_INVALID_ARG_TYPE

Binding undefined to NULL makes those agree. It also matches JSValueToSQLiteResult, which already maps a user-defined function's undefined return value to NULL, and SQLite's own WASM oo1 API.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (f9ab994) to head (47bbca8).

Additional details and impacted files

@@ Coverage Diff @@## main #65709 +/- ##
==========================================
- Coverage 90.07% 90.04% -0.03% 
==========================================
Files 754 754 Lines 256395 256395 Branches 48494 48499 +5 ==========================================
- Hits 230947 230875 -72 - Misses 16563 16639 +76 + Partials 8885 8881 -4 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	82.05% <100.00%> (+0.06%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TrevorBurnham]

Fixes#61824

This PR re-implements #62008 by @mike-git374. The one-line behavior change is theirs; this PR adds the documentation and the remaining test coverage.

Omitting a named parameter binds NULL, but passing undefined for that same parameter threw ERR_INVALID_ARG_TYPE:

s.run({k: 1});// v binds to NULLs.run({k: 2,v: undefined});// throws ERR_INVALID_ARG_TYPE

Binding undefined to NULL makes those agree. It also matches JSValueToSQLiteResult, which already maps a user-defined function's undefined return value to NULL, and SQLite's own WASM oo1 API.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (f9ab994) to head (47bbca8).

Additional details and impacted files

@@ Coverage Diff @@## main #65709 +/- ##
==========================================
- Coverage 90.07% 90.04% -0.03% 
==========================================
Files 754 754 Lines 256395 256395 Branches 48494 48499 +5 ==========================================
- Hits 230947 230875 -72 - Misses 16563 16639 +76 + Partials 8885 8881 -4 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	82.05% <100.00%> (+0.06%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TrevorBurnham]

Fixes#61824

This PR re-implements #62008 by @mike-git374. The one-line behavior change is theirs; this PR adds the documentation and the remaining test coverage.

Omitting a named parameter binds NULL, but passing undefined for that same parameter threw ERR_INVALID_ARG_TYPE:

s.run({k: 1});// v binds to NULLs.run({k: 2,v: undefined});// throws ERR_INVALID_ARG_TYPE

Binding undefined to NULL makes those agree. It also matches JSValueToSQLiteResult, which already maps a user-defined function's undefined return value to NULL, and SQLite's own WASM oo1 API.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (f9ab994) to head (47bbca8).

Additional details and impacted files

@@ Coverage Diff @@## main #65709 +/- ##
==========================================
- Coverage 90.07% 90.04% -0.03% 
==========================================
Files 754 754 Lines 256395 256395 Branches 48494 48499 +5 ==========================================
- Hits 230947 230875 -72 - Misses 16563 16639 +76 + Partials 8885 8881 -4 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	82.05% <100.00%> (+0.06%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TrevorBurnham]

Fixes#61824

This PR re-implements #62008 by @mike-git374. The one-line behavior change is theirs; this PR adds the documentation and the remaining test coverage.

Omitting a named parameter binds NULL, but passing undefined for that same parameter threw ERR_INVALID_ARG_TYPE:

s.run({k: 1});// v binds to NULLs.run({k: 2,v: undefined});// throws ERR_INVALID_ARG_TYPE

Binding undefined to NULL makes those agree. It also matches JSValueToSQLiteResult, which already maps a user-defined function's undefined return value to NULL, and SQLite's own WASM oo1 API.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (f9ab994) to head (47bbca8).

Additional details and impacted files

@@ Coverage Diff @@## main #65709 +/- ##
==========================================
- Coverage 90.07% 90.04% -0.03% 
==========================================
Files 754 754 Lines 256395 256395 Branches 48494 48499 +5 ==========================================
- Hits 230947 230875 -72 - Misses 16563 16639 +76 + Partials 8885 8881 -4 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	82.05% <100.00%> (+0.06%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TrevorBurnham]

Fixes#61824

This PR re-implements #62008 by @mike-git374. The one-line behavior change is theirs; this PR adds the documentation and the remaining test coverage.

Omitting a named parameter binds NULL, but passing undefined for that same parameter threw ERR_INVALID_ARG_TYPE:

s.run({k: 1});// v binds to NULLs.run({k: 2,v: undefined});// throws ERR_INVALID_ARG_TYPE

Binding undefined to NULL makes those agree. It also matches JSValueToSQLiteResult, which already maps a user-defined function's undefined return value to NULL, and SQLite's own WASM oo1 API.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (f9ab994) to head (47bbca8).

Additional details and impacted files

@@ Coverage Diff @@## main #65709 +/- ##
==========================================
- Coverage 90.07% 90.04% -0.03% 
==========================================
Files 754 754 Lines 256395 256395 Branches 48494 48499 +5 ==========================================
- Hits 230947 230875 -72 - Misses 16563 16639 +76 + Partials 8885 8881 -4 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	82.05% <100.00%> (+0.06%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TrevorBurnham]

Fixes#61824

This PR re-implements #62008 by @mike-git374. The one-line behavior change is theirs; this PR adds the documentation and the remaining test coverage.

Omitting a named parameter binds NULL, but passing undefined for that same parameter threw ERR_INVALID_ARG_TYPE:

s.run({k: 1});// v binds to NULLs.run({k: 2,v: undefined});// throws ERR_INVALID_ARG_TYPE

Binding undefined to NULL makes those agree. It also matches JSValueToSQLiteResult, which already maps a user-defined function's undefined return value to NULL, and SQLite's own WASM oo1 API.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (f9ab994) to head (47bbca8).

Additional details and impacted files

@@ Coverage Diff @@## main #65709 +/- ##
==========================================
- Coverage 90.07% 90.04% -0.03% 
==========================================
Files 754 754 Lines 256395 256395 Branches 48494 48499 +5 ==========================================
- Hits 230947 230875 -72 - Misses 16563 16639 +76 + Partials 8885 8881 -4 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	82.05% <100.00%> (+0.06%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TrevorBurnham]

Fixes#61824

This PR re-implements #62008 by @mike-git374. The one-line behavior change is theirs; this PR adds the documentation and the remaining test coverage.

Omitting a named parameter binds NULL, but passing undefined for that same parameter threw ERR_INVALID_ARG_TYPE:

s.run({k: 1});// v binds to NULLs.run({k: 2,v: undefined});// throws ERR_INVALID_ARG_TYPE

Binding undefined to NULL makes those agree. It also matches JSValueToSQLiteResult, which already maps a user-defined function's undefined return value to NULL, and SQLite's own WASM oo1 API.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (f9ab994) to head (47bbca8).

Additional details and impacted files

@@ Coverage Diff @@## main #65709 +/- ##
==========================================
- Coverage 90.07% 90.04% -0.03% 
==========================================
Files 754 754 Lines 256395 256395 Branches 48494 48499 +5 ==========================================
- Hits 230947 230875 -72 - Misses 16563 16639 +76 + Partials 8885 8881 -4 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	82.05% <100.00%> (+0.06%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.