Skip to content

src,lib: add util.markPromiseAsHandled - #65805

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/promise-mark-promise-as-handled
Open

src,lib: add util.markPromiseAsHandled#65805
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/promise-mark-promise-as-handled

Conversation

@jasnell

Copy link
Copy Markdown
Member

Getting tired of seeing promise.catch(() => {}) in places ;-)

@jasnelljasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 5, 2026
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Sep 5, 2026
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
jasnellforce-pushed the jasnell/promise-mark-promise-as-handled branch from a784a8f to d8a9adaCompareSeptember 5, 2026 02:55
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecovBot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (57860ef) to head (d8a9ada).

Files with missing linesPatch %Lines
src/node_util.cc88.88%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65805 +/- ##
==========================================
- Coverage 90.14% 90.14% -0.01% 
==========================================
Files 769 769 Lines 262968 262985 +17 Branches 50052 50068 +16 ==========================================
+ Hits 237049 237064 +15 - Misses 16924 16933 +9 + Partials 8995 8988 -7 
Files with missing linesCoverage Δ
lib/util.js100.00% <100.00%> (ø)
src/node_util.cc81.58% <88.88%> (+0.19%)⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.semver-minorPRs that contain new features and should be released in the next minor version.utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jasnell@nodejs-github-bot