Skip to content

test: improve assert message for debugging - #6581

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:msg
Closed

test: improve assert message for debugging#6581
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:msg

Conversation

@Trott

@TrottTrott commented May 4, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Previously, the assertion changed in this commit would print the same
message no matter which of the four test cases failed. The assert has
been changed so that it will indicate which test case failed.

Refs: #6577

Previously, the assertion changed in this commit would print the same
message no matter which of the four test cases failed. The assert has
been changed so that it will indicate which test case failed.
Refs: nodejs#6577
@TrottTrott added the test Issues and PRs related to the tests. label May 4, 2016
@addaleax

Copy link
Copy Markdown
Member

LGTM

2 similar comments
@santigimeno

Copy link
Copy Markdown
Member

LGTM

@jasnell

Copy link
Copy Markdown
Member

LGTM

@mscdexmscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label May 4, 2016
@mcollina

Copy link
Copy Markdown
Member

LGTM

@mcollina

mcollina commented May 5, 2016

Copy link
Copy Markdown
Member

@Trott while you are at it, you should update the allocation of the buffers to the new method, like what was done for the ipv4 equivalent: https://github.com/nodejs/node/blob/master/test/parallel/test-dgram-send-default-host.js#L9-L12

@JacksonTian

Copy link
Copy Markdown
Contributor

LGTM

@mcollina

Copy link
Copy Markdown
Member

I think the commit message needs to be a little more explicative
Il giorno gio 5 mag 2016 alle 11:44 Jackson Tian notifications@github.com
ha scritto:

LGTM


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#6581 (comment)

@cjihrig

Copy link
Copy Markdown
Contributor

LGTM

@jasnell

Copy link
Copy Markdown
Member

@addaleax

Copy link
Copy Markdown
Member

If @Trott is okay with that, this should probably be not be landed in favour of #6607. This PR served its purpose well enough. :)

@jasnell

Copy link
Copy Markdown
Member

SGTM

@Trott

Trott commented May 6, 2016

Copy link
Copy Markdown
MemberAuthor

If @Trott is okay with that, this should probably be not be landed in favour of #6607.

I agree. Closing this one.

@TrottTrott closed this May 6, 2016
@Trott
Trott deleted the msg branch January 13, 2022 22:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dgramIssues and PRs related to the dgram subsystem / UDP.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott@addaleax@santigimeno@jasnell@mcollina@JacksonTian@cjihrig@mscdex