Uh oh!
There was an error while loading. Please reload this page.
doc: Add documentation on resolveNaptr and naptr rrtype - #6586
Closed
doug-wade wants to merge 1 commit into
Closed
Conversation
addaleax
commented
May 5, 2016
Member
The commit message subject is > 50 chars and the subsystem should be |
addaleax
commented
May 5, 2016
Member
Also, git sets your |
doug-wadeforce-pushed
the
fix-6507-add-naptr-to-dns-docs
branch
from
May 6, 2016 03:46
1b02582 to
e5e683eCompareMember
There was a problem hiding this comment.
nit: Can you add a short For example: in here and tack a js to the end of the three backticks to get the code styling. Thank you!
jasnell
commented
May 6, 2016
Member
Small nit. Otherwise LGTM |
doug-wadeforce-pushed
the
fix-6507-add-naptr-to-dns-docs
branch
2 times, most recently
from
May 13, 2016 00:08
8d59711 to
564a59bComparesilverwind
commented
May 17, 2016
Contributor
LGTM once #6586 (comment) is addressed. |
Updates the dns module documentation to include documentation on the resolveNaptr method, and also adds the option NAPTR to the list of valid values for rrtype in dns.resolve(hostname[, rrtype], callback)
doug-wadeforce-pushed
the
fix-6507-add-naptr-to-dns-docs
branch
from
May 18, 2016 23:27
564a59b to
a75b423Comparedoug-wade
commented
May 18, 2016
ContributorAuthor
@jasnell fixed |
silverwind pushed a commit
that referenced
this pull request
May 19, 2016
Updates the dns module documentation to include documentation on the resolveNaptr method, and also adds the option NAPTR to the list of valid values for rrtype in dns.resolve(hostname[, rrtype], callback). PR-URL: #6586Fixes: #6507 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
silverwind
commented
May 19, 2016
Contributor
Thanks! Landed in bd72857. |
Fishrock123 pushed a commit
that referenced
this pull request
May 23, 2016
Updates the dns module documentation to include documentation on the resolveNaptr method, and also adds the option NAPTR to the list of valid values for rrtype in dns.resolve(hostname[, rrtype], callback). PR-URL: #6586Fixes: #6507 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit
that referenced
this pull request
Jun 2, 2016
Updates the dns module documentation to include documentation on the resolveNaptr method, and also adds the option NAPTR to the list of valid values for rrtype in dns.resolve(hostname[, rrtype], callback). PR-URL: #6586Fixes: #6507 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Jul 11, 2016
Updates the dns module documentation to include documentation on the resolveNaptr method, and also adds the option NAPTR to the list of valid values for rrtype in dns.resolve(hostname[, rrtype], callback). PR-URL: #6586Fixes: #6507 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Jul 11, 2016
Updates the dns module documentation to include documentation on the resolveNaptr method, and also adds the option NAPTR to the list of valid values for rrtype in dns.resolve(hostname[, rrtype], callback). PR-URL: #6586Fixes: #6507 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Updates the dns module documentation to include documentation on the resolveNaptr method, and also adds the option NAPTR to the list of valid values for rrtype in dns.resolve(hostname[, rrtype], callback). PR-URL: #6586Fixes: #6507 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Updates the dns module documentation to include documentation on
the resolveNaptr method, and also adds the option NAPTR to the
list of valid values for rrtype in dns.resolve(hostname[, rrtype],
callback). See #6507 for context.