Uh oh!
There was an error while loading. Please reload this page.
path: fix basename() regressions - #6590
Conversation
1979099 to
e3b43c0Comparemscdex
commented
May 5, 2016
@mscdex ... just for purposes of keeping track, was this related to the performance changes that landed in v5 or separate issue? (@nodejs/lts has been keeping an eye on the path changes and related regressions in case we decide to pull those in to v4 at some point) |
jasnell
commented
May 5, 2016
Unrelated build bot failure in CI (https://ci.nodejs.org/job/node-test-commit-arm/3146/nodes=armv8-ubuntu1404/console). LGTM otherwise. No specific comments on the commits. |
@jasnell Yes, this is fixing a regression from the |
There was a problem hiding this comment.
maybe add a few tests for absolute paths with this case?
There was a problem hiding this comment.
I've now added absolute versions of these tests, is that what you meant?
There was a problem hiding this comment.
I was thinking maybe something more like path.basename('/aaa/bbb') since we have seen regressions for absolute vs relative paths. They may already be there though
There was a problem hiding this comment.
Ok, I've added that and a couple more.
b274124 to
f1595e1Compareevanlucas
commented
May 11, 2016
LGTM if CI is happy |
mscdex
commented
May 11, 2016
There was a problem hiding this comment.
Just wondering, why were these tests removed?
There was a problem hiding this comment.
The TypeError checks are already done later on in the test file
for all path functions.
mscdex
commented
May 18, 2016
One last CI before landing, just in case: https://ci.nodejs.org/job/node-test-pull-request/2684/ |
f1595e1 to
f4a87abCompareThis commit fixes a regression in basename() for the case when a supplied extension name completely matches the resulting basename. Fixes: nodejs#6587 PR-URL: nodejs#6590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
The TypeError checks are already done later on in the test file for all path functions. PR-URL: nodejs#6590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: nodejs#6590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
f4a87ab to
27549f6CompareThe TypeError checks are already done later on in the test file for all path functions. PR-URL: #6590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #6590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
The TypeError checks are already done later on in the test file for all path functions. PR-URL: #6590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #6590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Checklist
Affected core subsystem(s)
Description of change
This commit fixes a regression in basename() for the case when a supplied extension name completely matches the resulting basename.
Fixes: #6587