Uh oh!
There was an error while loading. Please reload this page.
test: make sure O_NOATIME is present only in Linux - #6614
Closed
thefourtheye wants to merge 2 commits into
Closed
Conversation
As it is, the test checks if the return value is `undefined` in other platforms. But it should also make sure that the `O_NOATIME` should be found only in Linux.
| assert(constants.hasOwnProperty('O_NOATIME')); | ||
| assert.strictEqual(constants.O_NOATIME, 0x40000); | ||
| } else { | ||
| assert(false === constants.hasOwnProperty('O_NOATIME')); |
Member
There was a problem hiding this comment.
If you use !('O_NOATIME' in constants), it will check the prototype as well (for the very unlikely case that we decide to move things to the prototype in the future.)
bnoordhuis
commented
May 6, 2016
Member
LGTM with a suggestion. |
bnoordhuis
commented
May 6, 2016
Member
LGTM |
cjihrig
commented
May 6, 2016
Contributor
LGTM. CI is green. |
addaleax
commented
May 12, 2016
Member
LGTM |
thefourtheye
commented
May 12, 2016
ContributorAuthor
Landed in 4803d11. |
thefourtheye added a commit
that referenced
this pull request
May 12, 2016
As it is, the test checks if the return value is `undefined` in other platforms. But it should also make sure that the `O_NOATIME` should be found only in Linux. PR-URL: #6614 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit
that referenced
this pull request
May 17, 2016
As it is, the test checks if the return value is `undefined` in other platforms. But it should also make sure that the `O_NOATIME` should be found only in Linux. PR-URL: #6614 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
commented
Jun 2, 2016
Contributor
@thefourtheye lts? |
addaleax
commented
Jun 2, 2016
Member
@thealphanerd This depends on #6492 which is a semver-minor one, so probably no for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
As it is, the test checks if the return value is
undefinedin otherplatforms. But it should also make sure that the
O_NOATIMEshould befound only in Linux.
Ref: #6492
cc @Trott@bnoordhuis@jasnell
CI Run: https://ci.nodejs.org/job/node-test-pull-request/2522/