Uh oh!
There was an error while loading. Please reload this page.
test: pass python path to node-gyp - #6646
Conversation
bnoordhuis
commented
May 9, 2016
addaleax
commented
May 12, 2016
LGTM |
addaleax
commented
May 12, 2016
@hefangshi You author name in this commit is given as “Sighless”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you. |
hefangshi
commented
May 12, 2016
@addaleax Thanks for mention this, I prefer to use full name rather than "Sighless", is threre some way to change that? |
bnoordhuis
commented
May 12, 2016
@hefangshi |
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself.
f11b73d to
b66fe3dComparehefangshi
commented
May 12, 2016
@bnoordhuis@addaleax Thanks, already changed ;) |
addaleax
commented
May 12, 2016
@hefangshi “hefangshi” is correct, right? Just checking to make sure it’s really what you want, because you just changed the name on your profile to “Fangshi He” and that would be okay just as well. |
hefangshi
commented
May 12, 2016
@addaleax hefangshi is fine ;) |
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself. PR-URL: #6646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
commented
May 12, 2016
Thanks! Landed in 25f8d04. |
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself. PR-URL: #6646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
commented
Jun 2, 2016
@addaleax lts? |
addaleax
commented
Jun 2, 2016
@thealphanerd yep 👍 |
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself. PR-URL: #6646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself. PR-URL: #6646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself. PR-URL: #6646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself. PR-URL: #6646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself. PR-URL: #6646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself. PR-URL: #6646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Checklist
Affected core subsystem(s)
test
Description of change
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.