Uh oh!
There was an error while loading. Please reload this page.
doc: add added: information for v8 - #6684
Closed
Trott wants to merge 1 commit into
Closed
Conversation
36 tasks
bnoordhuis
commented
May 11, 2016
Member
LGTM |
2 similar comments
claudiorodriguez
commented
May 11, 2016
Contributor
LGTM |
Qard
commented
May 11, 2016
Member
LGTM |
addaleax
commented
May 12, 2016
Member
LGTM but it may be nice to have the |
Trott
commented
May 12, 2016
MemberAuthor
Ref: added, rebased, force pushed. |
Trott
commented
May 12, 2016
MemberAuthor
And just to have the Ref here: Ref: #6578 |
Trott
commented
May 13, 2016
MemberAuthor
Doc-only change, but exercising caution anyway: https://ci.nodejs.org/job/node-test-pull-request/2618/ |
Trott
commented
May 13, 2016
MemberAuthor
Only CI failure was a buildbot failure. Landing... |
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 13, 2016
PR-URL: nodejs#6684 Ref: nodejs#6578 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Trott
commented
May 13, 2016
MemberAuthor
Landed in b3bc362 |
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
PR-URL: nodejs#6684 Ref: nodejs#6578 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc v8
Description of change