Uh oh!
There was an error while loading. Please reload this page.
test: favor strictEqual() in addon test - #6704
Closed
Trott wants to merge 1 commit into
Closed
Conversation
MemberAuthor
There was a problem hiding this comment.
Hmmm...we have a custom lint rule for that. I know I made it lenient to avoid false positives, but it really should have flagged that...Will have to take a look
Anyway, yes, I'll fix the alignment!
bnoordhuis
commented
May 12, 2016
Member
LGTM with nit. |
jasnell
commented
May 12, 2016
Member
LGTM |
Replace `assert.equal()` with `assert.strictEqual()` throughout `addon/make-callback-recurse/test.js`.
Trott
commented
May 12, 2016
MemberAuthor
Nit addressed, rebased, force pushed. |
bnoordhuis
commented
May 12, 2016
Member
LGTM (but I already said that.) |
Trott
commented
May 12, 2016
MemberAuthor
@bnoordhuis wrote:
From http://logs.libuv.org/node-dev/2016-05-06: |
cjihrig
commented
May 13, 2016
Contributor
LGTM |
Trott
commented
May 13, 2016
MemberAuthor
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 14, 2016
Replace `assert.equal()` with `assert.strictEqual()` throughout `addon/make-callback-recurse/test.js`. PR-URL: nodejs#6704 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott
commented
May 14, 2016
MemberAuthor
Landed in 517d1da |
evanlucas pushed a commit
that referenced
this pull request
May 17, 2016
Replace `assert.equal()` with `assert.strictEqual()` throughout `addon/make-callback-recurse/test.js`. PR-URL: #6704 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Replace
assert.equal()withassert.strictEqual()throughoutaddon/make-callback-recurse/test.js.