doc: make the documentation print-friendly

[sorcamarian]

Checklist

• tests and code linting passes
• a test and/or benchmark is included
• documentation is changed or added
• the commit message follows commit guidelines

Affected core subsystem(s)

Description of change

• Fixes: Node.js documentation is not print-friendly #6743

[Qard]

LGTM, but please add doc: to the start of the commit message.

[Qard]

Sorry, I meant the commit itself, not just the PR. You'll need to do a git commit --amend to edit the commit message, then force push the modified commit.

[MylesBorins]

/cc @nodejs/website

[sorcamarian]

@Qard I did --ammend, and --force push
Please make a check

[ChALkeR]

Nit: missing newline at the end of file.

[sorcamarian]

@ChALkeR I updated the commit.

[lpinca]

New line still missing here.

[lpinca]

Please edit the commit message while you are at it: Make -> make.

[ChALkeR]

Replace

html {

with

html {

as I noted above (one space between html and { instead of two).

[sorcamarian]

White spaces removed.

[sorcamarian]

Has something remained?

[addaleax]

@sorcamarian I think this is good to go. Like @lpinca said in his last comment, the commit message subject should be all-lowercase, but things like this can be taken of when landing the commit.

If you’re asking why this isn’t merged yet, it’s just that it’s customary to wait a bit (72 hours over weekends is a general rule) before merging so that everyone has a chance to look at it.

I’d suggest you additionally use Fixes: https://github.com/nodejs/node/issues/6743 instead of the more info line, because then the issue will be closed automatically when your commit is landed.

Also: You author name in this commit is given as “Marian”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

[sorcamarian]

@addaleax Thanks for the given explanations.

I'm fine with the current name("Marian").

[MylesBorins]

LGTM... minor nits regarding newlines + commit message can be fixed when landing

Would like to hear something from more folks from @nodejs/documentation and @nodejs/website

[lpinca]

All nits seem to be fixed.

[addaleax]

LGTM

[sorcamarian]

Any news?

[eljefedelrodeodeljefe]

Landed in c161849. Thanks!