Uh oh!
There was an error while loading. Please reload this page.
tools: disallow deprecated define getter/setter - #6774
Closed
Trott wants to merge 2 commits into
Closed
Conversation
2 tasks
Member
There was a problem hiding this comment.
!node.computed... so obj['__defineGetter__'] = getter is the escape hatch? =)
bnoordhuis
commented
May 15, 2016
Member
LGTM. This won't catch |
jasnell
commented
May 15, 2016
Member
#6766 is the other PR that would need to land before or along with this. It catches the uses inside internal/process/stdio |
jasnell
commented
May 15, 2016
Member
jbergstroem
commented
May 15, 2016
Member
LGTM here too. |
jasnell
commented
May 17, 2016
Member
In preparation for a lint rule to flag `__defineGetter__`, refactor the one remaining instance in the code base.
Trott
commented
May 18, 2016
MemberAuthor
@jasnell I added a commit to handle the one remaining instance in the tests. PTAL |
jasnell
commented
May 18, 2016
Member
LGTM if CI is green. |
bnoordhuis
commented
May 19, 2016
Member
Still LGTM FWIW. |
Trott
commented
May 19, 2016
MemberAuthor
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 20, 2016
In preparation for a lint rule to flag `__defineGetter__`, refactor the one remaining instance in the code base. PR-URL: nodejs#6774 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 20, 2016
PR-URL: nodejs#6774 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Refs: nodejs#6768
Trott
commented
May 20, 2016
MemberAuthor
Fishrock123 pushed a commit
that referenced
this pull request
May 23, 2016
In preparation for a lint rule to flag `__defineGetter__`, refactor the one remaining instance in the code base. PR-URL: #6774 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Jun 2, 2016
In preparation for a lint rule to flag `__defineGetter__`, refactor the one remaining instance in the code base. PR-URL: #6774 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Jun 3, 2016
Contributor
@Trott lts? |
Trott
commented
Jun 3, 2016
MemberAuthor
@thealphanerd Would need to rewrite the rule to work in v4 so I'm inclined to say no. |
MylesBorins
commented
Jun 3, 2016
Contributor
don't land it is 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
Refs: #6768
This should not land until #6768 lands. Labeling
in progress./cc @jasnell