Skip to content

doc: clarify fs.mkdtemp prefix argument - #6800

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:doc-clarify-mkdtemp
Closed

doc: clarify fs.mkdtemp prefix argument#6800
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:doc-clarify-mkdtemp

Conversation

@jasnell

@jasnelljasnell commented May 17, 2016•
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
Affected core subsystem(s)

doc (fs)

Description of change

Per: #6142

Clarify the prefix argument.

@nodejs/fs @nodejs/documentation

@jasnell
doc: clarify fs.mkdtemp prefix argument
2aad164
Per: nodejs#6142
Clarify the prefix argument.
Fixes: nodejs#6142
@jasnelljasnell added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 17, 2016
@bnoordhuis

bnoordhuis commented May 17, 2016

Copy link
Copy Markdown
Member

LGTM

thefourtheye
thefourtheye reviewed May 17, 2016
View reviewed changes
Comment threaddoc/api/fs.md Outdated

```js
// The parent directory for the new temporary directory
const tmp_dir = '/tmp';

@thefourtheyethefourtheyeMay 17, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we follow camel casing for js variables, right?

@jasnell

jasnell commented May 17, 2016

Copy link
Copy Markdown
MemberAuthor

@thefourtheye ... nits fixed.

@r-52

r-52 commented May 17, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell added a commit that referenced this pull request May 18, 2016
@jasnell
doc: clarify fs.mkdtemp prefix argument
2ccba1f
Per: #6142
Clarify the prefix argument.
Fixes: #6142
PR-URL: #6800
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@jasnell

jasnell commented May 18, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in 2ccba1f

@jasnelljasnell closed this May 18, 2016
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
@jasnell@Fishrock123
doc: clarify fs.mkdtemp prefix argument
3d7ce17
Per: #6142
Clarify the prefix argument.
Fixes: #6142
PR-URL: #6800
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@jasnell@rvagg
doc: clarify fs.mkdtemp prefix argument
5cad04b
Per: #6142
Clarify the prefix argument.
Fixes: #6142
PR-URL: #6800
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jun 2, 2016
Closed
@vtjnashvtjnash mentioned this pull request Mar 4, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@bnoordhuis@r-52@thefourtheye@MylesBorins