Uh oh!
There was an error while loading. Please reload this page.
doc: add note for fs.watch on virtualized env - #6809
Closed
eljefedelrodeodeljefe wants to merge 1 commit into
Closed
doc: add note for fs.watch on virtualized env#6809eljefedelrodeodeljefe wants to merge 1 commit into
eljefedelrodeodeljefe wants to merge 1 commit into
Conversation
cjihrig
commented
May 17, 2016
Contributor
LGTM |
1 similar comment
thefourtheye
commented
May 17, 2016
Contributor
LGTM |
Member
There was a problem hiding this comment.
minor nit... I'd restructure the sentence just a bit...
Something like:
For example, watching files or directories can be unreliable, and in some
cases impossible, on network file systems (NFS, SMB, etc), and on host
file systems when using virtualization software such as Vagrant, Docker, etc.
But I'm good with this also ;-)
jasnell
commented
May 17, 2016
Member
Left one comment but generally LGTM |
eljefedelrodeodeljefe
commented
May 17, 2016
ContributorAuthor
Fine for me. Will adapt it before landing. Thx |
mhdawson
commented
May 17, 2016
Member
I'm + 1for @jasnell's version, but generally LGTM as well. |
Member
There was a problem hiding this comment.
s/and on/or/? I suspect most programmers are like me and interpret it boolean logic-style.
bnoordhuis
commented
May 18, 2016
Member
LGTM with a suggestion. |
eljefedelrodeodeljefe
commented
May 19, 2016
ContributorAuthor
Went ahead and landed it in ae0f68d Addressed both @bnoordhuis an @jasnell nits |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
docDescription of change
On virtualization systems
fs.watchdoesn't work reliably, which is implicitly already in the respective docs. To make it more explicit this PR adds a subsentence. The following statement defers to use of fs.watchFile, which is the potential workaround.Fixes: #6765