Skip to content

process: remove deprecated process.EventEmitter - #6862

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:rm-ee
Closed

process: remove deprecated process.EventEmitter#6862
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:rm-ee

Conversation

@cjihrig

@cjihrigcjihrig commented May 18, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

process

Description of change

process.EventEmitter was deprecated for v6. This commit removes it for v7.

Refs: #5049

@cjihrig
process: remove deprecated process.EventEmitter
53c6050
process.EventEmitter was deprecated for v6. This commit removes
it for v7.
@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 18, 2016
@cjihrigcjihrig added process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. labels May 18, 2016
@bnoordhuis

bnoordhuis commented May 18, 2016

Copy link
Copy Markdown
Member

LGTM!

@addaleax

addaleax commented May 18, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/2692/

LGTM if it’s green.

@jasnell

jasnell commented May 18, 2016

Copy link
Copy Markdown
Member

LGTM

@ChALkeRChALkeR mentioned this pull request May 18, 2016
Closed
@Fishrock123

Fishrock123 commented May 18, 2016

Copy link
Copy Markdown
Contributor

Aren't we supposed to leave it for an LTS cycle? -1?

@bnoordhuis

bnoordhuis commented May 18, 2016

Copy link
Copy Markdown
Member

I think we can consider that condition fulfilled: it was deprecated almost five years ago.

@cjihrig

cjihrig commented May 18, 2016

Copy link
Copy Markdown
ContributorAuthor

Where is that policy exactly? It might be a matter of interpretation, as it wouldn't show up in LTS until Node v8.

cjihrig added a commit that referenced this pull request May 24, 2016
@cjihrig
process: remove deprecated process.EventEmitter
62b5442
process.EventEmitter was deprecated for v6. This commit removes
it for v7.
Refs: #5049
PR-URL: #6862
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig

cjihrig commented May 24, 2016

Copy link
Copy Markdown
ContributorAuthor

Landed in 62b5442.

@cjihrigcjihrig closed this May 24, 2016
@cjihrig
cjihrig deleted the rm-ee branch May 24, 2016 16:52
@mysticateamysticatea mentioned this pull request Oct 26, 2016
Closed
@pimterrypimterry mentioned this pull request Feb 10, 2017
Open
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.processIssues and PRs related to the process subsystem.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cjihrig@bnoordhuis@addaleax@jasnell@Fishrock123@nodejs-github-bot