Uh oh!
There was an error while loading. Please reload this page.
doc: minor improvements to util.md - #6932
Closed
thefourtheye wants to merge 2 commits into
Closed
Conversation
| util.isArray([]); | ||
| // true | ||
| util.isArray(new Array) | ||
| util.isArray(new Array); |
Contributor
There was a problem hiding this comment.
when were the semicolons removed? the docs wg style guide says we should normally have them.
jasnell
commented
May 23, 2016
Member
LGTM |
1 similar comment
eljefedelrodeodeljefe
commented
May 23, 2016
Contributor
LGTM |
| If there are more arguments passed to the `util.format()` method than the | ||
| number of placeholders, the extra arguments are coerced into strings (for | ||
| objects and symbols, `util.inspect()` is used) then concatenated to the | ||
| returned string, delimited by a space. |
Contributor
There was a problem hiding this comment.
Would "each delimited by a space" sound better here?
thefourtheye
commented
May 26, 2016
ContributorAuthor
@mscdex Addressed your comments. PTAL. |
mscdex
commented
May 26, 2016
Contributor
LGTM |
thefourtheye
commented
May 29, 2016
ContributorAuthor
Landed in 435e673 |
thefourtheye added a commit
that referenced
this pull request
May 29, 2016
PR-URL: #6932 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Fishrock123 pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
PR-URL: nodejs#6932 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
rvagg pushed a commit
that referenced
this pull request
Jun 2, 2016
PR-URL: #6932 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
cc @jasnell @nodejs/documentation