Uh oh!
There was an error while loading. Please reload this page.
tools: make sure doctool anchors respect @include - #6943
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
MylesBorins
commented
May 23, 2016
Contributor
/cc @nodejs/documentation |
eljefedelrodeodeljefe
commented
May 24, 2016
Contributor
Rubber stamp LGTM |
addaleax
commented
May 24, 2016
MemberAuthor
@eljefedelrodeodeljefe This contains actual code changes in the doctool, so I’d be glad if you’d take a quick look at the implementation when reviewing :) |
Member
Not sure if this should include a mention of a GitHub user in the commit message. |
addaleaxforce-pushed
the
doc-fix-broken-refs-singlepage
branch
from
May 24, 2016 10:40
514aab9 to
6f5e74eCompareaddaleax
commented
May 24, 2016
MemberAuthor
@ChALkeR ooooh… good point, fixed |
addaleax
commented
May 24, 2016
MemberAuthor
addaleax
commented
May 24, 2016
MemberAuthor
Also /cc @firedfox maybe? |
firedfox
commented
May 25, 2016
Contributor
LGTM |
This was referenced May 25, 2016
Previously, output files which were created using includes (notably, the single-page all.html) had basically broken internal links all over the place because references like `errors.html#errors_class_error` are being used, yet `id` attributes were generated that looked like `all_class_error`. This PR adds generation of comments from the include preprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriate `id` attributes can be generated.
addaleaxforce-pushed
the
doc-fix-broken-refs-singlepage
branch
from
May 25, 2016 20:57
6f5e74e to
e345dbbCompareMemberAuthor
Rebased, only conflict was a rather expected one in test/doctool/test-doctool-html.js. CI again to be on the safe side: |
addaleax added a commit
that referenced
this pull request
May 25, 2016
Previously, output files which were created using includes (notably, the single-page all.html) had basically broken internal links all over the place because references like `errors.html#errors_class_error` are being used, yet `id` attributes were generated that looked like `all_class_error`. This PR adds generation of comments from the include preprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriate `id` attributes can be generated. PR-URL: #6943 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Daniel Wang <wangyang0123@gmail.com>
addaleax
commented
May 25, 2016
MemberAuthor
Landed in b140bad @eljefedelrodeodeljefe Happy rebasing ;) |
Fishrock123 pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
Previously, output files which were created using includes (notably, the single-page all.html) had basically broken internal links all over the place because references like `errors.html#errors_class_error` are being used, yet `id` attributes were generated that looked like `all_class_error`. This PR adds generation of comments from the include preprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriate `id` attributes can be generated. PR-URL: nodejs#6943 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Daniel Wang <wangyang0123@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Jun 2, 2016
Previously, output files which were created using includes (notably, the single-page all.html) had basically broken internal links all over the place because references like `errors.html#errors_class_error` are being used, yet `id` attributes were generated that looked like `all_class_error`. This PR adds generation of comments from the include preprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriate `id` attributes can be generated. PR-URL: #6943 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Daniel Wang <wangyang0123@gmail.com>
MylesBorins
commented
Jul 11, 2016
Contributor
@addaleax lts? |
MylesBorins
commented
Jul 12, 2016
Contributor
@addaleax this one does not at all land cleanly :S |
addaleax added a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
Previously, output files which were created using includes (notably, the single-page all.html) had basically broken internal links all over the place because references like `errors.html#errors_class_error` are being used, yet `id` attributes were generated that looked like `all_class_error`. This PR adds generation of comments from the include preprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriate `id` attributes can be generated. PR-URL: nodejs#6943 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Daniel Wang <wangyang0123@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Previously, output files which were created using includes (notably, the single-page all.html) had basically broken internal links all over the place because references like `errors.html#errors_class_error` are being used, yet `id` attributes were generated that looked like `all_class_error`. This PR adds generation of comments from the include preprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriate `id` attributes can be generated. PR-URL: #6943 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Daniel Wang <wangyang0123@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Previously, output files which were created using includes (notably, the single-page all.html) had basically broken internal links all over the place because references like `errors.html#errors_class_error` are being used, yet `id` attributes were generated that looked like `all_class_error`. This PR adds generation of comments from the include preprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriate `id` attributes can be generated. PR-URL: #6943 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Daniel Wang <wangyang0123@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
Previously, output files which were created using includes (notably, the single-page all.html) had basically broken internal links all over the place because references like `errors.html#errors_class_error` are being used, yet `id` attributes were generated that looked like `all_class_error`. This PR adds generation of comments from the include preprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriate `id` attributes can be generated. PR-URL: #6943 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Daniel Wang <wangyang0123@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
Previously, output files which were created using includes (notably, the single-page all.html) had basically broken internal links all over the place because references like `errors.html#errors_class_error` are being used, yet `id` attributes were generated that looked like `all_class_error`. This PR adds generation of comments from the include preprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriate `id` attributes can be generated. PR-URL: #6943 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Daniel Wang <wangyang0123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doctool
Description of change
Previously, output files which were created using
@include(notably, the single-page all.html) had basically broken internal links all over the place because references likeerrors.html#errors_class_errorare being used, yetidattributes were generated that looked likeall_class_error.This PR adds generation of comments from the
@includepreprocessor that indicate from which file the current markdown bits come and lets the HTML output generation take advantage of that so that more appropriateidattributes can be generated.