Uh oh!
There was an error while loading. Please reload this page.
test: add regression test for Proxy as vm context - #6967
Merged
Conversation
thefourtheye
commented
May 25, 2016
Contributor
LGTM |
thefourtheye
commented
May 25, 2016
Contributor
cjihrig
commented
May 25, 2016
Contributor
LGTM. The provided CI URL is a 404. |
thefourtheye
commented
May 25, 2016
Contributor
Oops. Sorry. I have no idea what happened there. New CI Run: https://ci.nodejs.org/job/node-test-pull-request/2781/ |
jasnell
commented
May 25, 2016
Member
LGTM |
1 similar comment
addaleax
commented
May 26, 2016
Member
LGTM |
A Proxy context should not hide built-in global objects. Ref: nodejs#6158 PR-URL: nodejs#6967 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123 pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
A Proxy context should not hide built-in global objects. Ref: nodejs#6158 PR-URL: nodejs#6967 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
commented
Jul 11, 2016
Contributor
@targos lts? |
targos
commented
Jul 12, 2016
MemberAuthor
No. v4 doesn't have proxies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
vm
Description of change
This is a regression test for the issue #6158 that was fixed by #6928.