Uh oh!
There was an error while loading. Please reload this page.
benchmark: fix child-process-read on Windows - #6971
Closed
bzoz wants to merge 4 commits into
Closed
Conversation
bzozforce-pushed
the
Bartosz-ChildProcessBenchmarkFix
branch
from
May 25, 2016 14:37
ec91385 to
7402cc2CompareContributor
There was a problem hiding this comment.
Length is spelled wrong throughout this file.
Under Windows 'ipc' communication requires the other process to format its messages with 'IPC framing protocol'. Otherwise, an assert is triggered in libuv. This commit changes child-process-read benchmark to use stdout to communicate with parent process. It also adds child-process-read-ipc.js to benchmark IPC communication using child node process.
bzozforce-pushed
the
Bartosz-ChildProcessBenchmarkFix
branch
from
May 31, 2016 09:46
a96c1c6 to
4961a5dComparebzoz
commented
May 31, 2016
ContributorAuthor
I've corrected the spelling, PTAL |
joaocgreis
commented
Jun 3, 2016
Member
LGTM cc @nodejs/benchmarking |
| if (process.argv[2] === 'child') | ||
| { | ||
| const len = +process.argv[3]; | ||
| const msg = '"' + Array(len).join('.') + '"'; |
jasnell
commented
Jun 3, 2016
Member
LGTM with a nit |
bzoz
commented
Jun 6, 2016
ContributorAuthor
Updated, PTAL |
joaocgreis
commented
Jun 6, 2016
Member
Thanks @bzoz . Will land tomorrow if there are no further issues. |
joaocgreis pushed a commit
that referenced
this pull request
Jun 9, 2016
Under Windows 'ipc' communication requires the other process to format its messages with 'IPC framing protocol'. Otherwise, an assert is triggered in libuv. This commit changes child-process-read benchmark to use stdout to communicate with parent process. It also adds child-process-read-ipc.js to benchmark IPC communication using child node process. PR-URL: #6971 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
joaocgreis
commented
Jun 9, 2016
Member
CI: https://ci.nodejs.org/job/node-test-pull-request/2964/ (failures unrelated) Landed in cbbdc29 Thanks! |
evanlucas pushed a commit
that referenced
this pull request
Jun 16, 2016
Under Windows 'ipc' communication requires the other process to format its messages with 'IPC framing protocol'. Otherwise, an assert is triggered in libuv. This commit changes child-process-read benchmark to use stdout to communicate with parent process. It also adds child-process-read-ipc.js to benchmark IPC communication using child node process. PR-URL: #6971 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
benchmark
Description of change
Under Windows
ipccommunication requires the other process to format its messages with 'IPC framing protocol'. Otherwise, an assert is triggered in libuv. This commit changeschild-process-read.jsbenchmark to use stdout to communicate with parent process. It also addschild-process-read-ipc.jsto benchmark IPC communication using child node process.