Uh oh!
There was an error while loading. Please reload this page.
doc: use consistent typography in streams.md - #6986
Closed
Trott wants to merge 1 commit into
Closed
Conversation
addaleax
commented
May 26, 2016
Member
LGTM |
1 similar comment
eljefedelrodeodeljefe
commented
May 26, 2016
Contributor
LGTM |
jasnell
commented
May 26, 2016
Member
jasnell
commented
May 26, 2016
Member
Actually... double checking on this, I've already covered this in #6947 |
Trott
commented
May 27, 2016
MemberAuthor
I think you got all of them except for one, actually. But #6947 is already such a massive diff that invites lots of small comments, that I'm reluctant to bikeshed it. I'll wait for it to land and then see if anything remains to be done. If so, I'll update this PR. If not, I'll close this PR. |
jasnell
commented
Jun 6, 2016
Member
In prose, always surround `null`-as-a-value in backticks.
Trott
commented
Jun 6, 2016
MemberAuthor
Rebased and force-pushed. This now only affects one line of the doc. |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jun 7, 2016
In prose, always surround `null`-as-a-value in backticks. PR-URL: nodejs#6986 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Trott
commented
Jun 7, 2016
MemberAuthor
Landed in a78c233 |
evanlucas pushed a commit
that referenced
this pull request
Jun 15, 2016
In prose, always surround `null`-as-a-value in backticks. PR-URL: #6986 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
In prose, always surround
null-as-a-value in backticks.