Uh oh!
There was an error while loading. Please reload this page.
cluster: expose result of send() - #6998
Merged
Merged
Conversation
cjihrig
commented
May 26, 2016
ContributorAuthor
Kind of refs: nodejs/node-v0.x-archive#8746 |
jasnell
commented
May 26, 2016
Member
LGTM but semver-minor? |
cjihrig
commented
May 26, 2016
ContributorAuthor
Definitely not semver-minor. The publicly exposed use is already documented as returning a Boolean, even though it doesn't prior to this commit. I'd say semver patch. |
jasnell
commented
May 26, 2016
Member
Ok, works for me |
ronkorving
commented
May 27, 2016
Contributor
LGTM |
ContributorAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/2818/ EDIT: A few |
bnoordhuis
commented
May 28, 2016
Member
LGTM |
ContributorAuthor
CI again: https://ci.nodejs.org/job/node-test-pull-request/2841/ One more now that the CI seems healthy: https://ci.nodejs.org/job/node-test-pull-request/2873/ |
There are several places in the cluster module where a version of process.send() is called, but the result is swallowed. Most of these cases are internal, but Worker.prototype.send(), which is publicly documented, also suffers from this problem. This commit exposes the return value to facilitate better error handling, and bring Worker.prototype.send() into compliance with the documentation. PR-URL: nodejs#6998 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123 pushed a commit
that referenced
this pull request
Jun 1, 2016
There are several places in the cluster module where a version of process.send() is called, but the result is swallowed. Most of these cases are internal, but Worker.prototype.send(), which is publicly documented, also suffers from this problem. This commit exposes the return value to facilitate better error handling, and bring Worker.prototype.send() into compliance with the documentation. PR-URL: #6998 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit
that referenced
this pull request
Jun 2, 2016
There are several places in the cluster module where a version of process.send() is called, but the result is swallowed. Most of these cases are internal, but Worker.prototype.send(), which is publicly documented, also suffers from this problem. This commit exposes the return value to facilitate better error handling, and bring Worker.prototype.send() into compliance with the documentation. PR-URL: #6998 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
commented
Jul 11, 2016
Contributor
@cjihrig lts? |
cjihrig
commented
Jul 11, 2016
ContributorAuthor
Yes, please. The v4 documentation also says that a |
MylesBorins
commented
Jul 11, 2016
Contributor
Getting an error with this one |
cjihrig
commented
Jul 12, 2016
ContributorAuthor
Ah, looks like this depends on #3516, which appears to have been dropped from LTS consideration. |
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Jul 14, 2016
There are several places in the cluster module where a version of process.send() is called, but the result is swallowed. Most of these cases are internal, but Worker.prototype.send(), which is publicly documented, also suffers from this problem. This commit exposes the return value to facilitate better error handling, and bring Worker.prototype.send() into compliance with the documentation. PR-URL: nodejs#6998 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
cluster
Description of change
There are several places in the
clustermodule where a version ofprocess.send()is called, but the result is swallowed. Most of these cases are internal, butWorker.prototype.send(), which is publicly documented, also suffers from this problem. This commit exposes the return value to facilitate better error handling, and bringWorker.prototype.send()into compliance with the documentation.