Uh oh!
There was an error while loading. Please reload this page.
test: fix spurious EADDRINUSE in test-https-strict - #7024
Closed
Trott wants to merge 1 commit into
Closed
Conversation
test-https-strict sometimes fails with EADDRINUSE in CI. Remove use of common.PORT to make the test resistant from side effects from other tests that may have not freed up the port.
mscdex
commented
May 27, 2016
Contributor
addaleax
commented
May 27, 2016
Member
LGTM |
1 similar comment
cjihrig
commented
May 27, 2016
Contributor
LGTM |
Trott
commented
May 31, 2016
MemberAuthor
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jun 1, 2016
test-https-strict sometimes fails with EADDRINUSE in CI. Remove use of common.PORT to make the test resistant from side effects from other tests that may have not freed up the port. PR-URL: nodejs#7024 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott
commented
Jun 1, 2016
MemberAuthor
Landed in 2f417c3 |
Fishrock123 pushed a commit
that referenced
this pull request
Jun 1, 2016
test-https-strict sometimes fails with EADDRINUSE in CI. Remove use of common.PORT to make the test resistant from side effects from other tests that may have not freed up the port. PR-URL: #7024 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Jun 2, 2016
test-https-strict sometimes fails with EADDRINUSE in CI. Remove use of common.PORT to make the test resistant from side effects from other tests that may have not freed up the port. PR-URL: #7024 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
commented
Jul 11, 2016
Contributor
@Trott lts? |
Trott
commented
Jul 11, 2016
MemberAuthor
@thealphanerd If it lands cleanly, yes. |
MylesBorins
commented
Jul 14, 2016
Contributor
this is landing cleanly but causing failures. Didn't dig in, feel free to look into it rich. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test https
Description of change
test-https-strict sometimes fails with EADDRINUSE in CI. Remove use of
common.PORT to make the test resistant from side effects from other
tests that may have not freed up the port.
Example CI failure: https://ci.nodejs.org/job/node-test-commit-osx/3545/nodes=osx1010/console
/cc @nodejs/testing @mscdex