Skip to content

test: remove non-incremental common.PORT changes - #7055

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:say-no
Closed

test: remove non-incremental common.PORT changes#7055
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:say-no

Conversation

@Trott

@TrottTrott commented May 29, 2016•
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

Remove uses of common.PORT + 1337 where common.PORT suffices.

Refs: #6990

@Trott
test: remove non-incremental common.PORT changes
9122028
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.
Refs: nodejs#6990
@TrottTrott added debugger test Issues and PRs related to the tests. labels May 29, 2016
@bnoordhuis

bnoordhuis commented May 30, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@cjihrig

cjihrig commented May 30, 2016

Copy link
Copy Markdown
Contributor

LGTM

@Trott

Trott commented Jun 1, 2016

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/2894/

Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2016
@Trott
test: remove non-incremental common.PORT changes
85da963
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.
PR-URL: nodejs#7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: nodejs#6990
@Trott

Trott commented Jun 2, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in 85da963

@TrottTrott closed this Jun 2, 2016
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@Trott@rvagg
test: remove non-incremental common.PORT changes
8b720c4
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.
PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
@MylesBorinsMylesBorins mentioned this pull request Jul 11, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@TrottMyles Borins
test: remove non-incremental common.PORT changes
97e651d
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.
PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott@MylesBorins
test: remove non-incremental common.PORT changes
ef8cb6a
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.
PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@TrottMyles Borins
test: remove non-incremental common.PORT changes
ff9fedc
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.
PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@TrottMyles Borins
test: remove non-incremental common.PORT changes
6a85acc
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.
PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@TrottMyles Borins
test: remove non-incremental common.PORT changes
5b1f546
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.
PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
@Trott
Trott deleted the say-no branch January 13, 2022 22:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@bnoordhuis@cjihrig@MylesBorins