Skip to content

Backport for v4.x: win,build: add creation of zip and 7z package - #7075

Closed
joaocgreis wants to merge 1 commit into
nodejs:v4.x-stagingfrom
JaneaSystems:Bartosz-MakeWindowsZipPackage-4.x
Closed

Backport for v4.x: win,build: add creation of zip and 7z package#7075
joaocgreis wants to merge 1 commit into
nodejs:v4.x-stagingfrom
JaneaSystems:Bartosz-MakeWindowsZipPackage-4.x

Conversation

@joaocgreis

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

win, build

Description of change

@nodejs/lts

This is a backport of #5995. The commit applies almost cleanly (some context change), but I also want to start a test build and have a proper place for discussion.

Added the don't-land label to the original PR, please change if not appropriate.

I believe this should go into v4, but not sure about v0.12 and v0.10.

@joaocgreisjoaocgreis added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. lts-watch-v4.x lts Issues and PRs related to Long Term Support releases. labels May 31, 2016
@joaocgreis

Copy link
Copy Markdown
MemberAuthor

@rvagg

Copy link
Copy Markdown
Member

Let's leave 0.10 and 0.12 alone, we've tried to keep the dist directories fairly static and there's already some .pdb stuff in there anyway.

I'm fine with this for v4.x but would much rather wait till we've had a few releases of v6 to verify that we've got it sorted out first.

This looks like a straightforward backport without anything different from the original, is that correct @joaocgreis? If so, lgtm.

@joaocgreis

Copy link
Copy Markdown
MemberAuthor

This looks like a straightforward backport without anything different from the original

@rvagg that is correct.

I'm ok with waiting. This is ready to go in, but there's no reason to rush. I'll rebase and ping when there are a couple of releases of v6 out with this.

@MylesBorins

Copy link
Copy Markdown
Contributor

thanks @joaocgreis

@MylesBorins
MylesBorinsforce-pushed the v4.x-staging branch 3 times, most recently from ed3d372 to f14d9cfCompareJune 28, 2016 22:49
@MylesBorins

Copy link
Copy Markdown
Contributor

@joaocgreis looks like this needs a rebase

Add a step in vcbuild.bat to create a minimal package including node
and npm that can be used as an alternative to the MSI.
Compress the node.pdb file as zip and 7z.
All files are uploaded as part of build-release.
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
PR-URL: nodejs#5995Fixes: nodejs/build#299Fixes: nodejs#5696
@joaocgreis
joaocgreisforce-pushed the Bartosz-MakeWindowsZipPackage-4.x branch from 00b2963 to c21b63cCompareJuly 5, 2016 20:03
@joaocgreis

Copy link
Copy Markdown
MemberAuthor

Rebased. Should we start another test build?

@MylesBorins

Copy link
Copy Markdown
Contributor

@joaocgreis

Copy link
Copy Markdown
MemberAuthor

CI green, here is another test build: https://nodejs.org/download/test/v4.4.8-test20160707c21b63cbf0770fcf0b9e4a4fbe160d6eb87bfd3e/

@rvagg@thealphanerd LGTY? (and should I land this myself?)

@rvagg

rvagg commented Jul 7, 2016

Copy link
Copy Markdown
Member

lgtm pending an RC or test build

@MylesBorins

MylesBorins commented Jul 8, 2016

Copy link
Copy Markdown
Contributor

landed in b69bcaf

This will be included in the v4.5.0 rc's that will be put together soon

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.ltsIssues and PRs related to Long Term Support releases.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@joaocgreis@rvagg@MylesBorins@bzoz