Uh oh!
There was an error while loading. Please reload this page.
Backport for v4.x: win,build: add creation of zip and 7z package - #7075
Backport for v4.x: win,build: add creation of zip and 7z package#7075joaocgreis wants to merge 1 commit into
Conversation
joaocgreis
commented
May 31, 2016
CI: https://ci.nodejs.org/job/node-test-pull-request/2872/ |
rvagg
commented
May 31, 2016
Let's leave 0.10 and 0.12 alone, we've tried to keep the dist directories fairly static and there's already some .pdb stuff in there anyway. I'm fine with this for v4.x but would much rather wait till we've had a few releases of v6 to verify that we've got it sorted out first. This looks like a straightforward backport without anything different from the original, is that correct @joaocgreis? If so, lgtm. |
joaocgreis
commented
May 31, 2016
@rvagg that is correct. I'm ok with waiting. This is ready to go in, but there's no reason to rush. I'll rebase and ping when there are a couple of releases of v6 out with this. |
MylesBorins
commented
Jun 1, 2016
thanks @joaocgreis |
ed3d372 to
f14d9cfCompareMylesBorins
commented
Jul 5, 2016
@joaocgreis looks like this needs a rebase |
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: nodejs#5995Fixes: nodejs/build#299Fixes: nodejs#5696
00b2963 to
c21b63cComparejoaocgreis
commented
Jul 5, 2016
Rebased. Should we start another test build? |
MylesBorins
commented
Jul 5, 2016
joaocgreis
commented
Jul 7, 2016
CI green, here is another test build: https://nodejs.org/download/test/v4.4.8-test20160707c21b63cbf0770fcf0b9e4a4fbe160d6eb87bfd3e/ @rvagg@thealphanerd LGTY? (and should I land this myself?) |
rvagg
commented
Jul 7, 2016
lgtm pending an RC or test build |
landed in b69bcaf This will be included in the v4.5.0 rc's that will be put together soon |
Checklist
Affected core subsystem(s)
win, build
Description of change
@nodejs/lts
This is a backport of #5995. The commit applies almost cleanly (some context change), but I also want to start a test build and have a proper place for discussion.
Added the don't-land label to the original PR, please change if not appropriate.
I believe this should go into v4, but not sure about v0.12 and v0.10.