Uh oh!
There was an error while loading. Please reload this page.
src: fix --without-inspector build - #7078
Merged
Merged
Conversation
addaleax
commented
May 31, 2016
MemberAuthor
Regular CI: https://ci.nodejs.org/job/node-test-commit/3598/ |
cjihrig
commented
May 31, 2016
Contributor
LGTM |
mhdawson
commented
May 31, 2016
Member
LGTM, allowed me to compile AIX with --without-inspector |
Use `HAVE_INSPECTOR` as the 0/1 boolean macro that it is, as opposed to a defined/not-defined boolean. PR-URL: nodejs#7078 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleaxforce-pushed
the
fix-without-inspector-build
branch
from
June 1, 2016 18:27
6cfc1a7 to
3e7c5bcCompareFishrock123 pushed a commit
that referenced
this pull request
Jul 5, 2016
Use `HAVE_INSPECTOR` as the 0/1 boolean macro that it is, as opposed to a defined/not-defined boolean. PR-URL: #7078 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
src
Description of change
Use
HAVE_INSPECTORas the 0/1 boolean macro that it is, as opposed to a defined/not-defined boolean.