[WIP] build: use productbuild to build .pkg files

[evanlucas]

Checklist

• the commit message follows commit guidelines

Affected core subsystem(s)

build

Description of change

Switch from using PackageMaker to productbuild/pkgbuild for building .pkg files for releases on darwin.

I just wanted to open this as a possible alternative to #2571

[MylesBorins]

yessss!!!!

[MylesBorins]

awesome! +1

Let me know if there is anything I can do to help

[rvagg]

what's the WIP part of this @evanlucas? is there more to be done or can we churn out some test builds to see how it goes?

[evanlucas]

I'm still working on various cases with this. (what happens if node is not installed, what happens if it is installed, etc)

I mainly opened it to see if this was a route that anyone else would be willing to explore or not. It supports translations out of the box, which I thought was a plus as well. At this point, I have not tested it thoroughly, so I am still working through that. I also was trying to come up with a way of actually testing this as well.

[rvagg]

+1 for anything that makes progress, the last attempt was about (1) a newer .pkg making tool cause PackageMaker is ancient and no longer supported and (2) intl, but the last hangup was the scripting and having npm as a separate option. I was going to revisit it after having played with this recently for a separate project where I learnt quite a bit more about using Packages for this but I'm more than happy to have someone else take this bull by the horns and do what it takes.

[evanlucas]

So digging more into this, there are some cases where I can't seem to make the preinstall script for npm work properly. If /usr/local is owned by root, the preinstall script fails. I'll keep trying to figure out what is going on

[rvagg]

So does this run the .pkg as the current user? The current installer and the Packages one prompts for a password to run it all as root, or is this a general package processing concern?

[MylesBorins]

fwiw I had some serious issue getting the rm -rf /usr/local/lib/node_modules/npm to work as a pre script with the current installer while I was toying around with it.

[evanlucas]

It still runs the pkg as root, but for some reason fails when trying to remove the npm directory. The problem is pretty weird considering it installs everything as root

[evanlucas]

Still haven't been able to get this working properly. Closing for now

[rvagg]

aw, don't give up so easily!

[MylesBorins]

@evanlucas what exactly were the problems you ran into? Was it running the first script as root?

[evanlucas]

the preinstall script would fail if /usr/local is not owned by the user installing it