Uh oh!
There was an error while loading. Please reload this page.
cluster: don't send messages if no IPC channel - #7132
Merged
Conversation
santigimeno
commented
Jun 3, 2016
MemberAuthor
jasnell
commented
Jun 3, 2016
Member
LGTM |
Contributor
There was a problem hiding this comment.
The diff would be a little less noisy if you did:
if(!proc.connected)returnfalse;cjihrig
commented
Jun 3, 2016
Contributor
LGTM, I just hope there aren't scenarios I'm not thinking of where this could swallow valid errors. |
santigimenoforce-pushed
the
cluster_process_disconnect
branch
from
June 5, 2016 09:23
f54ce27 to
6e838e9Comparesantigimeno
commented
Jun 5, 2016
MemberAuthor
Updated. Thanks! |
santigimeno
commented
Jun 5, 2016
MemberAuthor
santigimenoforce-pushed
the
cluster_process_disconnect
branch
2 times, most recently
from
June 8, 2016 12:48
381d514 to
de6ff56Comparesantigimeno
commented
Jun 8, 2016
MemberAuthor
Rebased to current master. One last CI run: https://ci.nodejs.org/job/node-test-pull-request/2957/ |
santigimeno
commented
Jun 8, 2016
MemberAuthor
All is green. Landing |
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: nodejs#7132 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
santigimenoforce-pushed
the
cluster_process_disconnect
branch
from
June 8, 2016 13:51
de6ff56 to
8c53d2fComparesantigimeno
commented
Jun 8, 2016
MemberAuthor
Landed in 8c53d2f. Thanks! |
evanlucas pushed a commit
that referenced
this pull request
Jun 16, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
commented
Jul 11, 2016
Contributor
@santigimeno lts? |
santigimeno
commented
Jul 12, 2016
MemberAuthor
@thealphanerd Yes, I would think so. |
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
Avoid sending messages if the IPC channel is already disconnected. It avoids undesired errors when calling `process.disconnect` when there are still pending IPC messages. PR-URL: #7132 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
cluster
Description of change
Avoid sending messages if the IPC channel is already disconnected.
It avoids undesired errors when calling
process.disconnectwhen thereare still pending IPC messages.
/cc @cjihrig@bnoordhuis