Uh oh!
There was an error while loading. Please reload this page.
src: clean up string_search - #7174
Merged
Merged
Conversation
mscdex
commented
Jun 6, 2016
ContributorAuthor
thefourtheye
commented
Jun 6, 2016
Contributor
LGTM if CI is green. |
bnoordhuis
commented
Jun 6, 2016
Member
LGTM |
3 similar comments
addaleax
commented
Jun 6, 2016
Member
LGTM |
cjihrig
commented
Jun 6, 2016
Contributor
LGTM |
jasnell
commented
Jun 6, 2016
Member
LGTM |
This commit removes some unnecessary signed checks on unsigned variables and removes a few unused private functions. PR-URL: nodejs#7174 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit
that referenced
this pull request
Jun 16, 2016
This commit removes some unnecessary signed checks on unsigned variables and removes a few unused private functions. PR-URL: #7174 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
commented
Jul 11, 2016
Contributor
@mscdex lts? |
ContributorAuthor
@thealphanerd Yeah I believe it should be safe enough. |
MylesBorins
commented
Jul 11, 2016
Contributor
@mscdex it unfortunately doesn't land cleanly. Would you be willing to backport? |
mscdex added a commit
to mscdex/io.js
that referenced
this pull request
Jul 12, 2016
This commit removes some unnecessary signed checks on unsigned variables. PR-URL: nodejs#7174 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
This commit removes some unnecessary signed checks on unsigned variables. PR-URL: #7174 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
This commit removes some unnecessary signed checks on unsigned variables. PR-URL: #7174 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
This commit removes some unnecessary signed checks on unsigned variables. PR-URL: #7174 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
This commit removes some unnecessary signed checks on unsigned variables and removes a few unused private functions.