Uh oh!
There was an error while loading. Please reload this page.
test: skip doctool tests when js-yaml is missing - #7218
Merged
addaleax merged 1 commit intoJul 6, 2016
Conversation
silverwind
commented
Jun 8, 2016
Contributor
LGTM, but we should eventually find a solution. What's js-yaml used for, by the way? Just the "added" comments? |
addaleax
commented
Jun 8, 2016
MemberAuthor
2 tasks
Fishrock123
commented
Jun 24, 2016
Contributor
Hmmm, when will this be skipped? Only from the tarball, not on the CI? |
addaleax
commented
Jun 24, 2016
MemberAuthor
@Fishrock123 yes, only the tarball. There’s also #7290 that addresses the same problem by actually adding the dependencies, and I don’t have any too strong feelings, which is why I didn’t merge this yet. |
Fishrock123
commented
Jun 24, 2016
Contributor
I personally prefer this approach. |
addaleax
commented
Jul 5, 2016
MemberAuthor
@thefourtheye Would you mind if I landed this? That doesn’t need to be the end of discussion, but it might be nice to have |
thefourtheye
commented
Jul 6, 2016
Contributor
No problem. Working tarball is important. LGTM. |
Skip the doctool tests when js-yaml, which is currently `require()`d from the eslint source tree, is missing. This can happen, for example, because eslint is not included in the release source tarballs. Fixes: nodejs#7201 Ref: nodejs#6495 PR-URL: nodejs#7218 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleaxforce-pushed
the
skip-doctool-tests-without-eslint
branch
from
July 6, 2016 10:41
77f3034 to
af273b5Compareaddaleax
commented
Jul 6, 2016
MemberAuthor
rebased, CI again just to be sure: https://ci.nodejs.org/job/node-test-commit/3991/ |
MylesBorins
commented
Jul 12, 2016
Contributor
@addaleax lts? If so can you backport? Not landing cleanly (thanks for being so responsive today!) |
evanlucas pushed a commit
that referenced
this pull request
Jul 12, 2016
Skip the doctool tests when js-yaml, which is currently `require()`d from the eslint source tree, is missing. This can happen, for example, because eslint is not included in the release source tarballs. Fixes: #7201 Ref: #6495 PR-URL: #7218 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax added a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
Skip the doctool tests when js-yaml, which is currently `require()`d from the eslint source tree, is missing. This can happen, for example, because eslint is not included in the release source tarballs. Fixes: nodejs#7201 Ref: nodejs#6495 PR-URL: nodejs#7218 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Skip the doctool tests when js-yaml, which is currently `require()`d from the eslint source tree, is missing. This can happen, for example, because eslint is not included in the release source tarballs. Fixes: #7201 Ref: #6495 PR-URL: #7218 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Skip the doctool tests when js-yaml, which is currently `require()`d from the eslint source tree, is missing. This can happen, for example, because eslint is not included in the release source tarballs. Fixes: #7201 Ref: #6495 PR-URL: #7218 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
Skip the doctool tests when js-yaml, which is currently `require()`d from the eslint source tree, is missing. This can happen, for example, because eslint is not included in the release source tarballs. Fixes: #7201 Ref: #6495 PR-URL: #7218 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
Skip the doctool tests when js-yaml, which is currently `require()`d from the eslint source tree, is missing. This can happen, for example, because eslint is not included in the release source tarballs. Fixes: #7201 Ref: #6495 PR-URL: #7218 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Skip the doctool tests when js-yaml, which is currently
require()d from the eslint source tree, is missing. This can happen, for example, because eslint is not included in the release source tarballs.Fixes: #7201
Ref (introduced in): #6495
CI: https://ci.nodejs.org/job/node-test-commit/3692/