url: return valid file: urls fom url.format() by Trott · Pull Request #7234 · nodejs/node

Trott · 2016-06-08T21:30:38Z

Checklist

make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
a test and/or benchmark is included
the commit message follows commit guidelines

Affected core subsystem(s)

url

Description of change

file: URLs that do not start with file:// are invalid. Browsers convert file:/etc/passwd to file:///etc/passwd. This is also what the docs indicate we are doing, but we're not.

Labeling semver-major because tests have to be updated for it.

Fixes: #3361

jasnell · 2016-06-08T22:46:50Z

@mscdex

mscdex · 2016-06-08T23:19:17Z

minor nit: last time i checked template strings had noticeable overhead, may need to check again on master now.

Changed to string concatenation.

`file:` URLs that do not start with `file://` are invalid. Browsers convert `file:/etc/passwd` to `file:///etc/passwd`. This is also what the docs indicate we are doing, but we're not. Fixes: nodejs#3361

Trott · 2016-06-10T05:18:16Z

/cc @silverwind @claudiorodriguez (who had substantial comments on the issue this tries to address)

Trott · 2016-06-10T05:21:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/2968/

silverwind · 2016-06-10T05:29:38Z

LGTM if CI passes.

Trott · 2016-06-10T05:39:13Z

I guess since it's semver-major and our docs say that semver-major changes need to be reviewed in some fashion by CTC: @nodejs/ctc

Trott · 2016-06-10T05:59:10Z

Couple of unrelated-seeming issues on that first CI run. Here's a second one: https://ci.nodejs.org/job/node-test-commit/3707/

mscdex · 2016-06-10T11:30:27Z

LGTM

Trott · 2016-06-10T21:57:25Z

@jasnell This would seem to be orthogonal to nodejs/node-eps#28 but uh, just in case, care to review?

indutny · 2016-06-11T02:54:29Z

+ pathname = '/' + pathname;
+ host = '//' + host;
+ } else if (protocol.length >= 4 &&
+ protocol.charCodeAt(0) === 102/*f*/ &&


Nitpick: why not 0x.. instead?

@indutny I used decimal because:
It's decimal in most of the existing charCodeAt() calls, including ~10 lines later in lines 621 and 622, as well as the switch statement ~30 lines earlier starting on line 581.
The sample code (provided by @mscdex) used decimal and I did a lazy copy/paste.
I don't feel strongly about it, though, and I'm happy to change it to hex format if that's the difference between a quick LGTM and a not-sure-about-this.

Trott · 2016-06-13T23:01:13Z

Trying to get more eyes on this... @nodejs/collaborators

Trott · 2016-06-14T21:04:40Z

Adding ctc-agenda to give CTC a concrete opportunity to stop this from landing if someone has concerns. I think it's pretty mild as semver-major changes go, but a breaking change is a breaking change...

ChALkeR · 2016-06-15T20:22:50Z

For anyone here wondering what whatwg-url spec does, ref: https://url.spec.whatwg.org/#url-serializing.

It always starts file: urls with file://.

rvagg · 2016-06-15T20:24:47Z

no objections from ctc

`file:` URLs that do not start with `file://` are invalid. Browsers convert `file:/etc/passwd` to `file:///etc/passwd`. This is also what the docs indicate we are doing, but we're not. PR-URL: nodejs#7234Fixes: nodejs#3361 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Brian White <mscdex@mscdex.net>

Trott · 2016-06-16T20:40:41Z

Landed in 336b027

Trott added url Issues and PRs related to the legacy built-in url module. semver-major PRs that contain breaking changes and should be released in the next major version. labels Jun 8, 2016

mscdex reviewed Jun 8, 2016
View reviewed changes

Trott mentioned this pull request Jun 9, 2016
benchmark: add benchmark for url.format() #7250
Closed
3 tasks

Trott force-pushed the fileslashslash branch from a4204b3 to 4e8c661Compare June 9, 2016 18:43

Trott added 3 commits June 9, 2016 11:44

url: return valid file: urls fom url.format()
4e8c661
`file:` URLs that do not start with `file://` are invalid. Browsers convert `file:/etc/passwd` to `file:///etc/passwd`. This is also what the docs indicate we are doing, but we're not. Fixes: nodejs#3361

squash: use string concatenation instead of template
99f87da

squash: startsWith() -> charCodeAt()
4c9f18c

indutny reviewed Jun 11, 2016
View reviewed changes

Trott added the ctc-agenda label Jun 14, 2016

rvagg mentioned this pull request Jun 15, 2016
Node.js Foundation Core Technical Committee (CTC) Meeting 2016-06-15 #7307
Closed

rvagg removed the ctc-agenda label Jun 15, 2016

Trott added this to the 7.0.0 milestone Jun 15, 2016

Trott closed this Jun 16, 2016

iarna mentioned this pull request Nov 8, 2016
Changes to file: URL formatting in Node v7 cause problems for npm #9521
Closed

avgaltsev mentioned this pull request Mar 21, 2017
url.format() slashes fix mailru/jam#30
Closed

gibfahn mentioned this pull request Jun 15, 2017
Auditing for 6.11.1 nodejs/Release#230
Closed
3 tasks

Trott deleted the fileslashslash branch January 13, 2022 22:43

Uh oh!

Uh oh!

Conversation

Trott commented Jun 8, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

jasnell commented Jun 8, 2016

Uh oh!

mscdexJun 8, 2016

Choose a reason for hiding this comment

Uh oh!

TrottJun 9, 2016

Choose a reason for hiding this comment

Uh oh!

Trott commented Jun 10, 2016

Uh oh!

Trott commented Jun 10, 2016

Uh oh!

silverwind commented Jun 10, 2016

Uh oh!

Trott commented Jun 10, 2016

Uh oh!

Trott commented Jun 10, 2016

Uh oh!

mscdex commented Jun 10, 2016

Uh oh!

Trott commented Jun 10, 2016

Uh oh!

indutnyJun 11, 2016

Choose a reason for hiding this comment

Uh oh!

TrottJun 13, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Trott commented Jun 13, 2016

Uh oh!

Trott commented Jun 14, 2016

Uh oh!

ChALkeR commented Jun 15, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rvagg commented Jun 15, 2016

Uh oh!

Trott commented Jun 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

TrottJun 13, 2016•
edited
Loading

ChALkeR commented Jun 15, 2016•
edited
Loading