Uh oh!
There was an error while loading. Please reload this page.
doc: make pull request template more concise - #7239
Closed
Trott wants to merge 1 commit into
Closed
Conversation
jasnell
commented
Jun 9, 2016
Member
Automatic rubber stamp LGTM |
benjamingr
commented
Jun 9, 2016
Member
LGTM |
3 similar comments
targos
commented
Jun 9, 2016
Member
LGTM |
mscdex
commented
Jun 9, 2016
Contributor
LGTM |
cjihrig
commented
Jun 9, 2016
Contributor
LGTM |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jun 11, 2016
PR-URL: nodejs#7239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Trott
commented
Jun 11, 2016
MemberAuthor
Landed in 47b9b14 |
evanlucas pushed a commit
that referenced
this pull request
Jun 16, 2016
PR-URL: #7239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc meta
Description of change