Skip to content

zlib: release callback and buffer after processing - #7251

Closed
mdlavin wants to merge 1 commit into
nodejs:v4.x-stagingfrom
mdlavin:v4.x-backport-zlib-leak-fix
Closed

zlib: release callback and buffer after processing#7251
mdlavin wants to merge 1 commit into
nodejs:v4.x-stagingfrom
mdlavin:v4.x-backport-zlib-leak-fix

Conversation

@mdlavin

Copy link
Copy Markdown
Contributor

Backport request for PR #6955

@nodejs-github-botnodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Jun 9, 2016
@MylesBorins
MylesBorinsforce-pushed the v4.x-staging branch 2 times, most recently from 6b010a9 to 17a41c6CompareJune 24, 2016 00:29
@Fishrock123

Copy link
Copy Markdown
Contributor

@mdlavin Looks like you have a rebase wrong.

@mdlavin

Copy link
Copy Markdown
ContributorAuthor

It looks like maybe somebody force pushed to the v4-staging branch in the nodejs project? When I fetched the latest changes into my local repo, I saw this:

No matter what happened, I'll rebased my changes on the new branch. Sorry for the trouble

@mdlavin
mdlavinforce-pushed the v4.x-backport-zlib-leak-fix branch from 62967d5 to 4854d33CompareJune 24, 2016 12:56
@addaleax

Copy link
Copy Markdown
Member

Yep, force pushes to v4.x-staging are pretty normal. Thanks for rebasing anyway!

PR-URL: nodejs#6955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuval Brik <yuval@brik.org.il>
@mdlavin
mdlavinforce-pushed the v4.x-backport-zlib-leak-fix branch from 4854d33 to 0df363eCompareJune 30, 2016 15:16
@mdlavin

Copy link
Copy Markdown
ContributorAuthor

I rebased on the updated v4.x-staging branch again after the v4.4.7 release

@MylesBorins

Copy link
Copy Markdown
Contributor

landed in 395f4be

@MylesBorins

Copy link
Copy Markdown
Contributor

@mdlavin in future we can add the lts-watch tag to a PR and assign me to backport if it lands cleanly and doesn't require modifications.

Thanks for putting the work in for this!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

zlibIssues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mdlavin@Fishrock123@addaleax@MylesBorins@nodejs-github-bot