Uh oh!
There was an error while loading. Please reload this page.
Speedup canned small-icu build - #7254
Closed
srl295 wants to merge 1 commit into
Closed
Conversation
When: * using canned, small-icu (the default for configure && make) * .. on little endian systems we can avoid building some things we're currently building. Namely, on the host toolchain side in this scenario, only genccode needs to be compiled, and it doesn't need the i18n or io libraries Fixes: nodejs#7253
MemberAuthor
Started a CI build. ^ May need to re-include some stuff when cross-compiling. |
jasnell
commented
Aug 9, 2016
Member
@srl295 ... what's the status on this? |
rvaggforce-pushed
the
master
branch
2 times, most recently
from
October 18, 2016 17:02
c133999 to
83c7a88Comparejasnell
commented
Mar 1, 2017
Member
ping @srl295 ... does this need to stay open? |
srl295
commented
Mar 1, 2017
via email
MemberAuthor
Probably not. I think enough has changed. |
fhinkel
commented
May 26, 2017
Member
Ok, thanks @srl295 . Closing this. |
refack
commented
May 30, 2017
Contributor
2 tasks
srl295
commented
Aug 30, 2017
MemberAuthor
@refack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) andvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
When:
we can avoid building some things we're currently building.
Namely, on the host toolchain side in this scenario, only genccode needs to be compiled,
and it doesn't need the i18n or io libraries
Fixes: #7253