Skip to content

Speedup canned small-icu build - #7254

Closed
srl295 wants to merge 1 commit into
nodejs:masterfrom
srl295:speedup-small
Closed

Speedup canned small-icu build#7254
srl295 wants to merge 1 commit into
nodejs:masterfrom
srl295:speedup-small

Conversation

@srl295

@srl295srl295 commented Jun 10, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX) and
  • vcbuild test nosign (Windows) passes
  • test on big endian
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

When:

  • using canned, small-icu (the default for configure && make)
  • .. on little endian systems

we can avoid building some things we're currently building.

Namely, on the host toolchain side in this scenario, only genccode needs to be compiled,
and it doesn't need the i18n or io libraries

Fixes: #7253

When:
* using canned, small-icu (the default for configure && make)
* .. on little endian systems
we can avoid building some things we're currently building.
Namely, on the host toolchain side in this scenario, only genccode needs to be compiled,
and it doesn't need the i18n or io libraries
Fixes: nodejs#7253
@mscdexmscdex added i18n-api Issues and PRs related to the i18n implementation. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Jun 10, 2016
@srl295srl295 self-assigned this Jun 10, 2016
@srl295

srl295 commented Jun 10, 2016

Copy link
Copy Markdown
MemberAuthor

Started a CI build.

i18n.cc:(.text._ZN2v88internal12_GLOBAL__N_117CreateICUCollatorEPNS0_7IsolateERKN6icu_576LocaleENS0_6HandleINS0_8JSObjectEEE+0x2c): undefined reference to `icu_57::Collator::createInstance(icu_57::Locale const&, UErrorCode&)'
collect2: error: ld returned 1 exit status
make[1]: *** [/home/iojs/build/workspace/node-cross-compile/label/cc-armv6/out/Release/mksnapshot] Error 1

^ May need to re-include some stuff when cross-compiling.

@jasnell

Copy link
Copy Markdown
Member

@srl295 ... what's the status on this?

@jasnell

Copy link
Copy Markdown
Member

ping @srl295 ... does this need to stay open?

@jasnelljasnell added the stalled Issues and PRs that are stalled. label Mar 1, 2017
@srl295

srl295 commented Mar 1, 2017 via email

Copy link
Copy Markdown
MemberAuthor

@fhinkel

Copy link
Copy Markdown
Member

Ok, thanks @srl295 . Closing this.

@fhinkelfhinkel closed this May 26, 2017
@refack

Copy link
Copy Markdown
Contributor

Cross-Ref: #12218
@srl295 is the icutrim.py patch an import from a different repo?

@srl295

Copy link
Copy Markdown
MemberAuthor

@refackicutrim.py is in a branch in ICU. but I have never landed it there.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.i18n-apiIssues and PRs related to the i18n implementation.stalledIssues and PRs that are stalled.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

speed up canned small-icu build

5 participants

@srl295@jasnell@fhinkel@refack@mscdex