Uh oh!
There was an error while loading. Please reload this page.
src: alias BINARY to LATIN1 - #7284
Merged
Merged
Conversation
thefourtheye
commented
Jun 13, 2016
Contributor
LGTM. We are redefining |
bnoordhuis
commented
Jun 13, 2016
MemberAuthor
|
cjihrig
commented
Jun 13, 2016
Contributor
LGTM |
1 similar comment
addaleax
commented
Jun 13, 2016
Member
LGTM |
Merged
Fishrock123
commented
Jun 17, 2016
Contributor
Needs to land for #7323 |
4 tasks
bnoordhuis
commented
Jun 17, 2016
MemberAuthor
This shouldn't land in any of the release lines. I've added the tags. |
bnoordhuis
commented
Jun 17, 2016
MemberAuthor
New CI, previous one seems to have been cancelled: https://ci.nodejs.org/job/node-test-pull-request/3013/ |
cjihrig
commented
Jun 17, 2016
Contributor
CI was good minus a seemingly unrelated failure. |
Make BINARY an alias for LATIN1 rather than a distinct enum value. PR-URL: nodejs#7284 Refs: nodejs#7262 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
bnoordhuisforce-pushed
the
alias-binary-to-latin1
branch
from
June 19, 2016 07:29
7b40780 to
a92089bCompareaddaleax pushed a commit
to addaleax/node
that referenced
this pull request
Aug 8, 2016
Make BINARY an alias for LATIN1 rather than a distinct enum value. PR-URL: nodejs#7284 Refs: nodejs#7262 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make BINARY an alias for LATIN1 rather than a distinct enum value.
Refs: #7262
CI: https://ci.nodejs.org/job/node-test-pull-request/2993/