Skip to content

doc: Fs access doc clarity v6x - #7321

Closed
lance wants to merge 2 commits into
nodejs:v6.xfrom
lance:fs-access-doc-clarity-v6x
Closed

doc: Fs access doc clarity v6x#7321
lance wants to merge 2 commits into
nodejs:v6.xfrom
lance:fs-access-doc-clarity-v6x

Conversation

@lance

@lancelance commented Jun 16, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Port doc/fs/api.md documentation changes to the v6.x branch. This change includes @jasnell's recent documentation changes regarding fs.constants. It is not clear to me if these changes should be included in the PR or not. If not, let me know and I'll update the PR.

Cherry picked from d976d66

Ref: #7113

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 16, 2016
@lancelance mentioned this pull request Jun 16, 2016
Closed
2 tasks
@mscdexmscdex added fs Issues and PRs related to the fs subsystem / file system. v6.x labels Jun 16, 2016
@jasnell

jasnell commented Jun 20, 2016

Copy link
Copy Markdown
Member

The changes to constants have not yet landed in v6 so those doc changes should not be carried over yet.

@lance
doc: Remove FS Constants the docs for v6x.
cd2ae82
These changes should not have been carried over from master.
@jasnell

jasnell commented Jun 20, 2016

Copy link
Copy Markdown
Member

LGTM

2 similar comments
@thefourtheye

thefourtheye commented Jun 21, 2016

Copy link
Copy Markdown
Contributor

LGTM

@cjihrig

cjihrig commented Jun 21, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Jun 21, 2016
@lance@jasnell
doc: clarify fs.access works on directories too.
1e7a7be
Cherry picked from d976d66
PR-URL: #7321
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

jasnell commented Jun 21, 2016

Copy link
Copy Markdown
Member

Landed in 1e7a7be

@jasnelljasnell closed this Jun 21, 2016
@Fishrock123Fishrock123 mentioned this pull request Jun 27, 2016
Merged
@Fishrock123Fishrock123 mentioned this pull request Jul 5, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lance@jasnell@thefourtheye@cjihrig@mscdex@MylesBorins@nodejs-github-bot