Uh oh!
There was an error while loading. Please reload this page.
test: mark test-vm-timeout flaky on windows - #7359
Closed
Trott wants to merge 1 commit into
Closed
Conversation
mscdex
commented
Jun 22, 2016
Contributor
LGTM |
Trott
commented
Jun 22, 2016
MemberAuthor
santigimeno
commented
Jun 22, 2016
Member
Looks like it didn't work: https://ci.nodejs.org/job/node-test-binary-windows/RUN_SUBSET=3,VS_VERSION=vs2015,label=win10/2579/console |
joaocgreis
commented
Jun 22, 2016
Member
LGTM @santigimeno the half-transparent circles (green,red,...) are links to jobs that were run before but not on that specific job. Two days ago I had run a job on all possible windows combinations, but was not able to delete it after, and your link points to it. (I was able to delete it today using another method) |
santigimeno
commented
Jun 22, 2016
Member
@joaocgreis sorry, I didn't know that. Thanks for pointing that out. LGTM then. |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jun 22, 2016
PR-URL: nodejs#7359 Refs: nodejs#6727 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Trott
commented
Jun 22, 2016
MemberAuthor
Landed in f34caa9 |
3 tasks
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test vm
Description of change
Refs: #6727
/cc @nodejs/testing