Uh oh!
There was an error while loading. Please reload this page.
deps: update v8_inspector - #7385
Closed
targos wants to merge 1 commit into
Closed
Conversation
Pick up latest commit of v8_inspector and inspector_protocol. This brings back compatibility with V8 5.1.
cjihrig
commented
Jun 23, 2016
Contributor
LGTM |
mscdex
commented
Jun 23, 2016
Contributor
Some questions/notes:
|
MemberAuthor
|
ofrobots
commented
Jun 23, 2016
Contributor
|
evanlucas
commented
Jun 25, 2016
Contributor
@mscdex I marked it dont-land-on-v6.x because the original pr has not landed on v6.x and it makes it easier to reason about commits to cherry-pick for releases. That being said, I am pushing for the next v6.x release to include it and would then remove the label. |
ofrobots
commented
Jun 27, 2016
Contributor
targos
commented
Jun 27, 2016
MemberAuthor
@ofrobots thanks. Maybe you could help with https://codereview.chromium.org/2084343002/. The buildbot didn't use the email address I want. |
targos
commented
Jun 28, 2016
MemberAuthor
landed in ecd639a |
targos added a commit
that referenced
this pull request
Jun 28, 2016
Pick up latest commit of v8_inspector and inspector_protocol. This brings back compatibility with V8 5.1. PR-URL: #7385 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Fishrock123 pushed a commit
that referenced
this pull request
Jul 5, 2016
Pick up latest commit of v8_inspector and inspector_protocol. This brings back compatibility with V8 5.1. PR-URL: #7385 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesDescription of change
Pick up latest commit of v8_inspector and inspector_protocol.
This brings back compatibility with V8 5.1.
R= @ofrobots