Uh oh!
There was an error while loading. Please reload this page.
build: add v8 requirement to test-v8* in Makefile - #7482
Closed
targos wants to merge 2 commits into
Closed
Conversation
The test targets expect that V8 is built in deps/v8/out Ref: nodejs#7477
MylesBorins
commented
Jun 29, 2016
Contributor
I was just about to submit this, testing locally. LGTM |
Without this it would always compile Release and Debug builds.
targos
commented
Jun 30, 2016
MemberAuthor
I added a second commit to use the BUILDTYPE variable in cc @exinfinitum who can maybe explain why it was done differently. |
jasnell
commented
Jun 30, 2016
Member
LGTM |
targos
commented
Jul 8, 2016
MemberAuthor
@thealphanerd LGTY with the second commit ? |
MylesBorins
commented
Jul 8, 2016
Contributor
@targos what is the build type variable used for? |
targos
commented
Jul 8, 2016
MemberAuthor
If we don't specify the build type, both Release and Debug builds will be compiled (you can see it here). |
MylesBorins
commented
Jul 8, 2016
Contributor
LGTM |
targos added a commit
to targos/node
that referenced
this pull request
Jul 10, 2016
The test targets expect that V8 is built in deps/v8/out Ref: nodejs#7477 PR-URL: nodejs#7482 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit
to targos/node
that referenced
this pull request
Jul 10, 2016
Without this it would always compile Release and Debug builds. Ref: nodejs#7477 PR-URL: nodejs#7482 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
commented
Jul 10, 2016
MemberAuthor
MylesBorins
commented
Jul 11, 2016
Contributor
@targos this is not landing cleanly on v4.x would you be willing to backport |
MemberAuthor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
build
Description of change
The test targets expect that V8 is built in deps/v8/out
Ref: #7477