Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem quite right?
I'm pretty sure Isaac added these but that wasn't at the start I think...
The oldest reference I seem to be able to find of it exposed on the global (actually
GLOBALat the time) is 7a2e784 (v0.1.16)hmmm, Indeed it looks like the original was added before v0.0.1 but I'm not sure it was exposed in a way that uh, counts?
.. also note that (awkwardly) these were actually added to the timers module pretty long after they were available on the global object. They were added to the module in 7994400 (v0.3.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was present on the global before; the JS entry point (
src/node.js) is executed without the function wrapper, so the functions defined there became part of the global scope.If you prefer, I can go for the version in which they were added to the
timersmodule, but that’s not the common usage pattern (not that it really matters too much for this old stuff anyway).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¯_(ツ)_/¯