test: handle SmartOS bug in test-tls-session-cache

[Trott]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test tls

Description of change

Sometimes, a SmartOS bug results in ECONNREFUSED when trying to connect
to the TLS server that the test starts. Retry in that situation.

Fixes: #5111
Refs: https://smartos.org/bugview/OS-2767

[Trott]

/cc @nodejs/testing

[Trott]

Stress test so-far showing (and hopefully will continue to show) that this version of the test is robust: https://ci.nodejs.org/job/node-stress-single-test/768/nodes=smartos14-64/console

Stress test showing the version on master branch is flaky: https://ci.nodejs.org/job/node-stress-single-test/767/nodes=smartos14-64/console

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/3148/

[Trott]

Stress test failed but now at a later part of the test, I think...

[Trott]

Rebased, force pushed, changed test to decrement a counter on failure, and trying stress test again:
https://ci.nodejs.org/job/node-stress-single-test/769/nodes=smartos14-64/console

[Trott]

That wasn't quite the right fix. Let's try again:

https://ci.nodejs.org/job/node-stress-single-test/775/nodes=smartos14-64/console

[Trott]

Hooray, that seems to have fixed it. PTAL @nodejs/testing

[santigimeno]

LGTM. One (maybe evident) question though: how is that the process.exit is emitted twice?

[Trott]

@santigimenoexit is being emitted on process only once, but there are two listeners. The process.on('exit', ...) gets run twice because it's inside doTest() which is called twice. So, the listener gets added twice. It's behavior depends on testOptions which is scoped to doTest() so it will have different values (and therefore the listeners will behave differently) even though they are both being triggered by the same event.

[santigimeno]

Oh. It was pretty obvious in hindsight. Thanks for the explanation @Trott

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/3164/

[Trott]

One build issue on CI but no issues with this test.

[Trott]

Landed in fb4c022

[MylesBorins]

@Trott lts?

[Trott]

@thealphanerd Yes if it lands cleanly.

[MylesBorins]

does not land cleanly 😢