Skip to content

backport 4747, rename .markdown - #7507

Closed
eljefedelrodeodeljefe wants to merge 1 commit into
nodejs:v4.x-stagingfrom
eljefedelrodeodeljefe:backport/4747
Closed

backport 4747, rename .markdown#7507
eljefedelrodeodeljefe wants to merge 1 commit into
nodejs:v4.x-stagingfrom
eljefedelrodeodeljefe:backport/4747

Conversation

@eljefedelrodeodeljefe

Copy link
Copy Markdown
Contributor

Original commit:
0800c0a

doc: git mv to .md
* doc: rename .markdown references in content
* doc: rename to .md in tools
* doc: rename to .md in CONTRIBUTING.md
PR-URL: #4747
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: techjeffharris
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Original commit:
0800c0a
doc: git mv to .md
* doc: rename .markdown references in content
* doc: rename to .md in tools
* doc: rename to .md in CONTRIBUTING.md
PR-URL: #4747
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: techjeffharris
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleaxaddaleax added doc Issues and PRs related to the documentations. v4.x labels Jul 1, 2016
@jasnell

Copy link
Copy Markdown
Member

LGTM

@Fishrock123

Copy link
Copy Markdown
Contributor

Curious, is this necessary for backports, or?

@eljefedelrodeodeljefe

Copy link
Copy Markdown
ContributorAuthor

It is as it would block necessary doc additions that happened after the
original PR.
On 1 Jul 2016 21:29, "Jeremiah Senkpiel" notifications@github.com wrote:

Curious, is this necessary for backports, or?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7507 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ADuBJOYOAD0iL0uqC_WnqGd4509z-tKFks5qRWp-gaJpZM4JDAIa
.

@MylesBorins

MylesBorins commented Jul 1, 2016 via email

Copy link
Copy Markdown
Contributor

@eljefedelrodeodeljefe

Copy link
Copy Markdown
ContributorAuthor

Your call. LGTY anyone else?

@jasnell

Copy link
Copy Markdown
Member

Decreases some of the backporting pain.
On Jul 1, 2016 12:28 PM, "Jeremiah Senkpiel" notifications@github.com
wrote:

Curious, is this necessary for backports, or?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#7507 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAa2eXSssfaEtKRYqGdtTqHw_VbvxsGqks5qRWpQgaJpZM4JDAIa
.

@eljefedelrodeodeljefe

Copy link
Copy Markdown
ContributorAuthor

Since I am a little busy next week I wanted to merge this today. Can I have another LGTM? @thealphanerd is that fine for you?

@MylesBorins

MylesBorins commented Jul 4, 2016 via email

Copy link
Copy Markdown
Contributor

@eljefedelrodeodeljefe

Copy link
Copy Markdown
ContributorAuthor

ACK.
On 4 Jul 2016 23:48, "Myles Borins" notifications@github.com wrote:

Please hold off on merging this. I'll review it tomorrow when in back to
work 😊.

Thanks!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7507 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ADuBJLydjrzsRVeEnNZQ6gO117jNs85iks5qSX-cgaJpZM4JDAIa
.

@MylesBorins

Copy link
Copy Markdown
Contributor

landed in 84f51b9

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@eljefedelrodeodeljefe@jasnell@Fishrock123@MylesBorins@addaleax