Skip to content

Backport for v4.x: test,win: skip addons/load-long-path on WOW64 - #7537

Merged
orangemocha merged 1 commit into
nodejs:v4.x-stagingfrom
JaneaSystems:orangemocha-backportPR6675
Jul 8, 2016
Merged

Backport for v4.x: test,win: skip addons/load-long-path on WOW64#7537
orangemocha merged 1 commit into
nodejs:v4.x-stagingfrom
JaneaSystems:orangemocha-backportPR6675

Conversation

@orangemocha

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs/lts, this is a clean backport of #6675.

Ref: #6675 (comment)

This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.
Ref: nodejs#3667
PR-URL: nodejs#6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jul 5, 2016
@jasnell

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@MylesBorins

Copy link
Copy Markdown
Contributor

LGTM

@MylesBorinsMylesBorins self-assigned this Jul 5, 2016
@orangemocha

orangemocha commented Jul 8, 2016

Copy link
Copy Markdown
ContributorAuthor

CI is green. Landing. Thank you!

https://ci.nodejs.org/job/node-test-commit/4020/

@orangemocha
orangemocha merged commit 350e8c6 into nodejs:v4.x-stagingJul 8, 2016
@MylesBorinsMylesBorins removed their assignment Dec 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@orangemocha@jasnell@MylesBorins@mscdex@joaocgreis@nodejs-github-bot