Uh oh!
There was an error while loading. Please reload this page.
tls, binding: backport of process.binding('config') and regression fix - #7551
Closed
jasnell wants to merge 3 commits into
Closed
tls, binding: backport of process.binding('config') and regression fix#7551jasnell wants to merge 3 commits into
jasnell wants to merge 3 commits into
Conversation
PR-URL: nodejs#6266 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
It turns out that userland likes to override process.config with
their own stuff. If we want to be able to depend on it in any way,
we need our own internal mechanism.
This adds a new private process.binding('config') that is
intended to serve as a container for internal flags and compile
time configs that need to be passed on to the JS layer.
PR-URL: nodejs#6266
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>When the fips mode check was added sometime in v4 it caused a regression in some edge cases (see nodejs#6114) because `process.config` can be overwritten by userland modules. This switches to using the backported process.binding('config') to fix the regression. Fixes: nodejs#6114
jasnell
commented
Jul 5, 2016
MemberAuthor
MylesBorins
commented
Jul 11, 2016
Contributor
landed in 4184cb0...f5756d9 |
MylesBorins
commented
Jul 14, 2016
Contributor
LGTM |
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
When the fips mode check was added sometime in v4 it caused a regression in some edge cases (see #6114) because `process.config` can be overwritten by userland modules. This switches to using the backported process.binding('config') to fix the regression. Fixes: #6114 PR-URL: #7551 Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
When the fips mode check was added sometime in v4 it caused a regression in some edge cases (see #6114) because `process.config` can be overwritten by userland modules. This switches to using the backported process.binding('config') to fix the regression. Fixes: #6114 PR-URL: #7551 Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
process.binding, tls
Description of change
Cherry picks the addition of process.binding('config') to v4.x and fixes the regression in #6114
/cc @thealphanerd