Skip to content

build: respect --shared-* flags for inspector deps - #7569

Merged
ChALkeR merged 1 commit into
nodejs:masterfrom
ChALkeR:inspector-shared-deps
Jul 9, 2016
Merged

build: respect --shared-* flags for inspector deps#7569
ChALkeR merged 1 commit into
nodejs:masterfrom
ChALkeR:inspector-shared-deps

Conversation

@ChALkeR

@ChALkeRChALkeR commented Jul 6, 2016•
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

Don't build openssl/http_parser/libuv for v8_inspector if corresponding --shared-* flags were passed to the ./configure script.

Fixes: #7478

./configure --shared-openssl --without-intl --shared-http-parser; make -j4 test works and doesn't build openssl and http-parser even with v8_inspector enabled.
#7486 fixed that only for the case when --without-inspector was passed.

CI: https://ci.nodejs.org/job/node-test-pull-request/3194/

/cc @bnoordhuis@ofrobots

@ChALkeRChALkeR added the build Issues and PRs related to build files or the CI. label Jul 6, 2016
@mscdexmscdex added openssl Issues and PRs related to the OpenSSL dependency. libuv Issues and PRs related to the libuv dependency or the uv binding. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. labels Jul 6, 2016
@MylesBorins

MylesBorins commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

will land tomorrow if CI is green and we have no objects

/cc @nodejs/lts @nodejs/collaborators

ci: https://ci.nodejs.org/job/node-test-pull-request/3196/

@ChALkeRChALkeR added the inspector Issues and PRs related to the V8 inspector protocol label Jul 7, 2016
@bnoordhuis

bnoordhuis commented Jul 7, 2016

Copy link
Copy Markdown
Member

LGTM

@ChALkeRChALkeR mentioned this pull request Jul 7, 2016
Closed
@ChALkeR

ChALkeR commented Jul 8, 2016

Copy link
Copy Markdown
MemberAuthor

Note: this also fixes #7583.

@ofrobots

ofrobots commented Jul 8, 2016

Copy link
Copy Markdown
Contributor

LGTM

@ChALkeR
ChALkeRforce-pushed the inspector-shared-deps branch from 485d167 to b0eac38CompareJuly 9, 2016 07:13
@ChALkeR

ChALkeR commented Jul 9, 2016•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

The only failing test in CI was test-net-write-slow on FreeBSD, it was known flaky (#7555).
Landing 990c968.

@ChALkeR
build: respect --shared-* flags for inspector deps
990c968
Don't build openssl/http_parser/libuv for v8_inspector if corresponding
--shared-* flags were passed to the ./configure script.
Fixes: nodejs#7478Fixes: nodejs#7583
PR-URL: nodejs#7569
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@ChALkeR
ChALkeRforce-pushed the inspector-shared-deps branch from b0eac38 to 990c968CompareJuly 9, 2016 07:23
@ChALkeR
ChALkeR merged commit 990c968 into nodejs:masterJul 9, 2016
@MylesBorinsMylesBorins mentioned this pull request Jul 11, 2016
Closed
evanlucas pushed a commit that referenced this pull request Jul 13, 2016
@ChALkeR@evanlucas
build: respect --shared-* flags for inspector deps
933ff62
Don't build openssl/http_parser/libuv for v8_inspector if corresponding
--shared-* flags were passed to the ./configure script.
Fixes: #7478Fixes: #7583
PR-URL: #7569
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@evanlucasevanlucas mentioned this pull request Jul 18, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.http_parserIssues and PRs related to the HTTP Parser dependency or the http_parser binding.inspectorIssues and PRs related to the V8 inspector protocollibuvIssues and PRs related to the libuv dependency or the uv binding.opensslIssues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build: --shared-openssl still builds openssl

5 participants

@ChALkeR@MylesBorins@bnoordhuis@ofrobots@mscdex