Skip to content

benchmark: remove unused variables - #7600

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:min-used
Closed

benchmark: remove unused variables#7600
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:min-used

Conversation

@Trott

@TrottTrott commented Jul 7, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark dgram http

Description of change

Remove variables that are assigned but never used.

(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)

@Trott
benchmark: remove unused variables
5246294
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
@TrottTrott added http Issues or PRs related to the http subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. benchmark Issues and PRs related to the benchmark subsystem. labels Jul 7, 2016
@Trott

Trott commented Jul 7, 2016

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/3210/

@TrottTrott mentioned this pull request Jul 7, 2016
Closed
9 tasks
@Trott

Trott commented Jul 8, 2016

Copy link
Copy Markdown
MemberAuthor

CI is green.

@rvagg

rvagg commented Jul 8, 2016

Copy link
Copy Markdown
Member

lgtm

@targos

targos commented Jul 8, 2016

Copy link
Copy Markdown
Member

LGTM

@Fishrock123

Fishrock123 commented Jul 8, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

rubber-stamp lgtm

Trott added a commit to Trott/io.js that referenced this pull request Jul 11, 2016
@Trott
benchmark: remove unused variables
ce9456d
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
PR-URL: nodejs#7600
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott

Trott commented Jul 11, 2016•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Landed in ce9456d

@TrottTrott closed this Jul 11, 2016
@MylesBorinsMylesBorins mentioned this pull request Jul 11, 2016
Closed
@MylesBorins

MylesBorins commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

@Trott what was the correct commit?

MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@TrottMyles Borins
benchmark: remove unused variables
520c0b0
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
PR-URL: #7600
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@TrottMyles Borins
benchmark: remove unused variables
164b87d
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
PR-URL: #7600
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott

Trott commented Jul 12, 2016

Copy link
Copy Markdown
MemberAuthor

@thealphanerd Correct commit is ce9456d. I left off the first character above. Will edit that comment.

MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott@MylesBorins
benchmark: remove unused variables
eaf40a0
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
PR-URL: #7600
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@TrottMyles Borins
benchmark: remove unused variables
3a3247b
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
PR-URL: #7600
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@TrottMyles Borins
benchmark: remove unused variables
da628d3
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
PR-URL: #7600
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@TrottMyles Borins
benchmark: remove unused variables
0df6431
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
PR-URL: #7600
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@TrottMyles Borins
benchmark: remove unused variables
4b464ce
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
PR-URL: #7600
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
evanlucas pushed a commit that referenced this pull request Jul 15, 2016
@Trott@evanlucas
benchmark: remove unused variables
3747d91
Remove variables that are assigned but never used.
(This was missed by the linter in previous versions of ESLint but is
flagged by the current version. Updating the linter is contingent on
this change or some similar remedy landing.)
PR-URL: #7600
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@evanlucasevanlucas mentioned this pull request Jul 18, 2016
Merged
@Trott
Trott deleted the min-used branch January 13, 2022 22:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.dgramIssues and PRs related to the dgram subsystem / UDP.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@rvagg@targos@Fishrock123@MylesBorins