Uh oh!
There was an error while loading. Please reload this page.
doc: add benchmark who-to-CC info - #7604
Closed
Trott wants to merge 2 commits into
Closed
Conversation
bnoordhuis
commented
Jul 8, 2016
Member
By that metric I'd probably have to be cc'd on everything. :-) I'm happy to be left off here, I don't look at the benchmarks much. |
| | subsystem | maintainers | | ||
| | --- | --- | | ||
| | `benchamrk/*` | @nodejs/benchmarking, @mscdex, @bnoordhuis | |
Trott
commented
Jul 8, 2016
MemberAuthor
Fixed the spelling, removed bnoordhuis. PTAL |
bnoordhuis
commented
Jul 9, 2016
Member
LGTM on my end. |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jul 11, 2016
Add benchmark to "Who to CC". Also, alphabetized the only non-alphabetized subsystem. PR-URL: nodejs#7604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Trott
commented
Jul 11, 2016
MemberAuthor
Landed in a528d0d |
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Add benchmark to "Who to CC". Also, alphabetized the only non-alphabetized subsystem. PR-URL: #7604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Add benchmark to "Who to CC". Also, alphabetized the only non-alphabetized subsystem. PR-URL: #7604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Add benchmark to "Who to CC". Also, alphabetized the only non-alphabetized subsystem. PR-URL: #7604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit
that referenced
this pull request
Jul 12, 2016
Add benchmark to "Who to CC". Also, alphabetized the only non-alphabetized subsystem. PR-URL: #7604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
Add benchmark to "Who to CC". Also, alphabetized the only non-alphabetized subsystem. PR-URL: #7604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2016
Add benchmark to "Who to CC". Also, alphabetized the only non-alphabetized subsystem. PR-URL: #7604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas pushed a commit
that referenced
this pull request
Jul 15, 2016
Add benchmark to "Who to CC". Also, alphabetized the only non-alphabetized subsystem. PR-URL: #7604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc benchmark
Description of change
Add
benchmarkto "Who to CC". Also, alphabetized the only non-alphabetized subsystem.Added @nodejs/benchmarking because that seems to make sense.
Added @mscdex because if he shouldn't be there, no one should.
Added @bnoordhuis based on
git shortlog -n -s benchmark.Happy to remove any of those and add anyone else that makes sense, but this was my guess.