src: disable stdio buffering by bnoordhuis · Pull Request #7610 · nodejs/node

bnoordhuis · 2016-07-08T10:49:38Z

Disable stdio buffering, it interacts poorly with printf() calls from
elsewhere in the program (e.g., any logging from V8.) Unbreaks among
other things the --trace_debug_json switch.

Undoes commit 0966ab9 ("src: force line buffering for stderr"), which
in retrospect is not a proper fix. Turning on line buffering fixed a
flaky test on SmartOS but the test wasn't failing on other platforms,
where stderr wasn't line-buffered either.

Disabling buffering should be safe even when mixed with non-blocking
stdio I/O because libuv goes to great lengths to reopen the tty file
descriptors and falls back to blocking I/O when that fails.

R=@Trott?

bnoordhuis · 2016-07-08T10:52:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/3216/

smartos-64 stress test: https://ci.nodejs.org/job/node-stress-single-test/794/

MylesBorins · 2016-07-08T14:44:51Z

Should this be back ported to v4?

Trott · 2016-07-08T18:15:11Z

Looks like it makes the test flaky again, so at a minimum, I guess this should mark the test flaky again in parallel.status. :-|

Trott · 2016-07-08T18:21:48Z

Any chance the parallel/test-vm-sigint failure on FreeBSD in the CI run is related to this change? Doesn't seem like it to me, but ¯_(ツ)_/¯. I haven't seen that one fail before, but it's also a relatively new test. /cc @addaleax https://ci.nodejs.org/job/node-test-commit-freebsd/3201/nodes=freebsd10-64/tapTestReport/test.tap-1065/

addaleax · 2016-07-08T21:34:45Z

@Trott I’d say its unrelated, thanks for pinging me on this, I’ll look into it. :)

bnoordhuis · 2016-07-09T11:46:10Z

Test marked FLAKY. Can I get a LGTM?

addaleax · 2016-07-09T17:51:11Z

LGTM

Trott · 2016-07-10T02:10:33Z

LGTM

Trott · 2016-07-10T02:26:56Z

Running CI one more time mostly for confirmation of FreeBSD issue non-relevance: https://ci.nodejs.org/job/node-test-pull-request/3233/

bnoordhuis · 2016-07-10T08:02:15Z

Java exceptions on the pi1-raspbian-wheezy buildbots. Haven't seen this one before...

java.lang.IllegalStateException: Invalid object ID 214 iota=215

Since they were green last time, I'll land this later today unless someone disagrees.

Trott · 2016-07-10T15:21:01Z

Disable stdio buffering, it interacts poorly with printf() calls from elsewhere in the program (e.g., any logging from V8.) Unbreaks among other things the `--trace_debug_json` switch. Undoes commit 0966ab9 ("src: force line buffering for stderr"), which in retrospect is not a proper fix. Turning on line buffering fixed a flaky test on SmartOS but the test wasn't failing on other platforms, where stderr wasn't line-buffered either. Mark the test flaky again, it failed once in a run of 333 tries on the smartos-64 buildbot. Disabling buffering should be safe even when mixed with non-blocking stdio I/O because libuv goes to great lengths to reopen the tty file descriptors and falls back to blocking I/O when that fails. PR-URL: nodejs#7610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

bnoordhuis · 2016-07-11T21:18:15Z

@thealphanerd Eventually, but let's give it a little time. I'd like to see it go into one or two v6 releases first, just to check if it doesn't break anything.

MylesBorins · 2016-07-11T21:24:41Z

sgtm @bnoordhuis

Disable stdio buffering, it interacts poorly with printf() calls from elsewhere in the program (e.g., any logging from V8.) Unbreaks among other things the `--trace_debug_json` switch. Undoes commit 0966ab9 ("src: force line buffering for stderr"), which in retrospect is not a proper fix. Turning on line buffering fixed a flaky test on SmartOS but the test wasn't failing on other platforms, where stderr wasn't line-buffered either. Mark the test flaky again, it failed once in a run of 333 tries on the smartos-64 buildbot. Disabling buffering should be safe even when mixed with non-blocking stdio I/O because libuv goes to great lengths to reopen the tty file descriptors and falls back to blocking I/O when that fails. PR-URL: #7610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins · 2016-10-10T17:08:11Z

ping @bnoordhuis

Disable stdio buffering, it interacts poorly with printf() calls from elsewhere in the program (e.g., any logging from V8.) Unbreaks among other things the `--trace_debug_json` switch. Undoes commit 0966ab9 ("src: force line buffering for stderr"), which in retrospect is not a proper fix. Turning on line buffering fixed a flaky test on SmartOS but the test wasn't failing on other platforms, where stderr wasn't line-buffered either. Mark the test flaky again, it failed once in a run of 333 tries on the smartos-64 buildbot. Disabling buffering should be safe even when mixed with non-blocking stdio I/O because libuv goes to great lengths to reopen the tty file descriptors and falls back to blocking I/O when that fails. PR-URL: nodejs#7610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

bnoordhuis · 2016-10-20T12:00:56Z

#9203 - cherry-pick to v4.x.

Disable stdio buffering, it interacts poorly with printf() calls from elsewhere in the program (e.g., any logging from V8.) Unbreaks among other things the `--trace_debug_json` switch. Undoes commit 0966ab9 ("src: force line buffering for stderr"), which in retrospect is not a proper fix. Turning on line buffering fixed a flaky test on SmartOS but the test wasn't failing on other platforms, where stderr wasn't line-buffered either. Mark the test flaky again, it failed once in a run of 333 tries on the smartos-64 buildbot. Disabling buffering should be safe even when mixed with non-blocking stdio I/O because libuv goes to great lengths to reopen the tty file descriptors and falls back to blocking I/O when that fails. PR-URL: #7610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

bnoordhuis added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 8, 2016

bnoordhuis force-pushed the disable-stdio-buffering branch from 93aea92 to c2d15cbCompare July 9, 2016 11:45

bnoordhuis force-pushed the disable-stdio-buffering branch from c2d15cb to cfe76f2Compare July 11, 2016 21:17

bnoordhuis closed this Jul 11, 2016

bnoordhuis deleted the disable-stdio-buffering branch July 11, 2016 21:17

bnoordhuis merged commit cfe76f2 into nodejs:masterJul 11, 2016

MylesBorins added the lts-watch-v4.x label Jul 11, 2016

evanlucas mentioned this pull request Jul 18, 2016
v6.3.1 Release Proposal #7782
Merged

bnoordhuis mentioned this pull request Oct 20, 2016
src: disable stdio buffering #9203
Closed

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Oct 24, 2016

MylesBorins mentioned this pull request Oct 26, 2016
V4.6.2 proposal #9298
Closed

Uh oh!

Uh oh!

Conversation

bnoordhuis commented Jul 8, 2016

Uh oh!

bnoordhuis commented Jul 8, 2016

Uh oh!

MylesBorins commented Jul 8, 2016

Uh oh!

Trott commented Jul 8, 2016

Uh oh!

Trott commented Jul 8, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax commented Jul 8, 2016

Uh oh!

bnoordhuis commented Jul 9, 2016

Uh oh!

addaleax commented Jul 9, 2016

Uh oh!

Trott commented Jul 10, 2016

Uh oh!

Trott commented Jul 10, 2016

Uh oh!

bnoordhuis commented Jul 10, 2016

Uh oh!

Trott commented Jul 10, 2016

Uh oh!

bnoordhuis commented Jul 11, 2016

Uh oh!

MylesBorins commented Jul 11, 2016

Uh oh!

MylesBorins commented Oct 10, 2016

Uh oh!

bnoordhuis commented Oct 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Trott commented Jul 8, 2016•
edited
Loading